Skip to content

Commit fa85372

Browse files
kasperk81jkotas
andauthored
Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
1 parent 4a5af3c commit fa85372

File tree

6 files changed

+4
-7
lines changed

6 files changed

+4
-7
lines changed

docs/project/glossary.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ terminology.
4343
| POGO | Profile Guided Optimization - see [details](https://blogs.msdn.microsoft.com/vcblog/2008/11/12/pogo/). |
4444
| ProjectN | Codename for the first version of [.NET Native for UWP](https://msdn.microsoft.com/vstudio/dotnetnative.aspx). |
4545
| R2R | Ready-to-Run. A flavor of native images - command line switch of [crossgen](../workflow/building/coreclr/crossgen.md). |
46+
| Redhawk | Codename for experimental minimal managed code runtime that evolved into [CoreRT](https://github.com/dotnet/corert/). |
4647
| SDK | Software Development Kit. The [.NET SDK](https://learn.microsoft.com/dotnet/core/sdk) contains the .NET CLI, .NET libraries and runtime, and the dotnet driver. |
4748
| SEH | [Structured Exception Handling](https://learn.microsoft.com/windows/win32/debug/structured-exception-handling). Unified mechanism for handling hardware and software exceptions on Windows. |
4849
| SOS | [Son of Strike](https://learn.microsoft.com/dotnet/framework/tools/sos-dll-sos-debugging-extension). The debugging extension for DbgEng based debuggers. Uses the DAC as an abstraction layer for its operation. The obscure name derives from the original nickname for the CLR team at Microsoft: "Lightning". The team built a debugging tool humorously named "Strike", and a subset of that dubbed "Son of Strike". |

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/InteropServices/OutAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace System.Runtime.InteropServices
55
{
6-
// Not used in NativeAOT. Only here as C# compiler requires it
6+
// Only here as C# compiler requires it
77
[AttributeUsage(AttributeTargets.Parameter, Inherited = false)]
88
internal sealed class OutAttribute : Attribute
99
{

src/coreclr/nativeaot/Runtime.Base/src/System/RuntimeTypeHandle.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
// System.Type and System.RuntimeTypeHandle are defined here as the C# compiler requires them
5-
// In the NativeAOT runtime these are not used. In the class library there is an implementation that support typeof
65

76
using System;
87
using System.Runtime.CompilerServices;

src/coreclr/nativeaot/Runtime/ObjectLayout.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
//
77

88
// Bits stolen from the sync block index that the GC/HandleTable knows about (currently these are at the same
9-
// positions as the mainline runtime but we can change this below when it becomes apparent how NativeAOT will
10-
// handle sync blocks).
9+
// positions as the mainline runtime).
1110
#define BIT_SBLK_GC_RESERVE 0x20000000
1211
#define BIT_SBLK_FINALIZER_RUN 0x40000000
1312

src/coreclr/nativeaot/Runtime/Pal.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@
6464
#endif // TARGET_UNIX
6565

6666
#ifdef TARGET_UNIX
67-
// There are some fairly primitive type definitions below but don't pull them into the rest of NativeAOT unless
68-
// we have to (in which case these definitions will move to CommonTypes.h).
6967
typedef int32_t HRESULT;
7068

7169
#define S_OK 0x0

src/coreclr/nativeaot/Runtime/eventtrace_etw.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
//
55
// This header provides NativeAOT-specific ETW code and macros, to allow sharing of common
6-
// ETW code between NativeAOT and desktop CLR.
6+
// ETW code.
77
//
88
#ifndef EVENTTRACE_ETW_H
99
#define EVENTTRACE_ETW_H

0 commit comments

Comments
 (0)