Skip to content

Commit f9dc66b

Browse files
authored
Replace UIntPtr with nuint on managed JIT/EE interface (#120648)
1 parent 3ee77a3 commit f9dc66b

File tree

17 files changed

+90
-89
lines changed

17 files changed

+90
-89
lines changed

src/coreclr/inc/corinfo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2404,11 +2404,11 @@ class ICorStaticInfo
24042404
int* offset
24052405
) = 0;
24062406

2407-
virtual size_t getClassStaticDynamicInfo (
2407+
virtual void* getClassStaticDynamicInfo (
24082408
CORINFO_CLASS_HANDLE cls
24092409
) = 0;
24102410

2411-
virtual size_t getClassThreadStaticDynamicInfo (
2411+
virtual void* getClassThreadStaticDynamicInfo (
24122412
CORINFO_CLASS_HANDLE cls
24132413
) = 0;
24142414

src/coreclr/inc/icorjitinfoimpl_generated.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,10 @@ bool getIsClassInitedFlagAddress(
219219
CORINFO_CONST_LOOKUP* addr,
220220
int* offset) override;
221221

222-
size_t getClassThreadStaticDynamicInfo(
222+
void* getClassThreadStaticDynamicInfo(
223223
CORINFO_CLASS_HANDLE clr) override;
224224

225-
size_t getClassStaticDynamicInfo(
225+
void* getClassStaticDynamicInfo(
226226
CORINFO_CLASS_HANDLE clr) override;
227227

228228
bool getStaticBaseAddress(

src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,20 +483,20 @@ bool WrapICorJitInfo::getIsClassInitedFlagAddress(
483483
return temp;
484484
}
485485

486-
size_t WrapICorJitInfo::getClassThreadStaticDynamicInfo(
486+
void* WrapICorJitInfo::getClassThreadStaticDynamicInfo(
487487
CORINFO_CLASS_HANDLE clr)
488488
{
489489
API_ENTER(getClassThreadStaticDynamicInfo);
490-
size_t temp = wrapHnd->getClassThreadStaticDynamicInfo(clr);
490+
void* temp = wrapHnd->getClassThreadStaticDynamicInfo(clr);
491491
API_LEAVE(getClassThreadStaticDynamicInfo);
492492
return temp;
493493
}
494494

495-
size_t WrapICorJitInfo::getClassStaticDynamicInfo(
495+
void* WrapICorJitInfo::getClassStaticDynamicInfo(
496496
CORINFO_CLASS_HANDLE clr)
497497
{
498498
API_ENTER(getClassStaticDynamicInfo);
499-
size_t temp = wrapHnd->getClassStaticDynamicInfo(clr);
499+
void* temp = wrapHnd->getClassStaticDynamicInfo(clr);
500500
API_LEAVE(getClassStaticDynamicInfo);
501501
return temp;
502502
}

src/coreclr/jit/flowgraph.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -777,8 +777,9 @@ GenTreeCall* Compiler::fgGetStaticsCCtorHelper(CORINFO_CLASS_HANDLE cls, CorInfo
777777
helper == CORINFO_HELP_GETPINNED_GCSTATIC_BASE_NOCTOR ||
778778
helper == CORINFO_HELP_GETPINNED_NONGCSTATIC_BASE_NOCTOR)
779779
{
780-
result = gtNewHelperCallNode(helper, type,
781-
gtNewIconNode(info.compCompHnd->getClassStaticDynamicInfo(cls), TYP_I_IMPL));
780+
result =
781+
gtNewHelperCallNode(helper, type,
782+
gtNewIconNode((size_t)info.compCompHnd->getClassStaticDynamicInfo(cls), TYP_I_IMPL));
782783
}
783784
else
784785
{

src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2151,7 +2151,7 @@ private uint getClassAttribsInternal(TypeDesc type)
21512151
}
21522152

21532153
#pragma warning disable CA1822 // Mark members as static
2154-
private void* LongLifetimeMalloc(UIntPtr sz)
2154+
private void* LongLifetimeMalloc(nuint sz)
21552155
#pragma warning restore CA1822 // Mark members as static
21562156
{
21572157
return NativeMemory.Alloc(sz);
@@ -2164,9 +2164,9 @@ private void LongLifetimeFree(void* obj)
21642164
NativeMemory.Free(obj);
21652165
}
21662166

2167-
private UIntPtr getClassStaticDynamicInfo(CORINFO_CLASS_STRUCT_* cls)
2167+
private void* getClassStaticDynamicInfo(CORINFO_CLASS_STRUCT_* cls)
21682168
{ throw new NotImplementedException("getClassStaticDynamicInfo"); }
2169-
private UIntPtr getClassThreadStaticDynamicInfo(CORINFO_CLASS_STRUCT_* cls)
2169+
private void* getClassThreadStaticDynamicInfo(CORINFO_CLASS_STRUCT_* cls)
21702170
{ throw new NotImplementedException("getClassThreadStaticDynamicInfo"); }
21712171

21722172
private uint getClassSize(CORINFO_CLASS_STRUCT_* cls)
@@ -2616,7 +2616,7 @@ private GetTypeLayoutResult GetTypeLayoutHelper(MetadataType type, uint parentIn
26162616
return GetTypeLayoutResult.Success;
26172617
}
26182618

2619-
private GetTypeLayoutResult getTypeLayout(CORINFO_CLASS_STRUCT_* typeHnd, CORINFO_TYPE_LAYOUT_NODE* treeNodes, UIntPtr* numTreeNodes)
2619+
private GetTypeLayoutResult getTypeLayout(CORINFO_CLASS_STRUCT_* typeHnd, CORINFO_TYPE_LAYOUT_NODE* treeNodes, nuint* numTreeNodes)
26202620
{
26212621
TypeDesc type = HandleToObject(typeHnd);
26222622

@@ -3222,7 +3222,7 @@ private void reportMetadata(byte* key, void* value, nuint length)
32223222
}
32233223

32243224
#pragma warning disable CA1822 // Mark members as static
3225-
private void* allocateArray(UIntPtr cBytes)
3225+
private void* allocateArray(nuint cBytes)
32263226
#pragma warning restore CA1822 // Mark members as static
32273227
{
32283228
return NativeMemory.Alloc(cBytes);
@@ -3347,10 +3347,10 @@ private void getEEInfo(ref CORINFO_EE_INFO pEEInfoOut)
33473347

33483348
pEEInfoOut.sizeOfReversePInvokeFrame = (uint)SizeOfReversePInvokeTransitionFrame;
33493349

3350-
pEEInfoOut.osPageSize = new UIntPtr(0x1000);
3350+
pEEInfoOut.osPageSize = 0x1000;
33513351

33523352
pEEInfoOut.maxUncheckedOffsetForNullObject = (_compilation.NodeFactory.Target.IsWindows) ?
3353-
new UIntPtr(32 * 1024 - 1) : new UIntPtr((uint)pEEInfoOut.osPageSize / 2 - 1);
3353+
(32 * 1024 - 1) : (pEEInfoOut.osPageSize / 2 - 1);
33543354

33553355
pEEInfoOut.targetAbi = TargetABI;
33563356
pEEInfoOut.osType = TargetToOs(_compilation.NodeFactory.Target);
@@ -3867,9 +3867,9 @@ private void allocUnwindInfo(byte* pHotCode, byte* pColdCode, uint startOffset,
38673867
#endif
38683868
}
38693869

3870-
private void* allocGCInfo(UIntPtr size)
3870+
private void* allocGCInfo(nuint size)
38713871
{
3872-
_gcInfo = new byte[(int)size];
3872+
_gcInfo = new byte[size];
38733873
return (void*)GetPin(_gcInfo);
38743874
}
38753875

0 commit comments

Comments
 (0)