Skip to content

Commit f582c0b

Browse files
Fix URL encoding of HttpUtility.ParseQueryString's ToString method (#98263)
* Fix URL encoding of `HttpUtility.ParseQueryString`'s `ToString` method * Add test
1 parent b2d27d8 commit f582c0b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/libraries/System.Web.HttpUtility/src/System/Web/HttpUtility.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public override string ToString()
6767
{
6868
if (!string.IsNullOrEmpty(key))
6969
{
70-
sb.Append(key).Append('=');
70+
sb.Append(UrlEncode(key)).Append('=');
7171
}
7272
sb.Append(UrlEncode(value)).Append('&');
7373
}

src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -792,6 +792,7 @@ public void UrlPathEncode(string decoded, string encoded)
792792
[InlineData("foo&bar")]
793793
[InlineData("foo&name=bar")]
794794
[InlineData("name=bar&foo&foo")]
795+
[InlineData("_return_fields%2b=extattrs&name%3a=somename.somedomain.local")]
795796
public void ParseAndToStringMaintainAllKeyValuePairs(string input)
796797
{
797798
var values = HttpUtility.ParseQueryString(input);

0 commit comments

Comments
 (0)