Commit edb7d7e
authored
Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs where possible. (#74567)
* Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
Workaround crash hit by #74179
making sure we avoid hitting codepath emitting this null pointer checks.
The full fix includes codegen fixes as well, but will be performed
in separate PR. There are still locations in SpanHelper.T.cs that uses
Equal virtual call on value types that could be managed pointers to
value types, but that code has remained the same for the last
4 years to 15 months and have not hit this issue in the past.
* Re-enable globalization tests disabled in #74433.1 parent 48a3dbe commit edb7d7e
File tree
3 files changed
+2
-5
lines changed- src/libraries
- System.Globalization/tests
- CompareInfo
- Invariant
- System.Private.CoreLib/src/System
3 files changed
+2
-5
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
187 | 186 | | |
188 | 187 | | |
189 | 188 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
864 | 864 | | |
865 | 865 | | |
866 | 866 | | |
867 | | - | |
868 | 867 | | |
869 | 868 | | |
870 | 869 | | |
| |||
912 | 911 | | |
913 | 912 | | |
914 | 913 | | |
915 | | - | |
916 | 914 | | |
917 | 915 | | |
918 | 916 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1498 | 1498 | | |
1499 | 1499 | | |
1500 | 1500 | | |
1501 | | - | |
| 1501 | + | |
1502 | 1502 | | |
1503 | 1503 | | |
1504 | 1504 | | |
| |||
2145 | 2145 | | |
2146 | 2146 | | |
2147 | 2147 | | |
2148 | | - | |
| 2148 | + | |
2149 | 2149 | | |
2150 | 2150 | | |
2151 | 2151 | | |
| |||
0 commit comments