Feedback + disabling platforms where EventPipe can't loopback

Author: noahfalk

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/Harness/EventPipeListener.cs

@@ -39,7 +39,9 @@ public EventPipeListener() { }
         public override void EventSourceCommand(string eventSourceName, EventCommand command, FilteringOptions options = null)
         {
             if (eventSourceName is null)
+            {
                 throw new ArgumentNullException(nameof(eventSourceName));
+            }
 
             if (_session != null)
             {
@@ -51,7 +53,9 @@ public override void EventSourceCommand(string eventSourceName, EventCommand com
         public override void Start()
         {
             if (_session != null)
+            {
                 return; // already started
+            }
 
             // Build provider enable list from pending commands
             foreach (var (eventSourceName, command, options) in _pendingCommands)
@@ -91,7 +95,9 @@ private void ProcessEvents(EventPipeSession session)
             {
                 // EventPipe adds extra events we didn't ask for, ignore them.
                 if (traceEvent.ProviderName == "Microsoft-DotNETCore-EventPipe")
+                {
                     return;
+                }
 
                 OnEvent?.Invoke(new EventPipeEvent(traceEvent));
             };
@@ -101,7 +107,9 @@ private void ProcessEvents(EventPipeSession session)
         public override void Dispose()
         {
             if (_disposed)
+            {
                 return;
+            }
             _disposed = true;
             _session?.Stop();
             _session?.Dispose();
@@ -152,7 +160,9 @@ public EventPipeEvent(TraceEvent data)
             public override object PayloadValue(int propertyIndex, string propertyName)
             {
                 if (propertyName != null)
+                {
                     Assert.Equal(propertyName, _payloadNames[propertyIndex]);
+                }
                 return _payloadValues[propertyIndex];
             }
         }

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/Harness/Listeners.cs

@@ -51,7 +51,7 @@ public abstract class Listener : IDisposable
 
         public void EventSourceSynchronousEnable(EventSource eventSource, FilteringOptions options = null)
         {
-            if(!IsDynamicConfigChangeSupported)
+            if (!IsDynamicConfigChangeSupported)
             {
                 throw new InvalidOperationException("This listener does not support dynamic config changes");
             }

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWrite.cs

@@ -29,7 +29,7 @@ private struct PartB_UserInfo
         public static TheoryData<Listener> GetListeners()
         {
             TheoryData<Listener> data = new TheoryData<Listener>();
-            if (PlatformDetection.IsNetCore)
+            if (PlatformDetection.IsNetCore && PlatformDetection.IsNotAndroid && PlatformDetection.IsNotBrowser && PlatformDetection.IsNotMonoRuntime)
             {
                 data.Add(new EventPipeListener());
             }

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWriteEvent.cs

@@ -30,7 +30,7 @@ public static TheoryData<Listener,bool> GetListenerConfigurations()
         public static TheoryData<Listener> GetListeners()
         {
             TheoryData<Listener> data = new TheoryData<Listener>();
-            if(PlatformDetection.IsNetCore)
+            if (PlatformDetection.IsNetCore && PlatformDetection.IsNotAndroid && PlatformDetection.IsNotBrowser && PlatformDetection.IsNotMonoRuntime)
             {
                 data.Add(new EventPipeListener());
             }
@@ -380,7 +380,6 @@ private void Test_WriteEvent_Helper(Listener listener, bool useSelfDescribingEve
 
         /**********************************************************************/
 
-
         [Theory]
         [MemberData(nameof(GetListeners))]
         public void Test_WriteEvent_ComplexData_SelfDescribing(Listener listener)