Improve error message for TypedHttpClient missing constructor parameter (#108670)

* Improve error message for TypedHttpClient missing constructor parameter

* Address code review comments

* Update src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs

---------

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>

Author: andrewjsaid

src/libraries/Microsoft.Extensions.Http/src/DefaultTypedHttpClientFactory.cs

@@ -35,7 +35,17 @@ public TClient CreateClient(HttpClient httpClient)
         // as a transient, so that it doesn't close over the application root service provider.
         public sealed class Cache
         {
-            private static readonly Func<ObjectFactory> _createActivator = () => ActivatorUtilities.CreateFactory(typeof(TClient), new Type[] { typeof(HttpClient), });
+            private static readonly Func<ObjectFactory> _createActivator = () =>
+            {
+                try
+                {
+                    return ActivatorUtilities.CreateFactory(typeof(TClient), new Type[] { typeof(HttpClient), });
+                }
+                catch (InvalidOperationException iox)
+                {
+                    throw new InvalidOperationException(SR.Format(SR.TypedClient_NoHttpClientCtor, typeof(TClient).Name), iox);
+                }
+            };
 
             private ObjectFactory? _activator;
             private bool _initialized;

src/libraries/Microsoft.Extensions.Http/src/Resources/Strings.resx

@@ -141,4 +141,8 @@
 2 = Environment.NewLine
 3 = handler.ToString()</comment>
   </data>
+    <data name="TypedClient_NoHttpClientCtor" xml:space="preserve">
+    <value>A suitable constructor for type '{0}' could not be located. A Typed client must provide a constructor taking a 'System.Net.Http.HttpClient' as a parameter.</value>
+    <comment>{0} = instance type</comment>
+  </data>
 </root>

src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs

@@ -602,6 +602,22 @@ public void AddHttpClient_AddSameTypedClientTwice_WithDifferentNames_WithAddType
             Assert.Equal(2, clients.Count());
         }
 
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        public void AddHttpClient_TypedClient_NoHttpClientCtor_ThrowsSpecificException()
+        {
+            // Arrange
+            var serviceCollection = new ServiceCollection();
+            serviceCollection.AddHttpClient<TypedClientNoHttpClientCtor>();
+
+            var services = serviceCollection.BuildServiceProvider();
+
+            // Act
+            var ex = Assert.Throws<InvalidOperationException>(() => services.GetRequiredService<TypedClientNoHttpClientCtor>());
+            Assert.Equal(
+                SR.Format(SR.TypedClient_NoHttpClientCtor, typeof(TypedClientNoHttpClientCtor).Name),
+                ex.Message);
+        }
+
         [Fact]
         public void AddHttpClient_AddSameNameWithTypedClientTwice_ThrowsError()
         {
@@ -1573,6 +1589,18 @@ public TypedClientWithTransientService(HttpClient httpClient, TransientService s
 
             public TransientService Service { get; }
         }
+
+        // Simple typed client but the HttpClient parameter is missing
+        private class TypedClientNoHttpClientCtor
+        {
+            // This is an error case - do not use Typed clients like this!
+            public TypedClientNoHttpClientCtor(IHttpClientFactory httpClientFactory)
+            {
+                HttpClientFactory = httpClientFactory;
+            }
+
+            public IHttpClientFactory HttpClientFactory { get; }
+        }
     }
 }