Skip to content

Commit d664d3f

Browse files
committed
Rename ci_run to retainOnlyTop
1 parent 7fd043e commit d664d3f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/coreclr/scripts/superpmi.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@
318318
asm_diff_parser.add_argument("-diff_jit_option", action="append", help="Option to pass to the diff JIT. Format is key=value, where key is the option name without leading COMPlus_...")
319319
asm_diff_parser.add_argument("-tag", help="Specify a word to add to the directory name where the asm diffs will be placed")
320320
asm_diff_parser.add_argument("-metrics", action="append", help="Metrics option to pass to jit-analyze. Can be specified multiple times, or pass comma-separated values.")
321-
asm_diff_parser.add_argument("-ci_run", action="store_true", help="Is this a CI-run? If yes, it will pass a flag to jit-analyze to delete unnecessary .dasm files.")
321+
asm_diff_parser.add_argument("-retainOnlyTopFiles", action="store_true", help="Is passed, it will retain only top .dasm files that has largest diffs and delete remaining files.")
322322

323323
# subparser for upload
324324
upload_parser = subparsers.add_parser("upload", description=upload_description, parents=[core_root_parser, target_parser])
@@ -1629,7 +1629,7 @@ async def create_one_artifact(jit_path: str, location: str, flags) -> str:
16291629
summary_file_info = ( mch_file, md_summary_file )
16301630
all_md_summary_files.append(summary_file_info)
16311631
command = [ jit_analyze_path, "--md", md_summary_file, "-r", "--base", base_asm_location, "--diff", diff_asm_location ]
1632-
if self.coreclr_args.ci_run:
1632+
if self.coreclr_args.retainOnlyTopFiles:
16331633
command += [ "-retainOnlyTopFiles" ]
16341634
if self.coreclr_args.metrics:
16351635
command += [ "--metrics", ",".join(self.coreclr_args.metrics) ]
@@ -3265,9 +3265,9 @@ def verify_replay_common_args():
32653265
"Unable to set metrics.")
32663266

32673267
coreclr_args.verify(args,
3268-
"ci_run",
3268+
"retainOnlyTopFiles",
32693269
lambda unused: True,
3270-
"Unable to set ci_run.")
3270+
"Unable to set retainOnlyTopFiles.")
32713271

32723272
process_base_jit_path_arg(coreclr_args)
32733273

0 commit comments

Comments
 (0)