Disable tests that use a flaky FSW in Windows (#104988)

jozkee · web-flow · commit d5a20b908f79 · 2024-07-18T10:42:57.000-05:00
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs
@@ -78,6 +78,7 @@ public void FileSystemWatcher_Directory_Changed_SymLink()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Changed_SynchronizingObject()
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs
@@ -31,6 +31,7 @@ public void FileSystemWatcher_Directory_PathNotExists()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Create()
         {
             using (var watcher = new FileSystemWatcher(TestDirectory))
@@ -46,6 +47,7 @@ public void FileSystemWatcher_Directory_Create()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Create_InNestedDirectory()
         {
             string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
@@ -98,6 +100,7 @@ public void FileSystemWatcher_Directory_Create_SymLink()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Create_SynchronizingObject()
         {
             using (var watcher = new FileSystemWatcher(TestDirectory))
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs
@@ -64,6 +64,7 @@ public void FileSystemWatcher_Directory_Delete_DeepDirectoryStructure()
         }
 
         [ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateSymbolicLinks))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Delete_SymLink()
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs
@@ -77,6 +77,7 @@ public void Unix_Directory_Move_To_Different_Watched_Directory()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void Directory_Move_From_Unwatched_To_Watched()
         {
             DirectoryMove_FromUnwatchedToWatched(WatcherChangeTypes.Created);
@@ -85,6 +86,7 @@ public void Directory_Move_From_Unwatched_To_Watched()
         [Theory]
         [InlineData(false)]
         [InlineData(true)]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void Directory_Move_In_Nested_Directory(bool includeSubdirectories)
         {
             DirectoryMove_NestedDirectory(includeSubdirectories ? WatcherChangeTypes.Renamed : 0, includeSubdirectories);
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs
@@ -21,6 +21,7 @@ private static partial uint SetSecurityInfoByHandle( string name, uint objectTyp
 
         [Theory]
         [MemberData(nameof(FilterTypes))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_NotifyFilter_Attributes(NotifyFilters filter)
         {
             FileSystemWatcherTest.Execute(() =>
@@ -165,6 +166,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteTime_TwoFilters(No
         [Theory]
         [MemberData(nameof(FilterTypes))]
         [PlatformSpecific(TestPlatforms.Windows)]  // Uses P/Invokes to set security info
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_NotifyFilter_Security(NotifyFilters filter)
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
@@ -222,6 +224,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteAndFileName()
         /// after each other.
         /// </summary>
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_NotifyFilter_ModifyAndCreate()
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs
@@ -9,6 +9,7 @@ namespace System.IO.Tests
     public class File_Changed_Tests : FileSystemWatcherTest
     {
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_Changed_LastWrite()
         {
             string file = CreateTestFile(TestDirectory, "file");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs
@@ -85,6 +85,7 @@ public void FileSystemWatcher_File_Create_ForcedRestart()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_Create_InNestedDirectory()
         {
             string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs
@@ -11,6 +11,7 @@ namespace System.IO.Tests
     public class File_Delete_Tests : FileSystemWatcherTest
     {
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_Delete()
         {
             using (var watcher = new FileSystemWatcher(TestDirectory))
@@ -27,6 +28,7 @@ public void FileSystemWatcher_File_Delete()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_Delete_ForcedRestart()
         {
             using (var watcher = new FileSystemWatcher(TestDirectory))
@@ -47,6 +49,7 @@ public void FileSystemWatcher_File_Delete_ForcedRestart()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_Delete_InNestedDirectory()
         {
             string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs
@@ -12,6 +12,7 @@ public class File_Move_Tests : FileSystemWatcherTest
     {
         [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Expected WatcherChangeTypes are different based on OS
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void Windows_File_Move_To_Same_Directory()
         {
             FileMove_SameDirectory(WatcherChangeTypes.Renamed);
@@ -126,6 +127,7 @@ public void Unix_File_Move_With_Set_NotifyFilter()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void File_Move_SynchronizingObject()
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs
@@ -139,6 +139,7 @@ public void FileSystemWatcher_File_NotifyFilter_LastWriteTime(NotifyFilters filt
 
         [Theory]
         [MemberData(nameof(FilterTypes))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_NotifyFilter_Size(NotifyFilters filter)
         {
             string file = CreateTestFile(TestDirectory, "file");
@@ -193,6 +194,7 @@ public void FileSystemWatcher_File_NotifyFilter_Size_TwoFilters(NotifyFilters fi
         [Theory]
         [MemberData(nameof(FilterTypes))]
         [PlatformSpecific(TestPlatforms.Windows)]  // Uses P/Invokes to set security info
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_File_NotifyFilter_Security(NotifyFilters filter)
         {
             string file = CreateTestFile(TestDirectory, "file");
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs
@@ -74,6 +74,7 @@ public void FileSystemWatcher_InternalBufferSize(bool setToHigherCapacity)
         [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]
         [OuterLoop("A little slow")]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_InternalBufferSize_SynchronizingObject()
         {
             ManualResetEvent unblockHandler = new ManualResetEvent(false);
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs
@@ -58,6 +58,7 @@ public void FileSystemWatcher_DirectorySymbolicLink_TargetsSelf_Fails()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create()
         {
             // Arrange
diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs
@@ -258,6 +258,7 @@ public void FileSystemWatcher_IncludeSubdirectories()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_InternalBufferSize()
         {
             FileSystemWatcher watcher = new FileSystemWatcher();
@@ -567,6 +568,7 @@ public void FileSystemWatcher_StopCalledOnBackgroundThreadDoesNotDeadlock()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_WatchingAliasedFolderResolvesToRealPathWhenWatching()
         {
             string dir = CreateTestDirectory(TestDirectory, "dir");
@@ -1001,6 +1003,7 @@ public void FileSystemWatcher_Directory_Create_Filter_Ctor()
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]
         public void FileSystemWatcher_Directory_Delete_MultipleFilters()
         {
             using var tempDir = new TempDirectory();

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ public void FileSystemWatcher_Directory_Changed_SymLink()`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`[Fact]`
	`81`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`81`	`82`	`public void FileSystemWatcher_Directory_Changed_SynchronizingObject()`
`82`	`83`	`{`
`83`	`84`	`string dir = CreateTestDirectory(TestDirectory, "dir");`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public void FileSystemWatcher_Directory_PathNotExists()`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`[Fact]`
	`34`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`34`	`35`	`public void FileSystemWatcher_Directory_Create()`
`35`	`36`	`{`
`36`	`37`	`using (var watcher = new FileSystemWatcher(TestDirectory))`
`@@ -46,6 +47,7 @@ public void FileSystemWatcher_Directory_Create()`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`[Fact]`
	`50`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`49`	`51`	`public void FileSystemWatcher_Directory_Create_InNestedDirectory()`
`50`	`52`	`{`
`51`	`53`	`string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");`
`@@ -98,6 +100,7 @@ public void FileSystemWatcher_Directory_Create_SymLink()`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`[Fact]`
	`103`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`101`	`104`	`public void FileSystemWatcher_Directory_Create_SynchronizingObject()`
`102`	`105`	`{`
`103`	`106`	`using (var watcher = new FileSystemWatcher(TestDirectory))`
Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ public void FileSystemWatcher_Directory_Delete_DeepDirectoryStructure()`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`[ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateSymbolicLinks))]`
	`67`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`67`	`68`	`public void FileSystemWatcher_Directory_Delete_SymLink()`
`68`	`69`	`{`
`69`	`70`	`string dir = CreateTestDirectory(TestDirectory, "dir");`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@ public void Unix_Directory_Move_To_Different_Watched_Directory()`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`[Fact]`
	`80`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`80`	`81`	`public void Directory_Move_From_Unwatched_To_Watched()`
`81`	`82`	`{`
`82`	`83`	`DirectoryMove_FromUnwatchedToWatched(WatcherChangeTypes.Created);`
`@@ -85,6 +86,7 @@ public void Directory_Move_From_Unwatched_To_Watched()`
`85`	`86`	`[Theory]`
`86`	`87`	`[InlineData(false)]`
`87`	`88`	`[InlineData(true)]`
	`89`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`88`	`90`	`public void Directory_Move_In_Nested_Directory(bool includeSubdirectories)`
`89`	`91`	`{`
`90`	`92`	`DirectoryMove_NestedDirectory(includeSubdirectories ? WatcherChangeTypes.Renamed : 0, includeSubdirectories);`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ namespace System.IO.Tests`
`9`	`9`	`public class File_Changed_Tests : FileSystemWatcherTest`
`10`	`10`	`{`
`11`	`11`	`[Fact]`
	`12`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`12`	`13`	`public void FileSystemWatcher_File_Changed_LastWrite()`
`13`	`14`	`{`
`14`	`15`	`string file = CreateTestFile(TestDirectory, "file");`
Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ public void FileSystemWatcher_File_Create_ForcedRestart()`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`[Fact]`
	`88`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`88`	`89`	`public void FileSystemWatcher_File_Create_InNestedDirectory()`
`89`	`90`	`{`
`90`	`91`	`string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ namespace System.IO.Tests`
`11`	`11`	`public class File_Delete_Tests : FileSystemWatcherTest`
`12`	`12`	`{`
`13`	`13`	`[Fact]`
	`14`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`14`	`15`	`public void FileSystemWatcher_File_Delete()`
`15`	`16`	`{`
`16`	`17`	`using (var watcher = new FileSystemWatcher(TestDirectory))`
`@@ -27,6 +28,7 @@ public void FileSystemWatcher_File_Delete()`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`[Fact]`
	`31`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`30`	`32`	`public void FileSystemWatcher_File_Delete_ForcedRestart()`
`31`	`33`	`{`
`32`	`34`	`using (var watcher = new FileSystemWatcher(TestDirectory))`
`@@ -47,6 +49,7 @@ public void FileSystemWatcher_File_Delete_ForcedRestart()`
`47`	`49`	`}`
`48`	`50`
`49`	`51`	`[Fact]`
	`52`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`50`	`53`	`public void FileSystemWatcher_File_Delete_InNestedDirectory()`
`51`	`54`	`{`
`52`	`55`	`string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested");`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ public class File_Move_Tests : FileSystemWatcherTest`
`12`	`12`	`{`
`13`	`13`	`[Fact]`
`14`	`14`	`[PlatformSpecific(TestPlatforms.Windows)] // Expected WatcherChangeTypes are different based on OS`
	`15`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`15`	`16`	`public void Windows_File_Move_To_Same_Directory()`
`16`	`17`	`{`
`17`	`18`	`FileMove_SameDirectory(WatcherChangeTypes.Renamed);`
`@@ -126,6 +127,7 @@ public void Unix_File_Move_With_Set_NotifyFilter()`
`126`	`127`	`}`
`127`	`128`
`128`	`129`	`[Fact]`
	`130`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`129`	`131`	`public void File_Move_SynchronizingObject()`
`130`	`132`	`{`
`131`	`133`	`string dir = CreateTestDirectory(TestDirectory, "dir");`
Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,7 @@ public void FileSystemWatcher_File_NotifyFilter_LastWriteTime(NotifyFilters filt`
`139`	`139`
`140`	`140`	`[Theory]`
`141`	`141`	`[MemberData(nameof(FilterTypes))]`
	`142`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`142`	`143`	`public void FileSystemWatcher_File_NotifyFilter_Size(NotifyFilters filter)`
`143`	`144`	`{`
`144`	`145`	`string file = CreateTestFile(TestDirectory, "file");`
`@@ -193,6 +194,7 @@ public void FileSystemWatcher_File_NotifyFilter_Size_TwoFilters(NotifyFilters fi`
`193`	`194`	`[Theory]`
`194`	`195`	`[MemberData(nameof(FilterTypes))]`
`195`	`196`	`[PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info`
	`197`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`196`	`198`	`public void FileSystemWatcher_File_NotifyFilter_Security(NotifyFilters filter)`
`197`	`199`	`{`
`198`	`200`	`string file = CreateTestFile(TestDirectory, "file");`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ public void FileSystemWatcher_InternalBufferSize(bool setToHigherCapacity)`
`74`	`74`	`[Fact]`
`75`	`75`	`[PlatformSpecific(TestPlatforms.Windows)]`
`76`	`76`	`[OuterLoop("A little slow")]`
	`77`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)]`
`77`	`78`	`public void FileSystemWatcher_InternalBufferSize_SynchronizingObject()`
`78`	`79`	`{`
`79`	`80`	`ManualResetEvent unblockHandler = new ManualResetEvent(false);`