Fix FormatException message argument (#95356)

Author: tarekgh

src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs

@@ -1547,7 +1547,7 @@ private static void GetDefaultYear(ref DateTimeResult result, scoped ref DateTim
             result.flags |= ParseFlags.YearDefault;
         }
 
-        // Processing teriminal case: DS.DX_NN
+        // Processing terminal case: DS.DX_NN
         private static bool GetDayOfNN(ref DateTimeResult result, scoped ref DateTimeStyles styles, scoped ref DateTimeRawInfo raw, DateTimeFormatInfo dtfi)
         {
             if ((result.flags & ParseFlags.HaveDate) != 0)
@@ -1589,7 +1589,7 @@ private static bool GetDayOfNN(ref DateTimeResult result, scoped ref DateTimeSty
             return false;
         }
 
-        // Processing teriminal case: DS.DX_NNN
+        // Processing terminal case: DS.DX_NNN
         private static bool GetDayOfNNN(ref DateTimeResult result, scoped ref DateTimeRawInfo raw, DateTimeFormatInfo dtfi)
         {
             if ((result.flags & ParseFlags.HaveDate) != 0)
@@ -5183,7 +5183,7 @@ private static Exception GetDateTimeParseException(scoped ref DateTimeResult res
                 case ParseFailureKind.Format_BadDatePattern:
                     return new FormatException(SR.Format(SR.Format_BadDatePattern, result.failureMessageFormatArgument));
                 case ParseFailureKind.Format_BadDateTime:
-                    return new FormatException(SR.Format(SR.Format_BadDateTime, result.failureMessageFormatArgument));
+                    return new FormatException(SR.Format(SR.Format_BadDateTime, new string(result.originalDateTimeString)));
                 case ParseFailureKind.Format_BadDateTimeCalendar:
                     return new FormatException(SR.Format(SR.Format_BadDateTimeCalendar, new string(result.originalDateTimeString), result.calendar));
                 case ParseFailureKind.Format_BadDayOfWeek:
@@ -6124,7 +6124,6 @@ internal void SetBadFormatSpecifierFailure(ReadOnlySpan<char> failedFormatSpecif
         internal void SetBadDateTimeFailure()
         {
             this.failure = ParseFailureKind.Format_BadDateTime;
-            this.failureMessageFormatArgument = null;
         }
 
         internal void SetFailure(ParseFailureKind failure)

src/libraries/System.Runtime/tests/System/DateTimeTests.cs

@@ -114,7 +114,7 @@ public void Ctor_DateOnly_TimeOnly(int year, int month, int day, int hour, int m
             var date = new DateOnly(year, month, day);
             var time = new TimeOnly(hour, minute, second, millisecond);
             var dateTime = new DateTime(date, time);
-            
+
             Assert.Equal(new DateTime(year, month, day, hour, minute, second, millisecond), dateTime);
         }
 
@@ -125,7 +125,7 @@ public void Ctor_DateOnly_TimeOnly_DateTimeKind(int year, int month, int day, in
             var date = new DateOnly(year, month, day);
             var time = new TimeOnly(hour, minute, second, millisecond);
             var dateTime = new DateTime(date, time, DateTimeKind.Local);
-            
+
             Assert.Equal(new DateTime(year, month, day, hour, minute, second, millisecond, DateTimeKind.Local), dateTime);
         }
 
@@ -2984,5 +2984,12 @@ public void TestDateTimeCalculationPrecision(double value, DateTime initialValue
                 break;
             }
         }
+
+        [Fact]
+        public void TestBadFormatException()
+        {
+            FormatException ex = Assert.Throws<FormatException>(() => DateTime.ParseExact("11.2023", "dd.mm.yyyy", System.Globalization.CultureInfo.InvariantCulture));
+            Assert.Contains("11.2023", ex.Message, StringComparison.Ordinal);
+        }
     }
 }