Skip to content

Commit cf9ba51

Browse files
committed
Revert Add to int argument
Cast at call-site to prevent performance degradation.
1 parent 8941ca5 commit cf9ba51

File tree

1 file changed

+5
-5
lines changed
  • src/libraries/System.Private.CoreLib/src/System/Globalization

1 file changed

+5
-5
lines changed

src/libraries/System.Private.CoreLib/src/System/Globalization/Calendar.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ internal static void CheckAddResult(long ticks, DateTime minValue, DateTime maxV
127127
}
128128
}
129129

130-
internal DateTime Add(DateTime time, double value, long scale)
130+
internal DateTime Add(DateTime time, double value, int scale)
131131
{
132132
// From ECMA CLI spec, Partition III, section 3.27:
133133
//
@@ -169,7 +169,7 @@ public virtual DateTime AddMilliseconds(DateTime time, double milliseconds)
169169
/// </summary>
170170
public virtual DateTime AddDays(DateTime time, int days)
171171
{
172-
return Add(time, days, TimeSpan.MillisecondsPerDay);
172+
return Add(time, days, (int)TimeSpan.MillisecondsPerDay);
173173
}
174174

175175
/// <summary>
@@ -181,7 +181,7 @@ public virtual DateTime AddDays(DateTime time, int days)
181181
/// </summary>
182182
public virtual DateTime AddHours(DateTime time, int hours)
183183
{
184-
return Add(time, hours, TimeSpan.MillisecondsPerHour);
184+
return Add(time, hours, (int)TimeSpan.MillisecondsPerHour);
185185
}
186186

187187
/// <summary>
@@ -193,7 +193,7 @@ public virtual DateTime AddHours(DateTime time, int hours)
193193
/// </summary>
194194
public virtual DateTime AddMinutes(DateTime time, int minutes)
195195
{
196-
return Add(time, minutes, TimeSpan.MillisecondsPerMinute);
196+
return Add(time, minutes, (int)TimeSpan.MillisecondsPerMinute);
197197
}
198198

199199
/// <summary>
@@ -225,7 +225,7 @@ public virtual DateTime AddMinutes(DateTime time, int minutes)
225225
/// </summary>
226226
public virtual DateTime AddSeconds(DateTime time, int seconds)
227227
{
228-
return Add(time, seconds, TimeSpan.MillisecondsPerSecond);
228+
return Add(time, seconds, (int)TimeSpan.MillisecondsPerSecond);
229229
}
230230

231231
// Returns the DateTime resulting from adding a number of

0 commit comments

Comments
 (0)