Remove Uri length limits (#117287)

* Remove Uri length limits

* Update uri test

* Add HTTP test

* Lower uri length for browser http test

* Rename enum value name

---------

Co-authored-by: Miha Zupan <mizupan@microsoft.com>

Author: MihaZupan

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs

@@ -2342,5 +2342,36 @@ public enum HeaderType
             Content,
             Cookie
         }
+
+        [Fact]
+        public async Task LargeUriAndHeaders_Works()
+        {
+            int length =
+                IsWinHttpHandler ? 65_000 :
+                PlatformDetection.IsBrowser ? 4_000 :
+                10_000_000;
+
+            string longPath = "/" + new string('X', length);
+            string longHeaderName = new string('Y', length);
+            string longHeaderValue = new string('Z', length);
+
+            await LoopbackServerFactory.CreateClientAndServerAsync(
+                async uri =>
+                {
+                    using HttpClient client = CreateHttpClient();
+
+                    HttpRequestMessage request = CreateRequest(HttpMethod.Get, new UriBuilder(uri) { Path = longPath }.Uri, UseVersion);
+                    request.Headers.Add(longHeaderName, longHeaderValue);
+
+                    await client.SendAsync(request);
+                },
+                async server =>
+                {
+                    HttpRequestData requestData = await server.HandleRequestAsync();
+
+                    Assert.Equal(longPath, requestData.Path);
+                    Assert.Equal(longHeaderValue, requestData.GetSingleHeaderValue(longHeaderName));
+                });
+        }
     }
 }

src/libraries/Common/tests/System/Net/Http/QPackTestDecoder.cs

@@ -92,15 +92,15 @@ public static (int bytesConsumed, int value) DecodeInteger(ReadOnlySpan<byte> he
 
             ulong extra = 0;
             int length = 1;
-            ulong b;
+            byte b;
 
             do
             {
                 // https://http2.github.io/http2-spec/compression.html#integer.representation
                 // HPack encodes integers from the least significant byte to the most.
                 // Every 7-bits of the next byte is shifted by (7 * index) and added to the result.
-                b = (ulong)headerBlock[length++];
-                extra = checked(b << (7 * (length - 2))) | extra;
+                b = headerBlock[length++];
+                extra = checked((ulong)(b & 0x7F) << (7 * (length - 2))) | extra;
             }
             while ((b & 0b10000000) != 0);
 

src/libraries/System.Private.Uri/src/Resources/Strings.resx

@@ -168,9 +168,6 @@
   <data name="net_uri_PortOutOfRange" xml:space="preserve">
     <value>A derived type '{0}' has reported an invalid value for the Uri port '{1}'.</value>
   </data>
-  <data name="net_uri_SizeLimit" xml:space="preserve">
-    <value>Invalid URI: The Uri string is too long.</value>
-  </data>
   <data name="net_uri_UserDrivenParsing" xml:space="preserve">
     <value>A derived type '{0}' is responsible for parsing this Uri instance. The base implementation must not be used.</value>
   </data>

src/libraries/System.Private.Uri/src/System/IriHelper.cs

@@ -88,6 +88,8 @@ internal static bool CheckIsReserved(char ch, UriComponents component)
         //
         internal static unsafe string EscapeUnescapeIri(char* pInput, int start, int end, UriComponents component)
         {
+            Debug.Assert(end >= 0 && start >= 0 && start <= end);
+
             int size = end - start;
             var dest = size <= Uri.StackallocThreshold
                 ? new ValueStringBuilder(stackalloc char[Uri.StackallocThreshold])