Consumers affected by void returns

Work in progress...

Author: gwr

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.SunOS.cs

@@ -126,10 +126,7 @@ private Interop.procfs.ProcessInfo GetProcInfo()
         {
             EnsureState(State.HaveNonExitedId);
             Interop.procfs.ProcessInfo processInfo;
-            if (!Interop.procfs.GetProcessInfoById(_processId, out processInfo))
-            {
-                throw new Win32Exception(SR.ProcessInformationUnavailable);
-            }
+            Interop.procfs.GetProcessInfoById(_processId, out processInfo))
             return processInfo;
         }
     }

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.SunOS.cs

@@ -57,16 +57,14 @@ internal static ProcessModuleCollection GetModules(int processId)
 
             string argString;
             Interop.procfs.ProcessInfo processInfo;
-            if (Interop.procfs.GetProcessInfoById(processId, out processInfo, out argString))
+            Interop.procfs.GetProcessInfoById(processId, out processInfo, out argString)
+            string? fullName = Process.GetUntruncatedProcessName(ref processInfo, ref argString);
+            if (!string.IsNullOrEmpty(fullName))
             {
-                string? fullName = Process.GetUntruncatedProcessName(ref processInfo, ref argString);
-                if (!string.IsNullOrEmpty(fullName))
+                return new ProcessModuleCollection(1)
                 {
-                    return new ProcessModuleCollection(1)
-                    {
-                        new ProcessModule(fullName, Path.GetFileName(fullName))
-                    };
-                }
+                    new ProcessModule(fullName, Path.GetFileName(fullName))
+                };
             }
             return new ProcessModuleCollection(0);
         }
@@ -81,11 +79,7 @@ internal static ProcessModuleCollection GetModules(int processId)
 
             Interop.procfs.ProcessInfo processInfo;
             string argString;
-            if (!Interop.procfs.GetProcessInfoById(pid, out processInfo, out argString))
-            {
-                return null;
-            }
-
+            Interop.procfs.GetProcessInfoById(pid, out processInfo, out argString)
             string? processName = Process.GetUntruncatedProcessName(ref processInfo, ref argString);
             if (!string.IsNullOrEmpty(processNameFilter) &&
                 !string.Equals(processName, processNameFilter, StringComparison.OrdinalIgnoreCase))
@@ -176,7 +170,11 @@ internal static ProcessInfo CreateProcessInfo(ref Interop.procfs.ProcessInfo pro
                     Interop.procfs.ThreadInfo threadInfo;
                     ThreadInfo? ti;
 
-                    if (!Interop.procfs.GetThreadInfoById(pid, tid, out threadInfo))
+                    try
+                    {
+                        Interop.procfs.GetThreadInfoById(pid, tid, out threadInfo))
+                    }
+                    catch (Exception ex)
                     {
                         continue;
                     }

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessThread.SunOS.cs

@@ -121,10 +121,7 @@ private static System.Diagnostics.ThreadPriorityLevel GetThreadPriorityFromSysPr
         private Interop.procfs.ThreadInfo GetThreadInfo()
         {
             Interop.procfs.ThreadInfo threadInfo;
-            if (!Interop.procfs.GetThreadInfoById(_processId, tid: Id, out threadInfo))
-            {
-                throw new InvalidOperationException(SR.Format(SR.ThreadExited, Id));
-            }
+            Interop.procfs.GetThreadInfoById(_processId, tid: Id, out threadInfo)
             return threadInfo;
         }
     }

src/libraries/System.Private.CoreLib/src/System/Environment.SunOS.cs

@@ -7,6 +7,7 @@ namespace System
 {
     public static partial class Environment
     {
+        // XXX the void returns complicate this. FIX ME
         public static long WorkingSet => (long)(Interop.procfs.GetProcessInfoById(ProcessId, out Interop.procfs.ProcessInfo iProcInfo) ? iProcInfo.ResidentSetSize : 0);
     }
 }