Skip to content

Commit c9a985d

Browse files
authored
enable two HTTP POST tests (#94115)
1 parent c1f4341 commit c9a985d

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -671,14 +671,6 @@ public async Task PostAsync_Redirect_ResultingGetFormattedCorrectly(Configuratio
671671
[Theory, MemberData(nameof(RemoteServersMemberData))]
672672
public async Task PostAsync_RedirectWith307_LargePayload(Configuration.Http.RemoteServer remoteServer)
673673
{
674-
if (remoteServer.HttpVersion == new Version(2, 0))
675-
{
676-
// This is occasionally timing out in CI with SocketsHttpHandler and HTTP2, particularly on Linux
677-
// Likely this is just a very slow test and not a product issue, so just increasing the timeout may be the right fix.
678-
// Disable until we can investigate further.
679-
return;
680-
}
681-
682674
await PostAsync_Redirect_LargePayload_Helper(remoteServer, 307, true);
683675
}
684676

@@ -722,7 +714,9 @@ private async Task PostAsync_Redirect_LargePayload_Helper(Configuration.Http.Rem
722714
content.Headers.ContentMD5 = TestHelper.ComputeMD5Hash(contentBytes);
723715
}
724716

725-
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
717+
using HttpClient client = CreateHttpClientForRemoteServer(remoteServer);
718+
client.Timeout = TimeSpan.FromMinutes(10);
719+
726720
using (HttpResponseMessage response = await client.PostAsync(redirectUri, content))
727721
{
728722
try

src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,9 @@ public async Task PostLargeContentUsingContentLengthSemantics_Success(Configurat
165165
[Theory, MemberData(nameof(RemoteServersMemberData))]
166166
public async Task PostRewindableContentUsingAuth_NoPreAuthenticate_Success(Configuration.Http.RemoteServer remoteServer)
167167
{
168-
if (remoteServer.HttpVersion == new Version(2, 0))
168+
// Sync API supported only up to HTTP/1.1
169+
if (!TestAsync && remoteServer.HttpVersion.Major >= 2)
169170
{
170-
// This is occasionally timing out in CI with SocketsHttpHandler and HTTP2, particularly on Linux
171-
// Likely this is just a very slow test and not a product issue, so just increasing the timeout may be the right fix.
172-
// Disable until we can investigate further.
173171
return;
174172
}
175173

0 commit comments

Comments
 (0)