review feedback

Author: kunalspathak

eng/pipelines/common/download-specific-artifact-step.yml

@@ -11,10 +11,10 @@ steps:
     displayName: 'Download specific ${{ parameters.displayName }}'
     inputs:
       buildType: specific
-      project:  'internal'
+      project:  'internal' # 'internal' or 'public'
       pipeline: 'superpmi-replay'
       buildVersionToDownload: specific
-      branchName: 'kpathak/spmi-replay'
+      branchName: 'your/branch/having/artifacts'
       buildId: '1274841'
       downloadType: single
       downloadPath: '$(Build.SourcesDirectory)/__download__'

eng/pipelines/coreclr/superpmi-replay.yml

@@ -22,7 +22,7 @@ jobs:
     - windows_x64
     - windows_x86
     jobParameters:
-      uploadAsArtifacts: true
+      uploadAs: 'pipelineArtifacts'
 
 - template: /eng/pipelines/common/platform-matrix.yml
   parameters:

eng/pipelines/coreclr/templates/build-jit-job.yml

@@ -11,7 +11,7 @@ parameters:
   timeoutInMinutes: ''
   variables: {}
   dependOnEvaluatePaths: false
-  uploadAsArtifacts: false
+  uploadAs: 'azureBlob'
 
 ### Product build
 jobs:
@@ -50,8 +50,8 @@ jobs:
 
     - name: publishLogsArtifactPrefix
       value: 'BuildLogs_CoreCLR_JIT'
-    - name: uploadAsArtifacts
-      value: ${{ parameters.uploadAsArtifacts }}
+    - name: uploadAs
+      value: ${{ parameters.uploadAs }}
 
     - name: compilerArg
       value: ''
@@ -109,7 +109,7 @@ jobs:
       - script: set __TestIntermediateDir=int&&$(Build.SourcesDirectory)/src/coreclr/build-runtime$(scriptExt) $(buildConfig) $(archType) -ci -nopgooptimize -skiprestoreoptdata -component alljits
         displayName: Build CoreCLR JIT
 
-    - ${{ if eq(parameters.uploadAsArtifacts, false) }}:
+    - ${{ if eq(parameters.uploadAs, 'azureBlob') }}:
       # Ensure the Python azure-storage-blob package is installed before doing the upload.
       - script: $(PipScript) install --user --upgrade pip && $(PipScript) install --user azure.storage.blob==12.5.0 --force-reinstall
         displayName: Upgrade Pip to latest and install azure-storage-blob Python package
@@ -119,7 +119,7 @@ jobs:
         env:
           CLRJIT_AZ_KEY: $(clrjit_key1) # secret key stored as variable in pipeline
 
-    - ${{ if eq(parameters.uploadAsArtifacts, true) }}:
+    - ${{ if eq(parameters.uploadAs, 'pipelineArtifacts') }}:
       # Publish product output directory for consumption by tests.
       - template: /eng/pipelines/common/upload-artifact-step.yml
         parameters:

eng/pipelines/coreclr/templates/run-superpmi-job.yml

@@ -18,7 +18,6 @@ parameters:
   liveLibrariesBuildConfig: ''    # optional -- live-live libraries configuration to use for the run
   runtimeType: 'coreclr'          # optional -- Sets the runtime as coreclr or mono
   codeGenType: 'JIT'              # optional -- Decides on the codegen technology if running on mono
-  projectFile: 'superpmi.proj'    # optional -- project file to build helix workitems
   runKind: ''                     # required -- test category
   collectionType: ''
   collectionName: ''

eng/pipelines/coreclr/templates/run-superpmi-replay-job.yml

@@ -18,7 +18,6 @@ parameters:
   liveLibrariesBuildConfig: ''    # optional -- live-live libraries configuration to use for the run
   runtimeType: 'coreclr'          # optional -- Sets the runtime as coreclr or mono
   codeGenType: 'JIT'              # optional -- Decides on the codegen technology if running on mono
-  projectFile: 'superpmi.proj'    # optional -- project file to build helix workitems
   runKind: ''                     # required -- test category
   collectionType: ''
   collectionName: ''

eng/pipelines/coreclr/templates/superpmi-job.yml

@@ -39,7 +39,6 @@ jobs:
     liveLibrariesBuildConfig: ${{ parameters.liveLibrariesBuildConfig }}
     runtimeType: ${{ parameters.runtimeType }}
     codeGenType: ${{ parameters.codeGenType }}
-    projectFile: ${{ parameters.projectFile }}
     runKind: ${{ parameters.runKind }}
     testGroup: ${{ parameters.testGroup }}
     collectionType: ${{ parameters.collectionType }}