Update dependencies from dotnet/roslyn-analyzers, config new analyzers (#99343)

buyaa-n · web-flow · commit c6906ae60861 · 2024-03-07T13:48:04.000-08:00
* Reapply "[main] Update dependencies from dotnet/roslyn-analyzers (#98984)" (#99327) * Configure new analyzers severity in src and test projects * Fix some of CA2263 warnings
diff --git a/eng/CodeAnalysis.src.globalconfig b/eng/CodeAnalysis.src.globalconfig
@@ -274,6 +274,12 @@ dotnet_diagnostic.CA1512.severity = warning
 # CA1513: Use ObjectDisposedException throw helper
 dotnet_diagnostic.CA1513.severity = warning
 
+# CA1514: Avoid redundant length argument
+dotnet_diagnostic.CA1514.severity = warning
+
+# CA1515: Consider making public types internal
+dotnet_diagnostic.CA1515.severity = none
+
 # CA1700: Do not name enum values 'Reserved'
 dotnet_diagnostic.CA1700.severity = none
 
@@ -492,6 +498,9 @@ dotnet_diagnostic.CA1869.severity = warning
 # CA1870: Use a cached 'SearchValues' instance
 dotnet_diagnostic.CA1870.severity = warning
 
+# CA1871: Do not pass a nullable struct to 'ArgumentNullException.ThrowIfNull'
+dotnet_diagnostic.CA1871.severity = warning
+
 # CA2000: Dispose objects before losing scope
 dotnet_diagnostic.CA2000.severity = none
 
@@ -679,6 +688,18 @@ dotnet_diagnostic.CA2260.severity = warning
 # CA2261: Do not use ConfigureAwaitOptions.SuppressThrowing with Task<TResult>
 dotnet_diagnostic.CA2261.severity = warning
 
+# CA2262: Set 'MaxResponseHeadersLength' properly
+dotnet_diagnostic.CA2262.severity = warning
+
+# CA2263: Prefer generic overload when type is known
+dotnet_diagnostic.CA2263.severity = info
+
+# CA2264: Do not pass a non-nullable value to 'ArgumentNullException.ThrowIfNull'
+dotnet_diagnostic.CA2264.severity = warning
+
+# CA2265: Do not compare Span<T> to 'null' or 'default'
+dotnet_diagnostic.CA2265.severity = warning
+
 # CA2300: Do not use insecure deserializer BinaryFormatter
 dotnet_diagnostic.CA2300.severity = none
 
diff --git a/eng/CodeAnalysis.test.globalconfig b/eng/CodeAnalysis.test.globalconfig
@@ -273,6 +273,12 @@ dotnet_diagnostic.CA1512.severity = none
 # CA1513: Use ObjectDisposedException throw helper
 dotnet_diagnostic.CA1513.severity = none
 
+# CA1514: Avoid redundant length argument
+dotnet_diagnostic.CA1514.severity = none
+
+# CA1515: Consider making public types internal
+dotnet_diagnostic.CA1515.severity = none
+
 # CA1700: Do not name enum values 'Reserved'
 dotnet_diagnostic.CA1700.severity = none
 
@@ -489,6 +495,9 @@ dotnet_diagnostic.CA1869.severity = none
 # CA1870: Use a cached 'SearchValues' instance
 dotnet_diagnostic.CA1870.severity = none
 
+# CA1871: Do not pass a nullable struct to 'ArgumentNullException.ThrowIfNull'
+dotnet_diagnostic.CA1871.severity = none
+
 # CA2000: Dispose objects before losing scope
 dotnet_diagnostic.CA2000.severity = none
 
@@ -675,6 +684,18 @@ dotnet_diagnostic.CA2260.severity = none
 # CA2261: Do not use ConfigureAwaitOptions.SuppressThrowing with Task<TResult>
 dotnet_diagnostic.CA2261.severity = none
 
+# CA2262: Set 'MaxResponseHeadersLength' properly
+dotnet_diagnostic.CA2262.severity = none
+
+# CA2263: Prefer generic overload when type is known
+dotnet_diagnostic.CA2263.severity = none
+
+# CA2264: Do not pass a non-nullable value to 'ArgumentNullException.ThrowIfNull'
+dotnet_diagnostic.CA2264.severity = none
+
+# CA2265: Do not compare Span<T> to 'null' or 'default'
+dotnet_diagnostic.CA2265.severity = none
+
 # CA2300: Do not use insecure deserializer BinaryFormatter
 dotnet_diagnostic.CA2300.severity = none
 
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
@@ -404,13 +404,13 @@
       <Uri>https://github.com/dotnet/roslyn</Uri>
       <Sha>77372c66fd54927312b5b0a2e399e192f74445c9</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.24122.2">
+    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.24155.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>ba8b7f2c3ae092d0301f0c5e49bd30340af553c8</Sha>
+      <Sha>628d239421a3ae54464c60901fd9b831b3f01efa</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0-preview.24122.2">
+    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0-preview.24155.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>ba8b7f2c3ae092d0301f0c5e49bd30340af553c8</Sha>
+      <Sha>628d239421a3ae54464c60901fd9b831b3f01efa</Sha>
     </Dependency>
     <!-- Intermediate is necessary for source build. -->
     <Dependency Name="Microsoft.SourceBuild.Intermediate.roslyn" Version="4.10.0-2.24114.13">
diff --git a/eng/Versions.props b/eng/Versions.props
@@ -34,8 +34,8 @@
   </ItemGroup>
   <PropertyGroup>
     <!-- dotnet/roslyn-analyzers dependencies -->
-    <MicrosoftCodeAnalysisAnalyzersVersion>3.11.0-beta1.24122.2</MicrosoftCodeAnalysisAnalyzersVersion>
-    <MicrosoftCodeAnalysisNetAnalyzersVersion>9.0.0-preview.24122.2</MicrosoftCodeAnalysisNetAnalyzersVersion>
+    <MicrosoftCodeAnalysisAnalyzersVersion>3.11.0-beta1.24155.1</MicrosoftCodeAnalysisAnalyzersVersion>
+    <MicrosoftCodeAnalysisNetAnalyzersVersion>9.0.0-preview.24155.1</MicrosoftCodeAnalysisNetAnalyzersVersion>
     <!-- dotnet/roslyn dependencies -->
     <!--
       These versions should not be used by any project that contributes to the design-time experience in VS, such as an analyzer, code-fix, or generator assembly.
diff --git a/src/coreclr/tools/Common/Compiler/InstructionSetSupport.cs b/src/coreclr/tools/Common/Compiler/InstructionSetSupport.cs
@@ -175,7 +175,7 @@ public class InstructionSetSupportBuilder
         private static Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>> ComputeInstructionSetSupport()
         {
             var supportMatrix = new Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>>();
-            foreach (TargetArchitecture arch in Enum.GetValues(typeof(TargetArchitecture)))
+            foreach (TargetArchitecture arch in Enum.GetValues<TargetArchitecture>())
             {
                 supportMatrix[arch] = ComputeInstructSetSupportForArch(arch);
             }
@@ -186,7 +186,7 @@ private static Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>
         private static Dictionary<TargetArchitecture, InstructionSetFlags> ComputeNonSpecifiableInstructionSetSupport()
         {
             var matrix = new Dictionary<TargetArchitecture, InstructionSetFlags>();
-            foreach (TargetArchitecture arch in Enum.GetValues(typeof(TargetArchitecture)))
+            foreach (TargetArchitecture arch in Enum.GetValues<TargetArchitecture>())
             {
                 matrix[arch] = ComputeNonSpecifiableInstructionSetSupportForArch(arch);
             }
diff --git a/src/coreclr/tools/aot/ILCompiler.MetadataTransform/Internal/Metadata/NativeFormat/Writer/NativeMetadataWriter.cs b/src/coreclr/tools/aot/ILCompiler.MetadataTransform/Internal/Metadata/NativeFormat/Writer/NativeMetadataWriter.cs
@@ -875,7 +875,7 @@ public partial class MethodSemantics
     {
         public override string ToString()
         {
-            string str = Enum.GetName(typeof(MethodSemanticsAttributes), Attributes);
+            string str = Enum.GetName(Attributes);
             return str + " : " + Method.ToString();
         }
     }
@@ -903,7 +903,7 @@ public partial class PropertySignature
     {
         public override string ToString()
         {
-            return string.Join(" ", Enum.GetName(typeof(CallingConventions), CallingConvention),
+            return string.Join(" ", Enum.GetName(CallingConvention),
                 Type.ToString()) + "(" + ToString(Parameters) + ")";
         }
     }
diff --git a/src/libraries/Common/src/System/Resources/ResourceWriter.cs b/src/libraries/Common/src/System/Resources/ResourceWriter.cs
@@ -488,7 +488,11 @@ private static ResourceTypeCode FindTypeCode(object? value, List<string> types)
                 if (typeName.StartsWith("ResourceTypeCode.", StringComparison.Ordinal))
                 {
                     typeName = typeName.Substring(17);  // Remove through '.'
+#if NETCOREAPP
+                    ResourceTypeCode typeCode = Enum.Parse<ResourceTypeCode>(typeName);
+#else
                     ResourceTypeCode typeCode = (ResourceTypeCode)Enum.Parse(typeof(ResourceTypeCode), typeName);
+#endif
                     return typeCode;
                 }
             }
diff --git a/src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/Schema/DatabaseGeneratedAttribute.cs b/src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/Schema/DatabaseGeneratedAttribute.cs
@@ -15,7 +15,7 @@ public class DatabaseGeneratedAttribute : Attribute
         /// <param name="databaseGeneratedOption">The pattern used to generate values for the property in the database.</param>
         public DatabaseGeneratedAttribute(DatabaseGeneratedOption databaseGeneratedOption)
         {
-            if (!(Enum.IsDefined(typeof(DatabaseGeneratedOption), databaseGeneratedOption)))
+            if (!Enum.IsDefined(databaseGeneratedOption))
             {
                 throw new ArgumentOutOfRangeException(nameof(databaseGeneratedOption));
             }
diff --git a/src/libraries/System.Configuration.ConfigurationManager/src/System/Diagnostics/TraceConfiguration.cs b/src/libraries/System.Configuration.ConfigurationManager/src/System/Diagnostics/TraceConfiguration.cs
@@ -55,7 +55,7 @@ private static void InitializingTraceSource(object sender, InitializingTraceSour
 
                             if (!string.IsNullOrEmpty(sourceElement.SwitchValue))
                             {
-                                traceSource.Switch.Level = (SourceLevels)Enum.Parse(typeof(SourceLevels), sourceElement.SwitchValue);
+                                traceSource.Switch.Level = Enum.Parse<SourceLevels>(sourceElement.SwitchValue);
                             }
                         }
                     }
@@ -74,7 +74,7 @@ private static void InitializingTraceSource(object sender, InitializingTraceSour
                         // The SwitchValue changed; just update our internalSwitch.
                         if (!string.IsNullOrEmpty(sourceElement.SwitchValue))
                         {
-                            traceSource.Switch.Level = (SourceLevels)Enum.Parse(typeof(SourceLevels), sourceElement.SwitchValue);
+                            traceSource.Switch.Level = Enum.Parse<SourceLevels>(sourceElement.SwitchValue);
                         }
                         else
                         {
diff --git a/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventData.cs b/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventData.cs
@@ -39,7 +39,7 @@ public EventLogEntryType EntryType
             get => _entryType;
             set
             {
-                if (!Enum.IsDefined(typeof(EventLogEntryType), value))
+                if (!Enum.IsDefined(value))
                     throw new InvalidEnumArgumentException(nameof(EntryType), (int)value, typeof(EventLogEntryType));
 
                 _entryType = value;
diff --git a/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventLogInternal.cs b/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventLogInternal.cs
@@ -1292,7 +1292,7 @@ public void WriteEntry(string message, EventLogEntryType type, int eventID, shor
             if (Source.Length == 0)
                 throw new ArgumentException(SR.NeedSourceToWrite);
 
-            if (!Enum.IsDefined(typeof(EventLogEntryType), type))
+            if (!Enum.IsDefined(type))
                 throw new InvalidEnumArgumentException(nameof(type), (int)type, typeof(EventLogEntryType));
 
             string currentMachineName = machineName;
diff --git a/src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/CounterCreationData.cs b/src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/CounterCreationData.cs
@@ -33,7 +33,7 @@ public PerformanceCounterType CounterType
             }
             set
             {
-                if (!Enum.IsDefined(typeof(PerformanceCounterType), value))
+                if (!Enum.IsDefined(value))
                     throw new InvalidEnumArgumentException(nameof(PerformanceCounterType), (int)value, typeof(PerformanceCounterType));
 
                 _counterType = value;
diff --git a/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs b/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
@@ -5498,7 +5498,7 @@ private string CreateManifestString()
                     if (channelInfo.Attribs != null)
                     {
                         EventChannelAttribute attribs = channelInfo.Attribs;
-                        if (Enum.IsDefined(typeof(EventChannelType), attribs.EventChannelType))
+                        if (Enum.IsDefined(attribs.EventChannelType))
                             channelType = attribs.EventChannelType.ToString();
                         enabled = attribs.Enabled;
                     }
diff --git a/src/libraries/System.Private.Xml/src/System/Xml/Xsl/QIL/QilXmlWriter.cs b/src/libraries/System.Private.Xml/src/System/Xml/Xsl/QIL/QilXmlWriter.cs
@@ -206,7 +206,7 @@ protected override QilNode VisitQilExpression(QilExpression qil)
                 foreach (QilNode n in fdecls)
                 {
                     // i.e. <Function id="$a"/>
-                    this.writer.WriteStartElement(Enum.GetName(typeof(QilNodeType), n.NodeType)!);
+                    this.writer.WriteStartElement(Enum.GetName(n.NodeType)!);
                     this.writer.WriteAttributeString("id", _ngen.NameOf(n));
                     WriteXmlType(n);
 
@@ -277,7 +277,7 @@ protected override void BeforeVisit(QilNode node)
                 WriteAnnotations(node.Annotation);
 
             // Call WriteStartElement
-            this.writer.WriteStartElement("", Enum.GetName(typeof(QilNodeType), node.NodeType)!, "");
+            this.writer.WriteStartElement("", Enum.GetName(node.NodeType)!, "");
 
             // Write common attributes
 #if QIL_TRACE_NODE_CREATION
diff --git a/src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexWriter.cs b/src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexWriter.cs
@@ -28,8 +28,8 @@ internal ref struct RegexWriter
 #if DEBUG
         static RegexWriter()
         {
-            Debug.Assert(!Enum.IsDefined(typeof(RegexNodeKind), BeforeChild));
-            Debug.Assert(!Enum.IsDefined(typeof(RegexNodeKind), AfterChild));
+            Debug.Assert(!Enum.IsDefined(BeforeChild));
+            Debug.Assert(!Enum.IsDefined(AfterChild));
         }
 #endif
 
diff --git a/src/tasks/Common/FileCache.cs b/src/tasks/Common/FileCache.cs
@@ -33,9 +33,7 @@ public FileCache(string? cacheFilePath, TaskLoggingHelper log)
         Enabled = true;
         if (File.Exists(cacheFilePath))
         {
-            _oldCache = (CompilerCache?)JsonSerializer.Deserialize(File.ReadAllText(cacheFilePath),
-                                                                    typeof(CompilerCache),
-                                                                    s_jsonOptions);
+            _oldCache = JsonSerializer.Deserialize<CompilerCache>(File.ReadAllText(cacheFilePath), s_jsonOptions);
         }
 
         _oldCache ??= new();

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ public class InstructionSetSupportBuilder`
`175`	`175`	`private static Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>> ComputeInstructionSetSupport()`
`176`	`176`	`{`
`177`	`177`	`var supportMatrix = new Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>>();`
`178`		`- foreach (TargetArchitecture arch in Enum.GetValues(typeof(TargetArchitecture)))`
	`178`	`+ foreach (TargetArchitecture arch in Enum.GetValues<TargetArchitecture>())`
`179`	`179`	`{`
`180`	`180`	`supportMatrix[arch] = ComputeInstructSetSupportForArch(arch);`
`181`	`181`	`}`
`@@ -186,7 +186,7 @@ private static Dictionary<TargetArchitecture, Dictionary<string, InstructionSet>`
`186`	`186`	`private static Dictionary<TargetArchitecture, InstructionSetFlags> ComputeNonSpecifiableInstructionSetSupport()`
`187`	`187`	`{`
`188`	`188`	`var matrix = new Dictionary<TargetArchitecture, InstructionSetFlags>();`
`189`		`- foreach (TargetArchitecture arch in Enum.GetValues(typeof(TargetArchitecture)))`
	`189`	`+ foreach (TargetArchitecture arch in Enum.GetValues<TargetArchitecture>())`
`190`	`190`	`{`
`191`	`191`	`matrix[arch] = ComputeNonSpecifiableInstructionSetSupportForArch(arch);`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,7 @@ public partial class MethodSemantics`
`875`	`875`	`{`
`876`	`876`	`public override string ToString()`
`877`	`877`	`{`
`878`		`- string str = Enum.GetName(typeof(MethodSemanticsAttributes), Attributes);`
	`878`	`+ string str = Enum.GetName(Attributes);`
`879`	`879`	`return str + " : " + Method.ToString();`
`880`	`880`	`}`
`881`	`881`	`}`
`@@ -903,7 +903,7 @@ public partial class PropertySignature`
`903`	`903`	`{`
`904`	`904`	`public override string ToString()`
`905`	`905`	`{`
`906`		`- return string.Join(" ", Enum.GetName(typeof(CallingConventions), CallingConvention),`
	`906`	`+ return string.Join(" ", Enum.GetName(CallingConvention),`
`907`	`907`	`Type.ToString()) + "(" + ToString(Parameters) + ")";`
`908`	`908`	`}`
`909`	`909`	`}`
Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,11 @@ private static ResourceTypeCode FindTypeCode(object? value, List<string> types)`
`488`	`488`	`if (typeName.StartsWith("ResourceTypeCode.", StringComparison.Ordinal))`
`489`	`489`	`{`
`490`	`490`	`typeName = typeName.Substring(17); // Remove through '.'`
	`491`	`+#if NETCOREAPP`
	`492`	`+ ResourceTypeCode typeCode = Enum.Parse<ResourceTypeCode>(typeName);`
	`493`	`+#else`
`491`	`494`	`ResourceTypeCode typeCode = (ResourceTypeCode)Enum.Parse(typeof(ResourceTypeCode), typeName);`
	`495`	`+#endif`
`492`	`496`	`return typeCode;`
`493`	`497`	`}`
`494`	`498`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public class DatabaseGeneratedAttribute : Attribute`
`15`	`15`	`/// <param name="databaseGeneratedOption">The pattern used to generate values for the property in the database.</param>`
`16`	`16`	`public DatabaseGeneratedAttribute(DatabaseGeneratedOption databaseGeneratedOption)`
`17`	`17`	`{`
`18`		`- if (!(Enum.IsDefined(typeof(DatabaseGeneratedOption), databaseGeneratedOption)))`
	`18`	`+ if (!Enum.IsDefined(databaseGeneratedOption))`
`19`	`19`	`{`
`20`	`20`	`throw new ArgumentOutOfRangeException(nameof(databaseGeneratedOption));`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ private static void InitializingTraceSource(object sender, InitializingTraceSour`
`55`	`55`
`56`	`56`	`if (!string.IsNullOrEmpty(sourceElement.SwitchValue))`
`57`	`57`	`{`
`58`		`- traceSource.Switch.Level = (SourceLevels)Enum.Parse(typeof(SourceLevels), sourceElement.SwitchValue);`
	`58`	`+ traceSource.Switch.Level = Enum.Parse<SourceLevels>(sourceElement.SwitchValue);`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`	`}`
`@@ -74,7 +74,7 @@ private static void InitializingTraceSource(object sender, InitializingTraceSour`
`74`	`74`	`// The SwitchValue changed; just update our internalSwitch.`
`75`	`75`	`if (!string.IsNullOrEmpty(sourceElement.SwitchValue))`
`76`	`76`	`{`
`77`		`- traceSource.Switch.Level = (SourceLevels)Enum.Parse(typeof(SourceLevels), sourceElement.SwitchValue);`
	`77`	`+ traceSource.Switch.Level = Enum.Parse<SourceLevels>(sourceElement.SwitchValue);`
`78`	`78`	`}`
`79`	`79`	`else`
`80`	`80`	`{`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public EventLogEntryType EntryType`
`39`	`39`	`get => _entryType;`
`40`	`40`	`set`
`41`	`41`	`{`
`42`		`- if (!Enum.IsDefined(typeof(EventLogEntryType), value))`
	`42`	`+ if (!Enum.IsDefined(value))`
`43`	`43`	`throw new InvalidEnumArgumentException(nameof(EntryType), (int)value, typeof(EventLogEntryType));`
`44`	`44`
`45`	`45`	`_entryType = value;`