Enabling 9 new libraries tests for NativeAOT (#72167)

Author: MichalStrehovsky

src/coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/Augments/RuntimeAugments.cs

@@ -86,6 +86,8 @@ public static object NewObject(RuntimeTypeHandle typeHandle)
                 || eeType == EETypePtr.EETypePtrOf<string>()
                )
                 return null;
+            if (eeType.IsByRefLike)
+                throw new System.Reflection.TargetException();
             return RuntimeImports.RhNewObject(eeType);
         }
 

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

@@ -152,6 +152,8 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly()
         public static bool IsAssemblyLoadingSupported => !IsNativeAot;
         public static bool IsMethodBodySupported => !IsNativeAot;
         public static bool IsDebuggerTypeProxyAttributeSupported => !IsNativeAot;
+        public static bool HasAssemblyFiles => !string.IsNullOrEmpty(typeof(PlatformDetection).Assembly.Location);
+        public static bool HasHostExecutable => HasAssemblyFiles; // single-file don't have a host
 
         private static volatile Tuple<bool> s_lazyNonZeroLowerBoundArraySupported;
         public static bool IsNonZeroLowerBoundArraySupported

src/libraries/System.Buffers/tests/ArrayPool/UnitTests.cs

@@ -345,7 +345,9 @@ public static void RentingSpecificLengthsYieldsExpectedLengths(int requestedMini
             }
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.Is64BitProcess))]
+        public static bool Is64BitProcessAndRemoteExecutorSupported => PlatformDetection.Is64BitProcess && RemoteExecutor.IsSupported;
+
+        [ConditionalTheory(nameof(Is64BitProcessAndRemoteExecutorSupported))]
         [InlineData(1024 * 1024 * 1024 - 1, true)]
         [InlineData(1024 * 1024 * 1024, true)]
         [InlineData(1024 * 1024 * 1024 + 1, false)]

src/libraries/System.Collections.Concurrent/tests/BlockingCollectionTests.cs

@@ -170,7 +170,7 @@ public static void TestBugFix914998()
             Assert.Equal(1, BlockingCollection<int>.TryTakeFromAny(producerArray, out ignored, -1));
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public static void TestDebuggerAttributes()
         {
             DebuggerAttributes.ValidateDebuggerDisplayReferences(new BlockingCollection<int>());
@@ -181,7 +181,7 @@ public static void TestDebuggerAttributes()
             Assert.Equal(col, items);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public static void TestDebuggerAttributes_Null()
         {
             Type proxyType = DebuggerAttributes.GetProxyType(new BlockingCollection<int>());

src/libraries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionaryTests.cs

@@ -622,7 +622,7 @@ public static void TestConstructor()
             Assert.Equal(1, dictionary.Values.Count);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public static void TestDebuggerAttributes()
         {
             DebuggerAttributes.ValidateDebuggerDisplayReferences(new ConcurrentDictionary<string, int>());
@@ -635,7 +635,7 @@ public static void TestDebuggerAttributes()
             Assert.Equal(dict, items);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public static void TestDebuggerAttributes_Null()
         {
             Type proxyType = DebuggerAttributes.GetProxyType(new ConcurrentDictionary<string, int>());

src/libraries/System.Collections.Concurrent/tests/ProducerConsumerCollectionTests.cs

@@ -953,7 +953,7 @@ public void ManyConcurrentAddsTakes_ForceContentionWithGetEnumerator(int initial
             Assert.Equal(initialCount, c.Count);
         }
 
-        [Theory]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         [InlineData(0)]
         [InlineData(10)]
         public void DebuggerAttributes_Success(int count)
@@ -966,7 +966,7 @@ public void DebuggerAttributes_Success(int count)
             Assert.Equal(c, items.Cast<int>());
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void DebuggerTypeProxy_Ctor_NullArgument_Throws()
         {
             IProducerConsumerCollection<int> c = CreateProducerConsumerCollection();

src/libraries/System.Drawing.Common/tests/BitmapTests.cs

@@ -790,6 +790,7 @@ public void GetHicon_Disposed_ThrowsArgumentException()
 
         [ConditionalFact(Helpers.IsDrawingSupported)]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "In .NET Framework we use GDI 1.0")]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/72165", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
         public void SaveWmfAsPngDoesntChangeImageBoundaries()
         {
             if (PlatformDetection.IsWindows7)

src/libraries/System.Drawing.Common/tests/IconTests.cs

@@ -647,7 +647,8 @@ void VerifyPngNotSupported()
             }
             else
             {
-                VerifyPngNotSupported();
+                if (AppContext.TryGetSwitch(DontSupportPngFramesInIcons, out bool enabled) && enabled)
+                    VerifyPngNotSupported();
             }
         }
 

src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj

@@ -5,6 +5,9 @@
     <TargetFrameworks>$(NetCoreAppCurrent)-windows;net48</TargetFrameworks>
     <IgnoreForCI Condition="'$(TargetsMobile)' == 'true'">true</IgnoreForCI>
   </PropertyGroup>
+  <ItemGroup>
+    <RdXmlFile Include="default.rd.xml" />
+  </ItemGroup>
   <ItemGroup>
     <Compile Include="AssemblyInfo.cs" />
     <Compile Include="BitmapTests.cs" />

src/libraries/System.Drawing.Common/tests/System/Drawing/FontConverterTests.cs

@@ -81,7 +81,7 @@ public void EmptyStringInput()
             Assert.Null(font);
         }
 
-        [ConditionalFact(Helpers.IsDrawingSupported)]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDrawingSupported), nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))]
         public void GetFontPropsSorted()
         {
             // The order provided since .NET Framework