Code review feedback

Mike McLaughlin · Mike McLaughlin · commit c2886ceaf9e9 · 2025-02-14T11:53:07.000-08:00
diff --git a/src/coreclr/vm/dacenumerablehash.inl b/src/coreclr/vm/dacenumerablehash.inl
@@ -345,7 +345,10 @@ DPTR(VALUE) DacEnumerableHashTable<DAC_ENUM_HASH_ARGS>::BaseFindFirstEntryByHash
     do
     {
         DWORD cBuckets = GetLength(curBuckets);
+// DAC hardening for invalid process state
+#ifdef DACCESS_COMPILE
         if (cBuckets > 0)
+#endif
         {
             // Compute which bucket the entry belongs in based on the hash.
             // +2 to skip "length" and "next" slots

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,10 @@ DPTR(VALUE) DacEnumerableHashTable<DAC_ENUM_HASH_ARGS>::BaseFindFirstEntryByHash`
`345`	`345`	`do`
`346`	`346`	`{`
`347`	`347`	`DWORD cBuckets = GetLength(curBuckets);`
	`348`	`+// DAC hardening for invalid process state`
	`349`	`+#ifdef DACCESS_COMPILE`
`348`	`350`	`if (cBuckets > 0)`
	`351`	`+#endif`
`349`	`352`	`{`
`350`	`353`	`// Compute which bucket the entry belongs in based on the hash.`
`351`	`354`	`// +2 to skip "length" and "next" slots`