Fix Type.GetHashCode for RuntimeTypes w/o MethodTable

jkotas · jkotas · commit be474603ffd6 · 2024-01-19T09:44:30.000-08:00
The hashcode for these was always 0 before this change.
diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeType.cs b/src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeType.cs
@@ -204,7 +204,12 @@ public override Array GetEnumValuesAsUnderlyingType()
         }
 
         public override int GetHashCode()
-            => ((nuint)_pUnderlyingEEType).GetHashCode();
+        {
+            MethodTable* pEEType = _pUnderlyingEEType;
+            if (pEEType != null)
+                return ((nuint)pEEType).GetHashCode();
+            return RuntimeHelpers.GetHashCode(this);
+        }
 
         public override RuntimeTypeHandle TypeHandle
         {

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,12 @@ public override Array GetEnumValuesAsUnderlyingType()`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`public override int GetHashCode()`
`207`		`- => ((nuint)_pUnderlyingEEType).GetHashCode();`
	`207`	`+ {`
	`208`	`+ MethodTable* pEEType = _pUnderlyingEEType;`
	`209`	`+ if (pEEType != null)`
	`210`	`+ return ((nuint)pEEType).GetHashCode();`
	`211`	`+ return RuntimeHelpers.GetHashCode(this);`
	`212`	`+ }`
`208`	`213`
`209`	`214`	`public override RuntimeTypeHandle TypeHandle`
`210`	`215`	`{`