HttpIOException when establishing connection, unobserved task exception (#102960)

pedrobsaila · MihaZupan · web-flow · commit b4f750ff4b6a · 2024-06-12T17:23:13.000-07:00
* HttpIOException when establishing connection, unobserved task exception

* do not eagerly allocate InitialSettingsReceived

* Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs

---------

Co-authored-by: Miha Zupan &lt;mihazupan.zupan1@gmail.com&gt;
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
@@ -503,6 +503,7 @@ private async Task ProcessIncomingFramesAsync()
                 catch (Exception e)
                 {
                     InitialSettingsReceived.TrySetException(new HttpIOException(HttpRequestError.InvalidResponse, SR.net_http_http2_connection_not_established, e));
+                    LogExceptions(InitialSettingsReceived.Task);
                     throw new HttpIOException(HttpRequestError.InvalidResponse, SR.net_http_http2_connection_not_established, e);
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,7 @@ private async Task ProcessIncomingFramesAsync()`
`503`	`503`	`catch (Exception e)`
`504`	`504`	`{`
`505`	`505`	`InitialSettingsReceived.TrySetException(new HttpIOException(HttpRequestError.InvalidResponse, SR.net_http_http2_connection_not_established, e));`
	`506`	`+ LogExceptions(InitialSettingsReceived.Task);`
`506`	`507`	`throw new HttpIOException(HttpRequestError.InvalidResponse, SR.net_http_http2_connection_not_established, e);`
`507`	`508`	`}`
`508`	`509`