Skip to content

Commit ad38517

Browse files
authored
Fix race condition in live-live CoreCLR PR (#658)
I was going over the various artifacts while writing a response to Chad Nedzlek trying to explain to him that his assessment of the bug is incorrect and I found out he is actually right. As the managed test components corresponding to the "test_build_..." can be redirected to a different OS, we need to create an explicit dependency edge as otherwise there's no guarantee that the run job will depend on the library build job for the corresponding platform. Thanks Tomas
1 parent 856df22 commit ad38517

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

eng/pipelines/coreclr/templates/run-test-job.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ jobs:
5656
- 'coreclr_test_build_p1_${{ parameters.managedTestBuildOsGroup }}${{ parameters.managedTestBuildOsSubgroup }}_${{ parameters.archType }}_${{parameters.buildConfig }}'
5757
- ${{ if ne(parameters.stagedBuild, true) }}:
5858
- ${{ format('coreclr_product_build_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
59+
- ${{ if ne(parameters.liveLibrariesBuildConfig, '') }}:
60+
- ${{ format('libraries_build_{0}_{1}{2}_{3}_{4}', 'netcoreapp', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.liveLibrariesBuildConfig) }}
5961

6062
# Compute job name from template parameters
6163
${{ if eq(parameters.testGroup, 'innerloop') }}:

0 commit comments

Comments
 (0)