Native AOT runtime implementation

Author: LakshanF

src/coreclr/nativeaot/Runtime/eventpipe/NativeaotEventPipeSupport.h

@@ -0,0 +1,22 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+#ifndef __NativeaotEventPipeSupport_h__
+#define __NativeaotEventPipeSupport_h__
+
+// This file is included only when compiling shared EventPipe source files and contains any
+// definitions which are needed by these source files but are not available in NativeAOT
+// runtime source files.
+
+// As mentioned PalRedhawk*.cpp, in general we don't want to assume that Windows and
+// Redhawk global definitions can co-exist, meaning NativeAOT runtime source files
+// generally do not have access to windows.h; that said, the HOST_WIN32 parts of the shared
+// EventPipe code are designed to rely on windows.h, so windows.h must be included when
+// compiling shared EventPipe source files, and a marker is set to indicate that windows.h
+// has been added to the compilation in this manner.
+
+#include <windows.h>
+
+#define BUILDING_SHARED_NATIVEAOT_EVENTPIPE_CODE
+
+#endif // __NativeaotEventPipeSupport_h__

src/coreclr/nativeaot/Runtime/eventpipe/ds-rt-aot.h

@@ -92,12 +92,7 @@ ds_rt_auto_trace_init (void)
     STATIC_CONTRACT_NOTHROW;
 
 #ifdef FEATURE_AUTO_TRACE
-    EX_TRY
-    {
-        auto_trace_init ();
-    }
-    EX_CATCH {}
-    EX_END_CATCH(SwallowAllExceptions);
+    auto_trace_init ();
 #endif
 }
 
@@ -108,12 +103,7 @@ ds_rt_auto_trace_launch (void)
     STATIC_CONTRACT_NOTHROW;
 
 #ifdef FEATURE_AUTO_TRACE
-    EX_TRY
-    {
-        auto_trace_launch ();
-    }
-    EX_CATCH {}
-    EX_END_CATCH(SwallowAllExceptions);
+    auto_trace_launch ();
 #endif
 }
 
@@ -124,12 +114,7 @@ ds_rt_auto_trace_signal (void)
     STATIC_CONTRACT_NOTHROW;
 
 #ifdef FEATURE_AUTO_TRACE
-    EX_TRY
-    {
-        auto_trace_signal ();
-    }
-    EX_CATCH {}
-    EX_END_CATCH(SwallowAllExceptions);
+    auto_trace_signal ();
 #endif
 }
 
@@ -140,12 +125,7 @@ ds_rt_auto_trace_wait (void)
     STATIC_CONTRACT_NOTHROW;
 
 #ifdef FEATURE_AUTO_TRACE
-    EX_TRY
-    {
-        auto_trace_wait ();
-    }
-    EX_CATCH {}
-    EX_END_CATCH(SwallowAllExceptions);
+    auto_trace_wait ();
 #endif
 }
 
@@ -159,18 +139,18 @@ bool
 ds_rt_config_value_get_enable (void)
 {
     STATIC_CONTRACT_NOTHROW;
-    return CLRConfig::GetConfigValue (CLRConfig::EXTERNAL_EnableDiagnostics) != 0;
+
+    // TODO: EventPipe Configuration values - RhConfig?
+    return true;
 }
 
 static
 inline
 ep_char8_t *
 ds_rt_config_value_get_ports (void)
 {
-    STATIC_CONTRACT_NOTHROW;
-
-    CLRConfigStringHolder value(CLRConfig::GetConfigValue (CLRConfig::EXTERNAL_DOTNET_DiagnosticPorts));
-    return ep_rt_utf16_to_utf8_string (reinterpret_cast<ep_char16_t *>(value.GetValue ()), -1);
+    // TODO: EventPipe Configuration values - RhConfig?
+    return nullptr;
 }
 
 static
@@ -179,7 +159,8 @@ uint32_t
 ds_rt_config_value_get_default_port_suspend (void)
 {
     STATIC_CONTRACT_NOTHROW;
-    return static_cast<uint32_t>(CLRConfig::GetConfigValue (CLRConfig::EXTERNAL_DOTNET_DefaultDiagnosticPortSuspend));
+    // TODO: EventPipe Configuration values - RhConfig?
+    return 0;
 }
 
 /*
@@ -197,24 +178,11 @@ ds_rt_generate_core_dump (
     STATIC_CONTRACT_NOTHROW;
 
     ds_ipc_result_t result = DS_IPC_E_FAIL;
-    EX_TRY
-    {
-        uint32_t flags = ds_generate_core_dump_command_payload_get_flags(payload);
-        if (commandId == DS_DUMP_COMMANDID_GENERATE_CORE_DUMP)
-        {
-            // For the old commmand, this payload field is a bool of whether to enable logging
-            flags = flags != 0 ? GenerateDumpFlagsLoggingEnabled : 0;
-        }
-        LPCWSTR dumpName = reinterpret_cast<LPCWSTR>(ds_generate_core_dump_command_payload_get_dump_name (payload));
-        int32_t dumpType = static_cast<int32_t>(ds_generate_core_dump_command_payload_get_dump_type (payload));
-        if (GenerateDump(dumpName, dumpType, flags, errorMessageBuffer, cbErrorMessageBuffer))
-        {
-            result = DS_IPC_S_OK;
-        }
-    }
-    EX_CATCH {}
-    EX_END_CATCH(SwallowAllExceptions);
-    return result;
+    uint32_t flags = ds_generate_core_dump_command_payload_get_flags(payload);
+    // TODO: Generate an exception dump
+    __debugbreak();
+
+    return 0;
 }
 
 /*
@@ -233,10 +201,11 @@ ds_rt_transport_get_default_name (
     const ep_char8_t *suffix)
 {
     STATIC_CONTRACT_NOTHROW;
-
-#ifdef TARGET_UNIX
-    PAL_GetTransportName (name_len, name, prefix, id, group_id, suffix);
-#endif
+    
+    // TODO: PAL_GetTransportName is defined in coreclr\pal\inc\pal.h
+// #ifdef TARGET_UNIX
+//     PAL_GetTransportName (name_len, name, prefix, id, group_id, suffix);
+// #endif
     return true;
 }
 
@@ -289,14 +258,11 @@ ds_rt_profiler_attach (DiagnosticsAttachProfilerCommandPayload *payload)
     ClrFlsSetThreadType (ThreadType_ProfAPI_Attach);
 
     HRESULT hr = S_OK;
-    EX_TRY {
-        hr = ProfilingAPIUtility::LoadProfilerForAttach (reinterpret_cast<const CLSID *>(ds_attach_profiler_command_payload_get_profiler_guid_cref (payload)),
-            reinterpret_cast<LPCWSTR>(ds_attach_profiler_command_payload_get_profiler_path (payload)),
-            reinterpret_cast<LPVOID>(ds_attach_profiler_command_payload_get_client_data (payload)),
-            static_cast<UINT>(ds_attach_profiler_command_payload_get_client_data_len (payload)),
-            static_cast<DWORD>(ds_attach_profiler_command_payload_get_attach_timeout (payload)));
-    }
-    EX_CATCH_HRESULT (hr);
+    hr = ProfilingAPIUtility::LoadProfilerForAttach (reinterpret_cast<const CLSID *>(ds_attach_profiler_command_payload_get_profiler_guid_cref (payload)),
+        reinterpret_cast<LPCWSTR>(ds_attach_profiler_command_payload_get_profiler_path (payload)),
+        reinterpret_cast<LPVOID>(ds_attach_profiler_command_payload_get_client_data (payload)),
+        static_cast<UINT>(ds_attach_profiler_command_payload_get_client_data_len (payload)),
+        static_cast<DWORD>(ds_attach_profiler_command_payload_get_attach_timeout (payload)));
 
     // Clear the flag so this thread isn't permanently marked as the attach thread.
     ClrFlsClearThreadType (ThreadType_ProfAPI_Attach);
@@ -312,14 +278,11 @@ ds_rt_profiler_startup (DiagnosticsStartupProfilerCommandPayload *payload)
     STATIC_CONTRACT_NOTHROW;
 
     HRESULT hr = S_OK;
-    EX_TRY {
-        StoredProfilerNode *profilerData = new StoredProfilerNode();
-        profilerData->guid = *(reinterpret_cast<const CLSID *>(ds_startup_profiler_command_payload_get_profiler_guid_cref (payload)));
-        profilerData->path.Set(reinterpret_cast<LPCWSTR>(ds_startup_profiler_command_payload_get_profiler_path (payload)));
+    StoredProfilerNode *profilerData = new StoredProfilerNode();
+    profilerData->guid = *(reinterpret_cast<const CLSID *>(ds_startup_profiler_command_payload_get_profiler_guid_cref (payload)));
+    profilerData->path.Set(reinterpret_cast<LPCWSTR>(ds_startup_profiler_command_payload_get_profiler_path (payload)));
 
-        g_profControlBlock.storedProfilers.InsertHead(profilerData);
-    }
-    EX_CATCH_HRESULT (hr);
+    g_profControlBlock.storedProfilers.InsertHead(profilerData);
 
     return hr;
 }
@@ -329,7 +292,9 @@ static
 uint32_t
 ds_rt_set_environment_variable (const ep_char16_t *name, const ep_char16_t *value)
 {
-    return SetEnvironmentVariableW(reinterpret_cast<LPCWSTR>(name), reinterpret_cast<LPCWSTR>(value)) ? S_OK : HRESULT_FROM_WIN32(GetLastError());
+     // return SetEnvironmentVariableW(reinterpret_cast<LPCWSTR>(name), reinterpret_cast<LPCWSTR>(value)) ? S_OK : HRESULT_FROM_WIN32(GetLastError());
+     __debugbreak();
+    return 0xffff;
 }
 
 /*
@@ -343,19 +308,8 @@ ds_rt_server_log_pause_message (void)
     STATIC_CONTRACT_NOTHROW;
 
     const char diagPortsName[] = "DOTNET_DiagnosticPorts";
-    CLRConfigNoCache diagPorts = CLRConfigNoCache::Get(diagPortsName);
-    LPCSTR ports = nullptr;
-    if (diagPorts.IsSet())
-    {
-        ports = diagPorts.AsString();
-    }
-
-    uint32_t port_suspended = ds_rt_config_value_get_default_port_suspend();
-
-    printf("The runtime has been configured to pause during startup and is awaiting a Diagnostics IPC ResumeStartup command from a Diagnostic Port.\n");
-    printf("%s=\"%s\"\n", diagPortsName, ports == nullptr ? "" : ports);
-    printf("DOTNET_DefaultDiagnosticPortSuspend=%u\n", port_suspended);
-    fflush(stdout);
+    // TODO: Cannot find nocache versions of RhConfig
+    __debugbreak();
 }
 
 #endif /* ENABLE_PERFTRACING */

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp

@@ -5,7 +5,6 @@
 #include <eventpipe/ep.h>
 #include <eventpipe/ep-stack-contents.h>
 #include <eventpipe/ep-rt.h>
-#include "threadsuspend.h"
 
 ep_rt_lock_handle_t _ep_rt_aot_config_lock_handle;
 CrstStatic _ep_rt_aot_config_lock;
@@ -22,71 +21,21 @@ uint32_t *_ep_rt_aot_proc_group_offsets;
  * Forward declares of all static functions.
  */
 
-static
-StackWalkAction
-stack_walk_callback (
-    CrawlFrame *frame,
-    EventPipeStackContents *stack_contents);
 
 static
 void
 walk_managed_stack_for_threads (
     ep_rt_thread_handle_t sampling_thread,
     EventPipeEvent *sampling_event);
 
-static
-StackWalkAction
-stack_walk_callback (
-    CrawlFrame *frame,
-    EventPipeStackContents *stack_contents)
-{
-    STATIC_CONTRACT_NOTHROW;
-    EP_ASSERT (frame != NULL);
-    EP_ASSERT (stack_contents != NULL);
-
-    // Get the IP.
-    UINT_PTR control_pc = (UINT_PTR)frame->GetRegisterSet ()->ControlPC;
-    if (control_pc == NULL) {
-        if (ep_stack_contents_get_length (stack_contents) == 0) {
-            // This happens for pinvoke stubs on the top of the stack.
-            return SWA_CONTINUE;
-        }
-    }
-
-    EP_ASSERT (control_pc != NULL);
-
-    // Add the IP to the captured stack.
-    ep_stack_contents_append (stack_contents, control_pc, frame->GetFunction ());
-
-    // Continue the stack walk.
-    return SWA_CONTINUE;
-}
 
 bool
 ep_rt_aot_walk_managed_stack_for_thread (
     ep_rt_thread_handle_t thread,
     EventPipeStackContents *stack_contents)
 {
-    STATIC_CONTRACT_NOTHROW;
-    EP_ASSERT (thread != NULL);
-    EP_ASSERT (stack_contents != NULL);
-
-    // Calling into StackWalkFrames in preemptive mode violates the host contract,
-    // but this contract is not used on Aot.
-    CONTRACT_VIOLATION (HostViolation);
-
-    // Before we call into StackWalkFrames we need to mark GC_ON_TRANSITIONS as FALSE
-    // because under GCStress runs (GCStress=0x3), a GC will be triggered for every transition,
-    // which will cause the GC to try to walk the stack while we are in the middle of walking the stack.
-    bool gc_on_transitions = GC_ON_TRANSITIONS (FALSE);
-
-    StackWalkAction result = thread->StackWalkFrames (
-        (PSTACKWALKFRAMESCALLBACK)stack_walk_callback,
-        stack_contents,
-        ALLOW_ASYNC_STACK_WALK | FUNCTIONSONLY | HANDLESKIPPEDFRAMES | ALLOW_INVALID_OBJECTS);
-
-    GC_ON_TRANSITIONS (gc_on_transitions);
-    return ((result == SWA_DONE) || (result == SWA_CONTINUE));
+    __debugbreak();
+    return false;
 }
 
 // The thread store lock must already be held by the thread before this function
@@ -97,68 +46,13 @@ walk_managed_stack_for_threads (
     ep_rt_thread_handle_t sampling_thread,
     EventPipeEvent *sampling_event)
 {
-    STATIC_CONTRACT_NOTHROW;
-    EP_ASSERT (sampling_thread != NULL);
-
-    Thread *target_thread = NULL;
-
-    EventPipeStackContents stack_contents;
-    EventPipeStackContents *current_stack_contents;
-    current_stack_contents = ep_stack_contents_init (&stack_contents);
-
-    EP_ASSERT (current_stack_contents != NULL);
-
-    // Iterate over all managed threads.
-    // Assumes that the ThreadStoreLock is held because we've suspended all threads.
-    while ((target_thread = ThreadStore::GetThreadList (target_thread)) != NULL) {
-        ep_stack_contents_reset (current_stack_contents);
-
-        // Walk the stack and write it out as an event.
-        if (ep_rt_aot_walk_managed_stack_for_thread (target_thread, current_stack_contents) && !ep_stack_contents_is_empty (current_stack_contents)) {
-            // Set the payload.  If the GC mode on suspension > 0, then the thread was in cooperative mode.
-            // Even though there are some cases where this is not managed code, we assume it is managed code here.
-            // If the GC mode on suspension == 0 then the thread was in preemptive mode, which we qualify as external here.
-            uint32_t payload_data = target_thread->GetGCModeOnSuspension () ? EP_SAMPLE_PROFILER_SAMPLE_TYPE_MANAGED : EP_SAMPLE_PROFILER_SAMPLE_TYPE_EXTERNAL;
-
-            // Write the sample.
-            ep_write_sample_profile_event (
-                sampling_thread,
-                sampling_event,
-                target_thread,
-                current_stack_contents,
-                (uint8_t *)&payload_data,
-                sizeof (payload_data));
-        }
-
-        // Reset the GC mode.
-        target_thread->ClearGCModeOnSuspension ();
-    }
-
-    ep_stack_contents_fini (current_stack_contents);
 }
 
 void
 ep_rt_aot_sample_profiler_write_sampling_event_for_threads (
     ep_rt_thread_handle_t sampling_thread,
     EventPipeEvent *sampling_event)
 {
-    STATIC_CONTRACT_NOTHROW;
-    EP_ASSERT (sampling_thread != NULL);
-
-    // Check to see if we can suspend managed execution.
-    if (ThreadSuspend::SysIsSuspendInProgress () || (ThreadSuspend::GetSuspensionThread () != 0))
-        return;
-
-    // Actually suspend managed execution.
-    ThreadSuspend::SuspendEE (ThreadSuspend::SUSPEND_REASON::SUSPEND_OTHER);
-
-    // Walk all managed threads and capture stacks.
-    walk_managed_stack_for_threads (sampling_thread, sampling_event);
-
-    // Resume managed execution.
-    ThreadSuspend::RestartEE (FALSE /* bFinishedGC */, TRUE /* SuspendSucceeded */);
-
-    return;
 }
 
 #endif /* ENABLE_PERFTRACING */