Disable offending H/3 op causing server errors (#58541)

github-actions[bot] · ManickaP · web-flow · commit a99190cbcfe0 · 2021-09-07T10:27:24.000-07:00
Co-authored-by: ManickaP &lt;mapichov@microsoft.com&gt;
diff --git a/eng/pipelines/libraries/stress/http.yml b/eng/pipelines/libraries/stress/http.yml
@@ -50,7 +50,7 @@ jobs:
 
   - bash: |
       cd '$(httpStressProject)'
-      export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0"
+      export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0 -xops 10"
       export HTTPSTRESS_SERVER_ARGS="$HTTPSTRESS_SERVER_ARGS -http 3.0"
       docker-compose up --abort-on-container-exit --no-color
     displayName: Run HttpStress - HTTP 3.0
diff --git a/src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs b/src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs
@@ -508,12 +508,6 @@ public static (string name, Func<RequestContext, Task> operation)[] Operations =
 
         private static void ValidateStatusCode(HttpResponseMessage m, HttpStatusCode expectedStatus = HttpStatusCode.OK)
         {
-            // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
-            if (m.StatusCode == HttpStatusCode.InternalServerError)
-            {
-                throw new Exception("IGNORE");
-            }
-
             if (m.StatusCode != expectedStatus)
             {
                 throw new Exception($"Expected status code {expectedStatus}, got {m.StatusCode}");
diff --git a/src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs b/src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs
@@ -209,11 +209,6 @@ async Task RunWorker(int taskNum)
                     {
                         _aggregator.RecordCancellation(opIndex, stopwatch.Elapsed);
                     }
-                    catch (Exception e) when (e.Message == "IGNORE")
-                    {
-                        // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
-                        // See ClientOperations.ValidateStatusCode
-                    }
                     catch (Exception e)
                     {
                         _aggregator.RecordFailure(e, opIndex, stopwatch.Elapsed, requestContext.IsCancellationRequested, taskNum: taskNum, iteration: i);

Original file line number	Diff line number	Diff line change
`@@ -508,12 +508,6 @@ public static (string name, Func<RequestContext, Task> operation)[] Operations =`
`508`	`508`
`509`	`509`	`private static void ValidateStatusCode(HttpResponseMessage m, HttpStatusCode expectedStatus = HttpStatusCode.OK)`
`510`	`510`	`{`
`511`		`- // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]`
`512`		`- if (m.StatusCode == HttpStatusCode.InternalServerError)`
`513`		`- {`
`514`		`- throw new Exception("IGNORE");`
`515`		`- }`
`516`		`-`
`517`	`511`	`if (m.StatusCode != expectedStatus)`
`518`	`512`	`{`
`519`	`513`	`throw new Exception($"Expected status code {expectedStatus}, got {m.StatusCode}");`
Original file line number	Diff line number	Diff line change
`@@ -209,11 +209,6 @@ async Task RunWorker(int taskNum)`
`209`	`209`	`{`
`210`	`210`	`_aggregator.RecordCancellation(opIndex, stopwatch.Elapsed);`
`211`	`211`	`}`
`212`		`- catch (Exception e) when (e.Message == "IGNORE")`
`213`		`- {`
`214`		`- // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]`
`215`		`- // See ClientOperations.ValidateStatusCode`
`216`		`- }`
`217`	`212`	`catch (Exception e)`
`218`	`213`	`{`
`219`	`214`	`_aggregator.RecordFailure(e, opIndex, stopwatch.Elapsed, requestContext.IsCancellationRequested, taskNum: taskNum, iteration: i);`