Skip to content

Commit 9a693e0

Browse files
Emit GC info into a COMDAT section (#83371)
Saves 3.14% on BasicWebApi. 🤯 We run linker with COMDAT folding enabled. Generating this data into COMDAT foldable section allows linker to deduplicate these.
1 parent 9f07f65 commit 9a693e0

File tree

1 file changed

+1
-3
lines changed
  • src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis

1 file changed

+1
-3
lines changed

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ObjectWriter.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,9 +535,7 @@ public void PublishUnwindInfo(ObjectNode node)
535535

536536
byte[] blobSymbolName = _sb.Append(_currentNodeZeroTerminatedName).ToUtf8String().UnderlyingArray;
537537

538-
ObjectNodeSection section = ObjectNodeSection.XDataSection;
539-
if (ShouldShareSymbol(node))
540-
section = GetSharedSection(section, _sb.ToString());
538+
ObjectNodeSection section = GetSharedSection(ObjectNodeSection.XDataSection, _sb.ToString());
541539
SwitchSection(_nativeObjectWriter, section.Name, GetCustomSectionAttributes(section), section.ComdatName);
542540

543541
EmitAlignment(4);

0 commit comments

Comments
 (0)