Skip to content

Commit 8e1fc0b

Browse files
author
Steve Pfister
committed
Feedback
1 parent e5b7479 commit 8e1fc0b

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/libraries/System.IO.IsolatedStorage/src/Resources/Strings.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@
141141
<data name="PlatformNotSupported_CAS" xml:space="preserve">
142142
<value>Code Access Security is not supported on this platform.</value>
143143
</data>
144-
<data name="PlatformNotSupported_Browser" xml:space="preserve">
145-
<value>System.IO.IsolatedStorage is not supported on Browser.</value>
144+
<data name="IsolatedStorage_PlatformNotSupported" xml:space="preserve">
145+
<value>System.IO.IsolatedStorage is not supported on this platform.</value>
146146
</data>
147147
</root>

src/libraries/System.IO.IsolatedStorage/src/System.IO.IsolatedStorage.csproj

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFrameworks>$(NetCoreAppCurrent)-Windows_NT;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)-Browser</TargetFrameworks>
3+
<TargetFrameworks>$(NetCoreAppCurrent)-Windows_NT;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)</TargetFrameworks>
44
<Nullable>enable</Nullable>
55
</PropertyGroup>
66
<PropertyGroup>
7-
<GeneratePlatformNotSupportedAssemblyMessage Condition="'$(TargetsBrowser)' == 'true'">SR.PlatformNotSupported_Browser</GeneratePlatformNotSupportedAssemblyMessage>
7+
<GeneratePlatformNotSupportedAssemblyMessage Condition="'$(TargetsAnyOS)' == 'true'">SR.IsolatedStorage_PlatformNotSupported</GeneratePlatformNotSupportedAssemblyMessage>
88
</PropertyGroup>
9-
<ItemGroup Condition="'$(TargetsBrowser)' != 'true'">
9+
<ItemGroup Condition="'$(TargetsAnyOS)' != 'true'">
1010
<Compile Include="System\IO\IsolatedStorage\IsolatedStorageException.cs" />
1111
<Compile Include="System\IO\IsolatedStorage\IsolatedStorageFile.cs" />
1212
<Compile Include="System\IO\IsolatedStorage\IsolatedStorageFileStream.cs" />
@@ -21,18 +21,20 @@
2121
<ItemGroup Condition="'$(TargetsWindows)' == 'true'">
2222
<Compile Include="System\IO\IsolatedStorage\Helper.Win32.cs" />
2323
</ItemGroup>
24-
<ItemGroup Condition="'$(TargetsUnix)' == 'true' and '$(TargetsBrowser)' != 'true'">
24+
<ItemGroup Condition="'$(TargetsUnix)' == 'true'">
2525
<Compile Include="System\IO\IsolatedStorage\Helper.Unix.cs" />
2626
</ItemGroup>
27-
<ItemGroup Condition="'$(TargetsBrowser)' != 'true'">
27+
<ItemGroup Condition="'$(TargetsAnyOS)' != 'true'">
2828
<Reference Include="System.IO.FileSystem" />
2929
<Reference Include="System.Linq" />
30-
<Reference Include="System.Runtime" />
3130
<Reference Include="System.Runtime.Extensions" />
3231
<Reference Include="System.Security.Cryptography.Algorithms" />
3332
<Reference Include="System.Security.Cryptography.Primitives" />
3433
<Reference Include="System.Threading" />
3534
</ItemGroup>
35+
<ItemGroup>
36+
<Reference Include="System.Runtime" />
37+
</ItemGroup>
3638
<ItemGroup Condition="'$(TargetsWindows)' == 'true'">
3739
<Reference Include="System.IO.FileSystem.AccessControl" />
3840
<Reference Include="System.Security.AccessControl" />

src/libraries/System.IO.IsolatedStorage/tests/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
// create unique identities for every test to allow every test to have
1010
// it's own store.
1111
[assembly: CollectionBehavior(CollectionBehavior.CollectionPerAssembly, DisableTestParallelization = true)]
12-
[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
12+
[assembly: SkipOnMono("System.IO.IsolatedStorage is not supported on Browser", TestPlatforms.Browser)]

0 commit comments

Comments
 (0)