[mono][llvm] Refactor code to make it easier to support LLVM 13.x in … (#67692)

* [mono][llvm] Refactor code to make it easier to support LLVM 13.x in the future

* Remove some c++ functions which can be implemented using the C API.
* Use call_intrins in more places.

* Use the const_int32 ()/const_int64 () helper functions in more places.

* Use opaque pointer type APIs.

LLVM is transitioning to using opaque pointer types, i.e. pointer
types with no element type. Transition the LLVM backend to do
the same.

* Add an 'Address' structure which represents a pointer value and
  its element type, use it in places where the element type of
  a pointer is not locally available, like for globals.
* Use LLVMBuildCall2/BuildInvoke2 functions where possible.

* Fix the build.

Author: vargaz

src/mono/mono/mini/mini-llvm-cpp.cpp

@@ -104,15 +104,6 @@ mono_llvm_build_alloca (LLVMBuilderRef builder, LLVMTypeRef Ty, LLVMValueRef Arr
 	return wrap (ins);
 }
 
-LLVMValueRef 
-mono_llvm_build_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
-					  const char *Name, gboolean is_volatile)
-{
-	LoadInst *ins = unwrap(builder)->CreateLoad(unwrap(PointerVal), is_volatile, Name);
-
-	return wrap(ins);
-}
-
 LLVMValueRef
 mono_llvm_build_atomic_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
 							 const char *Name, gboolean is_volatile, int alignment, BarrierKind barrier)
@@ -150,10 +141,25 @@ mono_llvm_build_aligned_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
 }
 
 LLVMValueRef 
-mono_llvm_build_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
-					  gboolean is_volatile, BarrierKind barrier)
+mono_llvm_build_aligned_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
+							   gboolean is_volatile, int alignment)
+{
+	StoreInst *ins;
+
+	ins = unwrap(builder)->CreateStore(unwrap(Val), unwrap(PointerVal), is_volatile);
+	ins->setAlignment (to_align (alignment));
+
+	return wrap (ins);
+}
+
+LLVMValueRef
+mono_llvm_build_atomic_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
+							  BarrierKind barrier, int alignment)
 {
-	StoreInst *ins = unwrap(builder)->CreateStore(unwrap(Val), unwrap(PointerVal), is_volatile);
+	StoreInst *ins;
+
+	ins = unwrap(builder)->CreateStore(unwrap(Val), unwrap(PointerVal), false);
+	ins->setAlignment (to_align (alignment));
 
 	switch (barrier) {
 	case LLVM_BARRIER_NONE:
@@ -169,18 +175,6 @@ mono_llvm_build_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef Po
 		break;
 	}
 
-	return wrap(ins);
-}
-
-LLVMValueRef 
-mono_llvm_build_aligned_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
-							   gboolean is_volatile, int alignment)
-{
-	StoreInst *ins;
-
-	ins = unwrap(builder)->CreateStore(unwrap(Val), unwrap(PointerVal), is_volatile);
-	ins->setAlignment (to_align (alignment));
-
 	return wrap (ins);
 }
 

src/mono/mono/mini/mini-llvm-cpp.h

@@ -67,10 +67,6 @@ mono_llvm_build_alloca (LLVMBuilderRef builder, LLVMTypeRef Ty,
 						LLVMValueRef ArraySize,
 						int alignment, const char *Name);
 
-LLVMValueRef
-mono_llvm_build_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
-					  const char *Name, gboolean is_volatile);
-
 LLVMValueRef
 mono_llvm_build_atomic_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
 							 const char *Name, gboolean is_volatile, int alignment, BarrierKind barrier);
@@ -79,14 +75,14 @@ LLVMValueRef
 mono_llvm_build_aligned_load (LLVMBuilderRef builder, LLVMValueRef PointerVal,
 							  const char *Name, gboolean is_volatile, int alignment);
 
-LLVMValueRef
-mono_llvm_build_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
-					   gboolean is_volatile, BarrierKind kind);
-
 LLVMValueRef
 mono_llvm_build_aligned_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
 							   gboolean is_volatile, int alignment);
 
+LLVMValueRef
+mono_llvm_build_atomic_store (LLVMBuilderRef builder, LLVMValueRef Val, LLVMValueRef PointerVal,
+							  BarrierKind barrier, int alignment);
+
 LLVMValueRef
 mono_llvm_build_atomic_rmw (LLVMBuilderRef builder, AtomicRMWOp op, LLVMValueRef ptr, LLVMValueRef val);