Skip to content

Commit 8197915

Browse files
shangchenglumetrojkotas
authored andcommitted
chore: fix some comments (#105504)
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
1 parent f8d9519 commit 8197915

File tree

11 files changed

+12
-12
lines changed

11 files changed

+12
-12
lines changed

docs/design/coreclr/jit/profile-count-reconstruction.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ So solution techniques that can leverage sparseness are of particular interest.
111111

112112
Note the matrix $\boldsymbol I - \boldsymbol P$ has non-negative diagonal elements and negative non-diagonal elements, since all entries of $\boldsymbol P$ are in the range [0,1].
113113

114-
If we further restrict ourselves to the case where $p_{i,i} \lt 1$ (meaning there are are no infinite self-loops) then all the diagonal entries are positive and the matrix has an inverse with no negative elements.
114+
If we further restrict ourselves to the case where $p_{i,i} \lt 1$ (meaning there are no infinite self-loops) then all the diagonal entries are positive and the matrix has an inverse with no negative elements.
115115

116116
Such matrices are known as M-matrices.
117117

docs/design/mono/web/aot.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ It is possible to use LLVM in AOT mode. This is implemented by compiling methods
105105

106106
### Full AOT mode
107107

108-
Some platforms like the iphone prohibit JITted code, using technical and/or legal means. This is a significant problem for the mono runtime, since it generates a lot of code dynamically, using either the JIT or more low-level code generation macros. To solve this, the AOT compiler is able to function in full-aot or aot-only mode, where it generates and saves all the neccesary code in the aot image, so at runtime, no code needs to be generated. There are two kinds of code which needs to be considered:
108+
Some platforms like the iphone prohibit JITted code, using technical and/or legal means. This is a significant problem for the mono runtime, since it generates a lot of code dynamically, using either the JIT or more low-level code generation macros. To solve this, the AOT compiler is able to function in full-aot or aot-only mode, where it generates and saves all the necessary code in the aot image, so at runtime, no code needs to be generated. There are two kinds of code which needs to be considered:
109109

110110
- wrapper methods, that is methods whose IL is generated dynamically by the runtime. They are handled by generating them in the add_wrappers () function, then emitting them as 'extra' methods.
111111
- trampolines and other small hand generated pieces of code. They are handled in an ad-hoc way in the emit_trampolines () function.

docs/design/mono/web/exception-handling.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ Currently, exceptions are raised by calling mono_raise_exception () in the middl
114114

115115
- To allow mono_raise_exception () to unwind through native code, we need to save the LMF structures which can add a lot of overhead even in the common case when no exception is thrown. So this is not zero-cost exception handling.
116116

117-
An alternative might be to use a JNI style set-pending-exception API. Runtime code could call mono_set_pending_exception (), then return to its caller with an error indication allowing the caller to clean up. When execution returns to managed code, then managed-\>native wrapper could check whenever there is a pending exception and throw it if neccesary. Since we already check for pending thread interruption, this would have no overhead, allowing us to drop the LMF saving/restoring code, or significant parts of it.
117+
An alternative might be to use a JNI style set-pending-exception API. Runtime code could call mono_set_pending_exception (), then return to its caller with an error indication allowing the caller to clean up. When execution returns to managed code, then managed-\>native wrapper could check whenever there is a pending exception and throw it if necessary. Since we already check for pending thread interruption, this would have no overhead, allowing us to drop the LMF saving/restoring code, or significant parts of it.
118118

119119
### libunwind
120120

docs/design/mono/web/linear-ir.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ The JIT allocates a large number of vregs. Most of these are created during the
9696
### Transitioning between the two states
9797

9898
- Most vregs start out being local. Others, like the ones representing the arguments and locals of a method, start out being global.
99-
- Some transformations done by the JIT can break the invariant that an lvreg is local to a basic block. There is a separate pass, mono_handle_global_vregs (), which verifies this invariant and transforms lvregs into global vregs if neccesary. This pass also does the opposite transformation, by transforming global vregs used only in one bblock into an lvreg.
99+
- Some transformations done by the JIT can break the invariant that an lvreg is local to a basic block. There is a separate pass, mono_handle_global_vregs (), which verifies this invariant and transforms lvregs into global vregs if necessary. This pass also does the opposite transformation, by transforming global vregs used only in one bblock into an lvreg.
100100
- If an address of a vreg needs to be taken, the vreg is transformed into a global vreg.
101101

102102
JIT Passes

docs/design/mono/web/register-allocation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Some variables might already be allocated to hardware registers during the globa
5656

5757
#### Floating point stack
5858

59-
The x86 architecture uses a floating point register stack instead of a set of fp registers. The allocator supports this by a post-processing pass which keeps track of the height of the fp stack, and spills/loads values from the stack as neccesary.
59+
The x86 architecture uses a floating point register stack instead of a set of fp registers. The allocator supports this by a post-processing pass which keeps track of the height of the fp stack, and spills/loads values from the stack as necessary.
6060

6161
#### Calls
6262

src/coreclr/jit/fginline.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1975,7 +1975,7 @@ void Compiler::fgInsertInlineeArgument(
19751975
// * Passing of call arguments via temps
19761976
//
19771977
// Newly added statements are placed just after the original call
1978-
// and are are given the same inline context as the call any calls
1978+
// and are given the same inline context as the call any calls
19791979
// added here will appear to have been part of the immediate caller.
19801980
//
19811981
Statement* Compiler::fgInlinePrependStatements(InlineInfo* inlineInfo)

src/coreclr/tools/Common/Compiler/InstructionSetSupport.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ private static Dictionary<string, InstructionSet> ComputeInstructSetSupportForAr
201201
var support = new Dictionary<string, InstructionSet>();
202202
foreach (var instructionSet in InstructionSetFlags.ArchitectureToValidInstructionSets(architecture))
203203
{
204-
// Only instruction sets with associated R2R enum values are are specifiable
204+
// Only instruction sets with associated R2R enum values are specifiable
205205
if (instructionSet.Specifiable)
206206
support.Add(instructionSet.Name, instructionSet.InstructionSet);
207207
}
@@ -214,7 +214,7 @@ private static InstructionSetFlags ComputeNonSpecifiableInstructionSetSupportFor
214214
var support = new InstructionSetFlags();
215215
foreach (var instructionSet in InstructionSetFlags.ArchitectureToValidInstructionSets(architecture))
216216
{
217-
// Only instruction sets with associated R2R enum values are are specifiable
217+
// Only instruction sets with associated R2R enum values are specifiable
218218
if (!instructionSet.Specifiable)
219219
support.AddInstructionSet(instructionSet.InstructionSet);
220220
}

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TrimSafeReflectionHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace System.ComponentModel
88
{
99
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern",
10-
Justification = "Class is only called with types are are registered or protected with [DynamicallyAccessedMemberTypes].")]
10+
Justification = "Class is only called with types are registered or protected with [DynamicallyAccessedMemberTypes].")]
1111
internal static class TrimSafeReflectionHelper
1212
{
1313
public static PropertyInfo[] GetProperties(Type type, BindingFlags bindingAttr) => type.GetProperties(bindingAttr);

src/libraries/System.Runtime.Serialization.Xml/tests/XsdDataContractExporterTests/SerializationTypes/PartialTrust.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public class AttributeOnlyIXmlSerializable : IXmlSerializable
6464
{
6565
public AttributeOnlyIXmlSerializable()
6666
{
67-
// This was not commented in NetFx. It clutters output though and seems unneccesary for our needs.
67+
// This was not commented in NetFx. It clutters output though and seems unnecessary for our needs.
6868
//Console.WriteLine("Default Ctor");
6969
}
7070

src/mono/mono/component/marshal-ilgen.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ emit_marshal_char_ilgen (EmitMarshalContext *m, int argnum, MonoType *t,
10441044
static int
10451045
emit_marshal_custom_ilgen_throw_exception (MonoMethodBuilder *mb, const char *exc_nspace, const char *exc_name, const char *msg, MarshalAction action)
10461046
{
1047-
/* Throw exception and emit compensation code, if neccesary */
1047+
/* Throw exception and emit compensation code, if necessary */
10481048
switch (action) {
10491049
case MARSHAL_ACTION_CONV_IN:
10501050
case MARSHAL_ACTION_MANAGED_CONV_IN:

0 commit comments

Comments
 (0)