Skip to content

Commit 80392a9

Browse files
committed
don't run LongModuleFileNamesAreSupported test on x86 (for some reason it's flaky)
1 parent fde6b37 commit 80392a9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,10 @@ public void ModulesAreDisposedWhenProcessIsDisposed()
9393
}
9494

9595
public static bool Is_LongModuleFileNamesAreSupported_TestEnabled
96-
=> PathFeatures.AreAllLongPathsAvailable() // we want to test long paths
96+
=> OperatingSystem.IsWindows() // it's specific to Windows
97+
&& PathFeatures.AreAllLongPathsAvailable() // we want to test long paths
9798
&& !PlatformDetection.IsMonoRuntime // Assembly.LoadFile used the way this test is implemented fails on Mono
98-
&& OperatingSystem.IsWindowsVersionAtLeast(8); // it's specific to Windows and does not work on Windows 7
99+
&& PlatformDetection.Is64BitProcess; // for some reason it's flaky on x86
99100

100101
[ConditionalFact(typeof(ProcessModuleTests), nameof(Is_LongModuleFileNamesAreSupported_TestEnabled))]
101102
public void LongModuleFileNamesAreSupported()

0 commit comments

Comments
 (0)