Update coding-style to include target-typed new() guideline (#67061)

* Update coding-style to include target-typed new guideline

Similar to `var` usage, `new()` usage is only allowed when the Type can be understood from the same line.

Fix #53369

* Fix coding style violations

Author: eerhardt

docs/coding-guidelines/coding-style.md

@@ -24,6 +24,7 @@ The general rule we follow is "use Visual Studio defaults".
 9. If a file happens to differ in style from these guidelines (e.g. private members are named `m_member`
    rather than `_member`), the existing style in that file takes precedence.
 10. We only use `var` when the type is explicitly named on the right-hand side, typically due to either `new` or an explicit cast, e.g. `var stream = new FileStream(...)` not `var stream = OpenStandardInput()`.
+    - Similarly, target-typed `new()` can only be used when the type is explicitly named on the left-hand side, in a variable definition statement or a field definition statement. e.g. `FileStream stream = new(...);`, but not `stream = new(...);` (where the type was specified on a previous line).
 11. We use language keywords instead of BCL types (e.g. `int, string, float` instead of `Int32, String, Single`, etc) for both type references as well as method calls (e.g. `int.Parse` instead of `Int32.Parse`). See issue [#13976](https://github.com/dotnet/runtime/issues/13976) for examples.
 12. We use PascalCasing to name all our constant local variables and fields. The only exception is for interop code where the constant value should exactly match the name and value of the code you are calling via interop.
 13. We use PascalCasing for all method names, including local functions.

src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs

@@ -46,7 +46,7 @@ public MemoryCache(IOptions<MemoryCacheOptions> optionsAccessor!!, ILoggerFactor
             _options = optionsAccessor.Value;
             _logger = loggerFactory.CreateLogger<MemoryCache>();
 
-            _coherentState = new();
+            _coherentState = new CoherentState();
 
             if (_options.Clock == null)
             {

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/LegacyPropagator.cs

@@ -165,7 +165,7 @@ internal static bool TryExtractBaggage(string baggageString, out IEnumerable<Key
 
                 if (keyStart < keyEnd && valueStart < currentIndex)
                 {
-                    baggageList ??= new();
+                    baggageList ??= new List<KeyValuePair<string, string?>>();
 
                     // Insert in reverse order for asp.net compatability.
                     baggageList.Insert(0, new KeyValuePair<string, string?>(

src/libraries/System.Drawing.Common/tests/System/Drawing/ImageAnimator.ManualTests.cs

@@ -70,7 +70,7 @@ public void AnimateAndCaptureFrames()
                     animation.Save(Path.Combine(testOutputFolder, $"{++frameIndexes[imageName]}_{timestamp}.jpg"), ImageFormat.Jpeg);
                 }));
 
-                bitmaps[imageName] = new(Helpers.GetTestBitmapPath(imageName));
+                bitmaps[imageName] = new Bitmap(Helpers.GetTestBitmapPath(imageName));
                 ImageAnimator.Animate(bitmaps[imageName], handlers[imageName]);
             }
 

src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs

@@ -139,7 +139,7 @@ internal string SubTypeComponent
         /// This will return an enumerator over a dictionary of the parameter/value pairs.
         /// </summary>
         internal Dictionary<string, string>.Enumerator ParameterValuePairs =>
-            (_parameterDictionary ??= new()).GetEnumerator();
+            (_parameterDictionary ??= new Dictionary<string, string>()).GetEnumerator();
         #endregion Internal Properties
 
         #region Internal Methods
@@ -330,7 +330,7 @@ private void ParseParameterAndValue(ReadOnlySpan<char> parameterAndValue)
                 //Get length of the parameter value
                 int parameterValueLength = GetLengthOfParameterValue(parameterAndValue, parameterStartIndex);
 
-                (_parameterDictionary ??= new()).Add(
+                (_parameterDictionary ??= new Dictionary<string, string>()).Add(
                     ValidateToken(parameterAndValue.Slice(0, equalSignIndex).ToString()),
                     ValidateQuotedStringOrToken(parameterAndValue.Slice(parameterStartIndex, parameterValueLength).ToString()));
 

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/MsQuicNativeMethods.cs

@@ -841,7 +841,7 @@ internal void SetCallbackHandler(SafeHandle handle, Delegate del, IntPtr context
                     //
                     handle.DangerousAddRef(ref handle__addRefd);
                     IntPtr __handle_gen_native = handle.DangerousGetHandle();
-                    __del_gen_native__marshaller = new(del);
+                    __del_gen_native__marshaller = new AnyDelegateMarshaller(del);
                     IntPtr __del_gen_native = __del_gen_native__marshaller.Value;
                     ((delegate* unmanaged[Cdecl]<IntPtr, IntPtr, IntPtr, void>)_functionPointer)(__handle_gen_native, __del_gen_native, context);
                 }
@@ -929,7 +929,7 @@ internal uint RegistrationOpen(ref RegistrationConfig config, out SafeMsQuicRegi
                     //
                     // Marshal
                     //
-                    __config_gen_native = new(config);
+                    __config_gen_native = new RegistrationConfig.Native(config);
                     __retVal = ((delegate* unmanaged[Cdecl]<RegistrationConfig.Native*, IntPtr*, uint>)_functionPointer)(&__config_gen_native, &__registrationContext_gen_native);
                     __invokeSucceeded = true;
                     //
@@ -1017,7 +1017,7 @@ internal uint ConfigurationLoadCredential(SafeMsQuicConfigurationHandle configur
                     //
                     configuration.DangerousAddRef(ref configuration__addRefd);
                     IntPtr __configuration_gen_native = configuration.DangerousGetHandle();
-                    __credConfig_gen_native = new(credConfig);
+                    __credConfig_gen_native = new CredentialConfig.Native(credConfig);
                     __retVal = ((delegate* unmanaged[Cdecl]<IntPtr, CredentialConfig.Native*, uint>)_functionPointer)(__configuration_gen_native, &__credConfig_gen_native);
                     //
                     // Unmarshal

src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs

@@ -44,7 +44,7 @@ public async Task ReceiveHelloWithContextTakeover()
             stream.Enqueue(0xc1, 0x07, 0xf2, 0x48, 0xcd, 0xc9, 0xc9, 0x07, 0x00);
             using WebSocket websocket = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             Memory<byte> buffer = new byte[5];
@@ -74,7 +74,7 @@ public async Task SendHelloWithContextTakeover()
             using WebSocket websocket = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             await websocket.SendAsync(Encoding.UTF8.GetBytes("Hello"), WebSocketMessageType.Text, true, CancellationToken);
@@ -95,7 +95,7 @@ public async Task SendHelloWithDisableCompression()
             using WebSocket websocket = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             byte[] bytes = Encoding.UTF8.GetBytes("Hello");
@@ -113,7 +113,7 @@ public async Task SendHelloWithEmptyFrame()
             using WebSocket websocket = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             byte[] bytes = Encoding.UTF8.GetBytes("Hello");
@@ -123,7 +123,7 @@ public async Task SendHelloWithEmptyFrame()
             using WebSocket client = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
                 IsServer = false,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             ValueWebSocketReceiveResult result = await client.ReceiveAsync(bytes.AsMemory(), CancellationToken);
@@ -141,7 +141,7 @@ public async Task ReceiveHelloWithoutContextTakeover()
             WebSocketTestStream stream = new();
             using WebSocket websocket = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientContextTakeover = false
                 }
@@ -171,7 +171,7 @@ public async Task SendHelloWithoutContextTakeover()
             using WebSocket websocket = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ServerContextTakeover = false
                 }
@@ -196,7 +196,7 @@ public async Task TwoDeflateBlocksInOneMessage()
             WebSocketTestStream stream = new();
             using WebSocket websocket = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
             // The first 3 octets(0xf2 0x48 0x05) and the least significant two
             // bits of the 4th octet(0x00) constitute one DEFLATE block with
@@ -285,14 +285,14 @@ public async Task LargeMessageSplitInMultipleFrames(int windowBits)
             using WebSocket server = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientMaxWindowBits = windowBits
                 }
             });
             using WebSocket client = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientMaxWindowBits = windowBits
                 }
@@ -466,7 +466,7 @@ public async Task SendReceiveWithDifferentWindowBits(int clientWindowBits, int s
             using WebSocket server = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
             {
                 IsServer = true,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientContextTakeover = false,
                     ClientMaxWindowBits = clientWindowBits,
@@ -476,7 +476,7 @@ public async Task SendReceiveWithDifferentWindowBits(int clientWindowBits, int s
             });
             using WebSocket client = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientContextTakeover = false,
                     ClientMaxWindowBits = clientWindowBits,
@@ -568,7 +568,7 @@ public async Task AutobahnTestCase13_3_1()
             {
                 IsServer = true,
                 KeepAliveInterval = TimeSpan.Zero,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientMaxWindowBits = 9,
                     ServerMaxWindowBits = 9
@@ -577,7 +577,7 @@ public async Task AutobahnTestCase13_3_1()
             using WebSocket client = WebSocket.CreateFromStream(stream.Remote, new WebSocketCreationOptions
             {
                 KeepAliveInterval = TimeSpan.Zero,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
                 {
                     ClientMaxWindowBits = 9,
                     ServerMaxWindowBits = 9
@@ -609,7 +609,7 @@ public async Task CompressedMessageWithEmptyLastFrame()
             {
                 IsServer = true,
                 KeepAliveInterval = TimeSpan.Zero,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             byte[] frame1 = new byte[1024];
@@ -626,7 +626,7 @@ public async Task CompressedMessageWithEmptyLastFrame()
             {
                 IsServer = false,
                 KeepAliveInterval = TimeSpan.Zero,
-                DangerousDeflateOptions = new()
+                DangerousDeflateOptions = new WebSocketDeflateOptions()
             });
 
             int messageSize = 0;

src/libraries/System.Private.CoreLib/src/System/DateTime.cs

@@ -209,7 +209,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second)
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59);
+                this = new DateTime(year, month, day, hour, minute, 59);
                 ValidateLeapSecond();
             }
         }
@@ -226,7 +226,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, kind);
+                this = new DateTime(year, month, day, hour, minute, 59, kind);
                 ValidateLeapSecond();
             }
         }
@@ -243,7 +243,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, calendar);
+                this = new DateTime(year, month, day, hour, minute, 59, calendar);
                 ValidateLeapSecond();
             }
         }
@@ -265,7 +265,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, millisecond);
+                this = new DateTime(year, month, day, hour, minute, 59, millisecond);
                 ValidateLeapSecond();
             }
         }
@@ -285,7 +285,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, millisecond, kind);
+                this = new DateTime(year, month, day, hour, minute, 59, millisecond, kind);
                 ValidateLeapSecond();
             }
         }
@@ -302,7 +302,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, millisecond, calendar);
+                this = new DateTime(year, month, day, hour, minute, 59, millisecond, calendar);
                 ValidateLeapSecond();
             }
         }
@@ -320,7 +320,7 @@ public DateTime(int year, int month, int day, int hour, int minute, int second,
             else
             {
                 // if we have a leap second, then we adjust it to 59 so that DateTime will consider it the last in the specified minute.
-                this = new(year, month, day, hour, minute, 59, millisecond, calendar, kind);
+                this = new DateTime(year, month, day, hour, minute, 59, millisecond, calendar, kind);
                 ValidateLeapSecond();
             }
         }

src/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs

@@ -389,11 +389,11 @@ private static NullableAttributeStateParser CreateParser(IList<CustomAttributeDa
                     attribute.AttributeType.Namespace == CompilerServicesNameSpace &&
                     attribute.ConstructorArguments.Count == 1)
                 {
-                    return new(attribute.ConstructorArguments[0].Value);
+                    return new NullableAttributeStateParser(attribute.ConstructorArguments[0].Value);
                 }
             }
 
-            return new(null);
+            return new NullableAttributeStateParser(null);
         }
 
         private void TryLoadGenericMetaTypeNullability(MemberInfo memberInfo, NullabilityInfo nullability)

src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Windows.cs

@@ -99,7 +99,7 @@ private static Interop.BOOL HandlerRoutine(int dwCtrlType)
                 {
                     if (token.Signal == signal)
                     {
-                        (tokens ??= new()).Add(token);
+                        (tokens ??= new List<Token>()).Add(token);
                     }
                 }
             }