Catch TcpClient ctor exceptions in FtpWebRequest.CreateConnectionAsync (#56379)

stephentoub · web-flow · commit 74246130d505 · 2021-07-27T21:50:15.000-04:00
diff --git a/src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs b/src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs
@@ -967,15 +967,11 @@ private Exception TranslateConnectException(Exception e)
 
         private async void CreateConnectionAsync()
         {
-            string hostname = _uri.Host;
-            int port = _uri.Port;
-
-            TcpClient client = new TcpClient();
-
             object result;
             try
             {
-                await client.ConnectAsync(hostname, port).ConfigureAwait(false);
+                var client = new TcpClient();
+                await client.ConnectAsync(_uri.Host, _uri.Port).ConfigureAwait(false);
                 result = new FtpControlStream(client);
             }
             catch (Exception e)

Original file line number	Diff line number	Diff line change
`@@ -967,15 +967,11 @@ private Exception TranslateConnectException(Exception e)`
`967`	`967`
`968`	`968`	`private async void CreateConnectionAsync()`
`969`	`969`	`{`
`970`		`- string hostname = _uri.Host;`
`971`		`- int port = _uri.Port;`
`972`		`-`
`973`		`- TcpClient client = new TcpClient();`
`974`		`-`
`975`	`970`	`object result;`
`976`	`971`	`try`
`977`	`972`	`{`
`978`		`- await client.ConnectAsync(hostname, port).ConfigureAwait(false);`
	`973`	`+ var client = new TcpClient();`
	`974`	`+ await client.ConnectAsync(_uri.Host, _uri.Port).ConfigureAwait(false);`
`979`	`975`	`result = new FtpControlStream(client);`
`980`	`976`	`}`
`981`	`977`	`catch (Exception e)`