Skip to content

Commit 7392372

Browse files
committed
Synthesize ilasm assembly names by default for all IL tests
1 parent 9e59acb commit 7392372

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/tests/Directory.Build.props

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,15 @@
4242
<RestorePackages>false</RestorePackages>
4343
</PropertyGroup>
4444

45+
<!-- Most IL tests do not depend on having a specific assembly name, but some of them contain
46+
hard-coded assembly name directives which are incorrect. This MSBuild property default configures ilasm
47+
to override the assembly name directive when assembling so that it matches the output dll name,
48+
which fixes a variety of failures in crossgen r2r tests (from not being able to find dlls for references).
49+
-->
50+
<PropertyGroup>
51+
<SynthesizeIlasmAssemblyName>true</SynthesizeIlasmAssemblyName>
52+
</PropertyGroup>
53+
4554
<!-- Which tests shall we build? Default: Priority 0 tests.
4655
At the command-line, the user can specify /p:CLRTestPriorityToBuild=666 (for example), and
4756
all tests with CLRTestPriority 666,..., 1 AND 0 will build.

src/tests/baseservices/Directory.Build.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@
77
<RunAnalyzers>true</RunAnalyzers>
88
<NoWarn>$(NoWarn);xUnit1013</NoWarn>
99
<EnableNETAnalyzers>false</EnableNETAnalyzers>
10-
<SynthesizeIlasmAssemblyName>true</SynthesizeIlasmAssemblyName>
1110
</PropertyGroup>
1211
</Project>

0 commit comments

Comments
 (0)