Skip to content

Commit 7301468

Browse files
jeffhandleybuyaa-n
jeffhandley
and
buyaa-n
authored
[release/6.0] Apply custom Message and Url to all [RequiresPreviewFeatures] attributes (#60456)
* Apply custom messages and urls to all generic math [RequiresPreviewFeatures] attributes * Update AvxVnni message and remove the url Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
1 parent f94d65e commit 7301468

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+2223
-2222
lines changed

‎eng/Versions.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
<!-- Code analysis dependencies -->
5252
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>3.10.0</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
5353
<MicrosoftCodeAnalysisCSharpVersion>3.10.0</MicrosoftCodeAnalysisCSharpVersion>
54-
<MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-rc1.21413.4</MicrosoftCodeAnalysisNetAnalyzersVersion>
54+
<MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-rtm.21514.4</MicrosoftCodeAnalysisNetAnalyzersVersion>
5555
<!-- SDK dependencies -->
5656
<MicrosoftDotNetCompatibilityVersion>1.0.0-rc.2.21511.46</MicrosoftDotNetCompatibilityVersion>
5757
<!-- Arcade dependencies -->

‎src/libraries/System.Private.CoreLib/src/System/Byte.cs‎

Lines changed: 62 additions & 62 deletions
Large diffs are not rendered by default.

‎src/libraries/System.Private.CoreLib/src/System/Char.cs‎

Lines changed: 62 additions & 62 deletions
Large diffs are not rendered by default.

‎src/libraries/System.Private.CoreLib/src/System/DateOnly.cs‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -836,65 +836,65 @@ public string ToString(string? format, IFormatProvider? provider)
836836
// IComparisonOperators
837837
//
838838

839-
[RequiresPreviewFeatures]
839+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
840840
static bool IComparisonOperators<DateOnly, DateOnly>.operator <(DateOnly left, DateOnly right)
841841
=> left < right;
842842

843-
[RequiresPreviewFeatures]
843+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
844844
static bool IComparisonOperators<DateOnly, DateOnly>.operator <=(DateOnly left, DateOnly right)
845845
=> left <= right;
846846

847-
[RequiresPreviewFeatures]
847+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
848848
static bool IComparisonOperators<DateOnly, DateOnly>.operator >(DateOnly left, DateOnly right)
849849
=> left > right;
850850

851-
[RequiresPreviewFeatures]
851+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
852852
static bool IComparisonOperators<DateOnly, DateOnly>.operator >=(DateOnly left, DateOnly right)
853853
=> left >= right;
854854

855855
//
856856
// IEqualityOperators
857857
//
858858

859-
[RequiresPreviewFeatures]
859+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
860860
static bool IEqualityOperators<DateOnly, DateOnly>.operator ==(DateOnly left, DateOnly right)
861861
=> left == right;
862862

863-
[RequiresPreviewFeatures]
863+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
864864
static bool IEqualityOperators<DateOnly, DateOnly>.operator !=(DateOnly left, DateOnly right)
865865
=> left != right;
866866

867867
//
868868
// IMinMaxValue
869869
//
870870

871-
[RequiresPreviewFeatures]
871+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
872872
static DateOnly IMinMaxValue<DateOnly>.MinValue => MinValue;
873873

874-
[RequiresPreviewFeatures]
874+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
875875
static DateOnly IMinMaxValue<DateOnly>.MaxValue => MaxValue;
876876

877877
//
878878
// IParseable
879879
//
880880

881-
[RequiresPreviewFeatures]
881+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
882882
static DateOnly IParseable<DateOnly>.Parse(string s, IFormatProvider? provider)
883883
=> Parse(s, provider, DateTimeStyles.None);
884884

885-
[RequiresPreviewFeatures]
885+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
886886
static bool IParseable<DateOnly>.TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, out DateOnly result)
887887
=> TryParse(s, provider, DateTimeStyles.None, out result);
888888

889889
//
890890
// ISpanParseable
891891
//
892892

893-
[RequiresPreviewFeatures]
893+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
894894
static DateOnly ISpanParseable<DateOnly>.Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
895895
=> Parse(s, provider, DateTimeStyles.None);
896896

897-
[RequiresPreviewFeatures]
897+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
898898
static bool ISpanParseable<DateOnly>.TryParse(ReadOnlySpan<char> s, IFormatProvider? provider, out DateOnly result)
899899
=> TryParse(s, provider, DateTimeStyles.None, out result);
900900
#endif // FEATURE_GENERIC_MATH

‎src/libraries/System.Private.CoreLib/src/System/DateTime.cs‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,105 +1521,105 @@ internal static bool TryCreate(int year, int month, int day, int hour, int minut
15211521
// IAdditionOperators
15221522
//
15231523

1524-
[RequiresPreviewFeatures]
1524+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15251525
static DateTime IAdditionOperators<DateTime, TimeSpan, DateTime>.operator +(DateTime left, TimeSpan right)
15261526
=> left + right;
15271527

1528-
// [RequiresPreviewFeatures]
1528+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15291529
// static checked DateTime IAdditionOperators<DateTime, TimeSpan, DateTime>.operator +(DateTime left, TimeSpan right)
15301530
// => checked(left + right);
15311531

15321532
//
15331533
// IAdditiveIdentity
15341534
//
15351535

1536-
[RequiresPreviewFeatures]
1536+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15371537
static TimeSpan IAdditiveIdentity<DateTime, TimeSpan>.AdditiveIdentity
15381538
=> default;
15391539

15401540
//
15411541
// IComparisonOperators
15421542
//
15431543

1544-
[RequiresPreviewFeatures]
1544+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15451545
static bool IComparisonOperators<DateTime, DateTime>.operator <(DateTime left, DateTime right)
15461546
=> left < right;
15471547

1548-
[RequiresPreviewFeatures]
1548+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15491549
static bool IComparisonOperators<DateTime, DateTime>.operator <=(DateTime left, DateTime right)
15501550
=> left <= right;
15511551

1552-
[RequiresPreviewFeatures]
1552+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15531553
static bool IComparisonOperators<DateTime, DateTime>.operator >(DateTime left, DateTime right)
15541554
=> left > right;
15551555

1556-
[RequiresPreviewFeatures]
1556+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15571557
static bool IComparisonOperators<DateTime, DateTime>.operator >=(DateTime left, DateTime right)
15581558
=> left >= right;
15591559

15601560
//
15611561
// IEqualityOperators
15621562
//
15631563

1564-
[RequiresPreviewFeatures]
1564+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15651565
static bool IEqualityOperators<DateTime, DateTime>.operator ==(DateTime left, DateTime right)
15661566
=> left == right;
15671567

1568-
[RequiresPreviewFeatures]
1568+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15691569
static bool IEqualityOperators<DateTime, DateTime>.operator !=(DateTime left, DateTime right)
15701570
=> left != right;
15711571

15721572
//
15731573
// IMinMaxValue
15741574
//
15751575

1576-
[RequiresPreviewFeatures]
1576+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15771577
static DateTime IMinMaxValue<DateTime>.MinValue => MinValue;
15781578

1579-
[RequiresPreviewFeatures]
1579+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15801580
static DateTime IMinMaxValue<DateTime>.MaxValue => MaxValue;
15811581

15821582
//
15831583
// IParseable
15841584
//
15851585

1586-
[RequiresPreviewFeatures]
1586+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15871587
static DateTime IParseable<DateTime>.Parse(string s, IFormatProvider? provider)
15881588
=> Parse(s, provider);
15891589

1590-
[RequiresPreviewFeatures]
1590+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15911591
static bool IParseable<DateTime>.TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, out DateTime result)
15921592
=> TryParse(s, provider, DateTimeStyles.None, out result);
15931593

15941594
//
15951595
// ISpanParseable
15961596
//
15971597

1598-
[RequiresPreviewFeatures]
1598+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
15991599
static DateTime ISpanParseable<DateTime>.Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
16001600
=> Parse(s, provider, DateTimeStyles.None);
16011601

1602-
[RequiresPreviewFeatures]
1602+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
16031603
static bool ISpanParseable<DateTime>.TryParse(ReadOnlySpan<char> s, IFormatProvider? provider, out DateTime result)
16041604
=> TryParse(s, provider, DateTimeStyles.None, out result);
16051605

16061606
//
16071607
// ISubtractionOperators
16081608
//
16091609

1610-
[RequiresPreviewFeatures]
1610+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
16111611
static DateTime ISubtractionOperators<DateTime, TimeSpan, DateTime>.operator -(DateTime left, TimeSpan right)
16121612
=> left - right;
16131613

1614-
// [RequiresPreviewFeatures]
1614+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
16151615
// static checked DateTime ISubtractionOperators<DateTime, TimeSpan, DateTime>.operator -(DateTime left, TimeSpan right)
16161616
// => checked(left - right);
16171617

1618-
[RequiresPreviewFeatures]
1618+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
16191619
static TimeSpan ISubtractionOperators<DateTime, DateTime, TimeSpan>.operator -(DateTime left, DateTime right)
16201620
=> left - right;
16211621

1622-
// [RequiresPreviewFeatures]
1622+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
16231623
// static checked TimeSpan ISubtractionOperators<DateTime, DateTime, TimeSpan>.operator -(DateTime left, DateTime right)
16241624
// => checked(left - right);
16251625
#endif // FEATURE_GENERIC_MATH

‎src/libraries/System.Private.CoreLib/src/System/DateTimeOffset.cs‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -870,104 +870,104 @@ public static implicit operator DateTimeOffset(DateTime dateTime) =>
870870
// IAdditionOperators
871871
//
872872

873-
[RequiresPreviewFeatures]
873+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
874874
static DateTimeOffset IAdditionOperators<DateTimeOffset, TimeSpan, DateTimeOffset>.operator +(DateTimeOffset left, TimeSpan right)
875875
=> left + right;
876876

877-
// [RequiresPreviewFeatures]
877+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
878878
// static checked DateTimeOffset IAdditionOperators<DateTimeOffset, TimeSpan, DateTimeOffset>.operator +(DateTimeOffset left, TimeSpan right)
879879
// => checked(left + right);
880880

881881
//
882882
// IAdditiveIdentity
883883
//
884884

885-
[RequiresPreviewFeatures]
885+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
886886
static TimeSpan IAdditiveIdentity<DateTimeOffset, TimeSpan>.AdditiveIdentity => default;
887887

888888
//
889889
// IComparisonOperators
890890
//
891891

892-
[RequiresPreviewFeatures]
892+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
893893
static bool IComparisonOperators<DateTimeOffset, DateTimeOffset>.operator <(DateTimeOffset left, DateTimeOffset right)
894894
=> left < right;
895895

896-
[RequiresPreviewFeatures]
896+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
897897
static bool IComparisonOperators<DateTimeOffset, DateTimeOffset>.operator <=(DateTimeOffset left, DateTimeOffset right)
898898
=> left <= right;
899899

900-
[RequiresPreviewFeatures]
900+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
901901
static bool IComparisonOperators<DateTimeOffset, DateTimeOffset>.operator >(DateTimeOffset left, DateTimeOffset right)
902902
=> left > right;
903903

904-
[RequiresPreviewFeatures]
904+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
905905
static bool IComparisonOperators<DateTimeOffset, DateTimeOffset>.operator >=(DateTimeOffset left, DateTimeOffset right)
906906
=> left >= right;
907907

908908
//
909909
// IEqualityOperators
910910
//
911911

912-
[RequiresPreviewFeatures]
912+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
913913
static bool IEqualityOperators<DateTimeOffset, DateTimeOffset>.operator ==(DateTimeOffset left, DateTimeOffset right)
914914
=> left == right;
915915

916-
[RequiresPreviewFeatures]
916+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
917917
static bool IEqualityOperators<DateTimeOffset, DateTimeOffset>.operator !=(DateTimeOffset left, DateTimeOffset right)
918918
=> left != right;
919919

920920
//
921921
// IMinMaxValue
922922
//
923923

924-
[RequiresPreviewFeatures]
924+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
925925
static DateTimeOffset IMinMaxValue<DateTimeOffset>.MinValue => MinValue;
926926

927-
[RequiresPreviewFeatures]
927+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
928928
static DateTimeOffset IMinMaxValue<DateTimeOffset>.MaxValue => MaxValue;
929929

930930
//
931931
// IParseable
932932
//
933933

934-
[RequiresPreviewFeatures]
934+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
935935
static DateTimeOffset IParseable<DateTimeOffset>.Parse(string s, IFormatProvider? provider)
936936
=> Parse(s, provider);
937937

938-
[RequiresPreviewFeatures]
938+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
939939
static bool IParseable<DateTimeOffset>.TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, out DateTimeOffset result)
940940
=> TryParse(s, provider, DateTimeStyles.None, out result);
941941

942942
//
943943
// ISpanParseable
944944
//
945945

946-
[RequiresPreviewFeatures]
946+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
947947
static DateTimeOffset ISpanParseable<DateTimeOffset>.Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
948948
=> Parse(s, provider, DateTimeStyles.None);
949949

950-
[RequiresPreviewFeatures]
950+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
951951
static bool ISpanParseable<DateTimeOffset>.TryParse(ReadOnlySpan<char> s, IFormatProvider? provider, out DateTimeOffset result)
952952
=> TryParse(s, provider, DateTimeStyles.None, out result);
953953

954954
//
955955
// ISubtractionOperators
956956
//
957957

958-
[RequiresPreviewFeatures]
958+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
959959
static DateTimeOffset ISubtractionOperators<DateTimeOffset, TimeSpan, DateTimeOffset>.operator -(DateTimeOffset left, TimeSpan right)
960960
=> left - right;
961961

962-
// [RequiresPreviewFeatures]
962+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
963963
// static checked DateTimeOffset ISubtractionOperators<DateTimeOffset, TimeSpan, DateTimeOffset>.operator -(DateTimeOffset left, TimeSpan right)
964964
// => checked(left - right);
965965

966-
[RequiresPreviewFeatures]
966+
[RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
967967
static TimeSpan ISubtractionOperators<DateTimeOffset, DateTimeOffset, TimeSpan>.operator -(DateTimeOffset left, DateTimeOffset right)
968968
=> left - right;
969969

970-
// [RequiresPreviewFeatures]
970+
// [RequiresPreviewFeatures(Number.PreviewFeatureMessage, Url = Number.PreviewFeatureUrl)]
971971
// static checked TimeSpan ISubtractionOperators<DateTimeOffset, DateTimeOffset, TimeSpan>.operator -(DateTimeOffset left, DateTimeOffset right)
972972
// => checked(left - right);
973973
#endif // FEATURE_GENERIC_MATH

0 commit comments

Comments
 (0)