Mark debugger tests as ConditionalFact to skip on NativeAOT (#121152)

Copilot · web-flow · commit 7201a39b318e · 2025-10-29T07:01:39.000+01:00
Five debugger-related tests added in #121054 fail in NativeAOT outerloop runs where DebuggerDisplay/DebuggerTypeProxy attributes are unsupported.
diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs b/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs
@@ -2549,7 +2549,7 @@ public void OnError(Exception error) { }
 
         private const int MaxClockErrorMSec = 20;
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void TestActivityDebuggerDisplay()
         {
             Activity activity = new Activity("TestOperation");
@@ -2562,7 +2562,7 @@ public void TestActivityDebuggerDisplay()
             activity.Stop();
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void TestActivityDebuggerProxy()
         {
             Activity activity = new Activity("TestOperation");
@@ -2577,7 +2577,7 @@ public void TestActivityDebuggerProxy()
             activity.Stop();
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void TestActivityContextDebuggerDisplay()
         {
             ActivityTraceId traceId = ActivityTraceId.CreateRandom();
@@ -2588,7 +2588,7 @@ public void TestActivityContextDebuggerDisplay()
             Assert.NotNull(debuggerDisplay);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void TestActivityLinkDebuggerDisplay()
         {
             ActivityTraceId traceId = ActivityTraceId.CreateRandom();
@@ -2599,7 +2599,7 @@ public void TestActivityLinkDebuggerDisplay()
             DebuggerAttributes.ValidateDebuggerDisplayReferences(link);
         }
 
-        [Fact]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]
         public void TestActivityEventDebuggerDisplay()
         {
             ActivityEvent activityEvent = new ActivityEvent("TestEvent");

Original file line number	Diff line number	Diff line change
`@@ -2549,7 +2549,7 @@ public void OnError(Exception error) { }`
`2549`	`2549`
`2550`	`2550`	`private const int MaxClockErrorMSec = 20;`
`2551`	`2551`
`2552`		`- [Fact]`
	`2552`	`+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]`
`2553`	`2553`	`public void TestActivityDebuggerDisplay()`
`2554`	`2554`	`{`
`2555`	`2555`	`Activity activity = new Activity("TestOperation");`
`@@ -2562,7 +2562,7 @@ public void TestActivityDebuggerDisplay()`
`2562`	`2562`	`activity.Stop();`
`2563`	`2563`	`}`
`2564`	`2564`
`2565`		`- [Fact]`
	`2565`	`+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]`
`2566`	`2566`	`public void TestActivityDebuggerProxy()`
`2567`	`2567`	`{`
`2568`	`2568`	`Activity activity = new Activity("TestOperation");`
`@@ -2577,7 +2577,7 @@ public void TestActivityDebuggerProxy()`
`2577`	`2577`	`activity.Stop();`
`2578`	`2578`	`}`
`2579`	`2579`
`2580`		`- [Fact]`
	`2580`	`+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]`
`2581`	`2581`	`public void TestActivityContextDebuggerDisplay()`
`2582`	`2582`	`{`
`2583`	`2583`	`ActivityTraceId traceId = ActivityTraceId.CreateRandom();`
`@@ -2588,7 +2588,7 @@ public void TestActivityContextDebuggerDisplay()`
`2588`	`2588`	`Assert.NotNull(debuggerDisplay);`
`2589`	`2589`	`}`
`2590`	`2590`
`2591`		`- [Fact]`
	`2591`	`+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]`
`2592`	`2592`	`public void TestActivityLinkDebuggerDisplay()`
`2593`	`2593`	`{`
`2594`	`2594`	`ActivityTraceId traceId = ActivityTraceId.CreateRandom();`
`@@ -2599,7 +2599,7 @@ public void TestActivityLinkDebuggerDisplay()`
`2599`	`2599`	`DebuggerAttributes.ValidateDebuggerDisplayReferences(link);`
`2600`	`2600`	`}`
`2601`	`2601`
`2602`		`- [Fact]`
	`2602`	`+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]`
`2603`	`2603`	`public void TestActivityEventDebuggerDisplay()`
`2604`	`2604`	`{`
`2605`	`2605`	`ActivityEvent activityEvent = new ActivityEvent("TestEvent");`