Ensure tests properly handle ref readonly changes

Author: tannergooding

src/libraries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionary.Generic.Tests.cs

@@ -114,13 +114,13 @@ static T AssertNotNull<T>(T value, [CallerArgumentExpression(nameof(value))] str
                     uint hash1 = (5381 << 16) + 5381;
                     uint hash2 = BitOperations.RotateLeft(hash1, 5) + hash1;
 
-                    MemoryMarshal.Write(asBytes, ref seed);
-                    MemoryMarshal.Write(asBytes.Slice(4), ref hash2); // set hash2 := 0 (for Ordinal)
+                    MemoryMarshal.Write(asBytes, in seed);
+                    MemoryMarshal.Write(asBytes.Slice(4), in hash2); // set hash2 := 0 (for Ordinal)
 
                     hash1 = (BitOperations.RotateLeft(hash1, 5) + hash1) ^ (uint)seed;
                     hash1 = (BitOperations.RotateLeft(hash1, 5) + hash1);
 
-                    MemoryMarshal.Write(asBytes.Slice(8), ref hash1); // set hash1 := 0 (for Ordinal)
+                    MemoryMarshal.Write(asBytes.Slice(8), in hash1); // set hash1 := 0 (for Ordinal)
                 });
 
                 int ordinalHashCode = nonRandomizedOrdinal(candidate);

src/libraries/System.Collections.Immutable/tests/ImmutableArrayBuilderTest.cs

@@ -199,7 +199,7 @@ public void AddRangeDerivedSpan(string[] builderElements, string[] rangeElements
 
             // AddRange
             builder.AddRange(new ReadOnlySpan<string>(rangeElements));
-            
+
             // Assert
             Assert.Equal(expectedResult, builder);
         }
@@ -214,7 +214,7 @@ public void AddRangeDerivedImmutableArray(string[] builderElements, string[] ran
 
             // AddRange
             builder.AddRange(rangeElements.ToImmutableArray());
-            
+
             // Assert
             Assert.Equal(expectedResult, builder);
         }
@@ -226,7 +226,7 @@ public void AddRangeDerivedBuilder(string[] builderElements, string[] rangeEleme
             // Initialize builder
             var builderBase = new ImmutableArray<object>.Builder();
             builderBase.AddRange(builderElements);
-            
+
             // Prepare another builder to add
             var builder = new ImmutableArray<string>.Builder();
             builder.AddRange(rangeElements);
@@ -1108,7 +1108,7 @@ public void ItemRef()
             builder.Add(3);
 
             ref readonly int safeRef = ref builder.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, builder.ItemRef(1));
 

src/libraries/System.Collections.Immutable/tests/ImmutableArrayTest.cs

@@ -2552,7 +2552,7 @@ public void ItemRef()
             var array = new[] { 1, 2, 3 }.ToImmutableArray();
 
             ref readonly int safeRef = ref array.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, array.ItemRef(1));
 

src/libraries/System.Collections.Immutable/tests/ImmutableListBuilderTest.cs

@@ -228,7 +228,7 @@ public void RemoveRange()
 
             mutable.RemoveRange(new double[] { 2.4, 3.6 });
             Assert.Equal(new[] { 1.5, 4.7 }, mutable);
-            
+
             var absComparer = new DelegateEqualityComparer<double>(equals: (x, y) => Math.Abs(x) == Math.Abs(y));
             mutable.RemoveRange(new double[] { -1.5 }, absComparer);
             Assert.Equal(new[] { 4.7 }, mutable);
@@ -431,7 +431,7 @@ public void ItemRef()
             var builder = new ImmutableList<int>.Builder(list);
 
             ref readonly int safeRef = ref builder.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, builder.ItemRef(1));
 

src/libraries/System.Collections.Immutable/tests/ImmutableListTest.cs

@@ -820,7 +820,7 @@ public void ItemRef()
             ImmutableList<int> list = new[] { 1, 2, 3 }.ToImmutableList();
 
             ref readonly int safeRef = ref list.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, list.ItemRef(1));
 

src/libraries/System.Collections.Immutable/tests/ImmutableQueueTest.cs

@@ -268,7 +268,7 @@ public void PeekRef()
                 .Enqueue(3);
 
             ref readonly int safeRef = ref queue.PeekRef();
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(1, queue.PeekRef());
 

src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryBuilderTest.cs

@@ -286,7 +286,7 @@ public void ValueRef()
             }.ToImmutableSortedDictionary().ToBuilder();
 
             ref readonly int safeRef = ref builder.ValueRef("a");
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(1, builder.ValueRef("a"));
 

src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryTest.cs

@@ -434,7 +434,7 @@ public void ValueRef()
             }.ToImmutableSortedDictionary();
 
             ref readonly int safeRef = ref dictionary.ValueRef("a");
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(1, dictionary.ValueRef("a"));
 

src/libraries/System.Collections.Immutable/tests/ImmutableSortedSetBuilderTest.nonnetstandard.cs

@@ -19,7 +19,7 @@ public void ItemRef()
             var builder = new ImmutableSortedSet<int>.Builder(array);
 
             ref readonly int safeRef = ref builder.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, builder.ItemRef(1));
 

src/libraries/System.Collections.Immutable/tests/ImmutableSortedSetTest.cs

@@ -410,7 +410,7 @@ public void ItemRef()
             var array = new[] { 1, 2, 3 }.ToImmutableSortedSet();
 
             ref readonly int safeRef = ref array.ItemRef(1);
-            ref int unsafeRef = ref Unsafe.AsRef(safeRef);
+            ref int unsafeRef = ref Unsafe.AsRef(in safeRef);
 
             Assert.Equal(2, array.ItemRef(1));