Enable AES encryption on Browser WASM (#70915)

* Copy RijndaelManagedTransform from reference source

Copied from https://github.com/microsoft/referencesource/blob/5697c29004a34d80acdaf5742d7e699022c64ecd/mscorlib/system/security/cryptography/rijndaelmanagedtransform.cs

* Format document

* Clean up RijndaelManagedTransform

1. Add copyright
2. Remove unnecessary attributes
3. Mark class as internal
4. Remove FEATURE_CRYPTO define. Only support CipherMode.CBC and PaddingMode.PKCS7.
5. Remove Contracts and replace with Debug.Assert.

* Get RijndaelManagedTransform to compile successfully.

* Make RijndaelManagedTransform implement ILiteSymmetricCipher

And hook it up to AesImplementation for Browser.

* Enable all the Aes tests on Browser.

Mark Aes APIs as supported on Browser.

* Mark all CipherModes and PaddingModes other than CBC and PKCS7 as unsupported on Browser

* Make fields readonly and rename according to code style.

* Replace RijndaelManagedTransformMode with bool encrypting.

* Throw PNSE for unsupported CipherMode and PaddingMode.

Remove unnecessary parameters and fields that aren't supported.

* Fix DecryptorReuse_LeadsToSameResults test so it works on Browser and passes for all CipherModes on other platforms

* Spanify the input buffer in RijndaelManagedTransform Transform and TransformFinal.

* First round of PR feedback

* Make _Nb constant BlockSizeInts

* Get rid of unnecessary allocations

* Remove unsafe pointers from RijndaelManagedTransform.

* PR feedback

Encrypt and Decrypt index arrays are constant values.
Use CopyTo in more places.

* Rename RijndaelManagedTransform => AesManagedTransform

* Change AesManagedTransform to no longer do padding.

Instead, reuse the UniversalCrypto infrastructure to do padding.

* Remove UnsupportedPlatform for PaddingMode

* PR feedback

- clean up unnecessary changes

* PR feedback

Remove UnsupportedOSPlatform("browser") from CipherMode and the SymmetricAlgorithm base class. These create too many false positives and aren't technically accurate since other implementations may support these on browser.

Author: eerhardt

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesCipherOneShotTests.cs

@@ -8,7 +8,6 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests
 {
     using Aes = System.Security.Cryptography.Aes;
 
-    [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
     public class AesContractTests
     {
         [Fact]
@@ -107,6 +106,7 @@ public static void InvalidKeySizes(int invalidKeySize, bool skipOnNetfx)
         [InlineData(64, false)]
         [InlineData(256, true)]
         [InlineData(127, true)]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void InvalidCFBFeedbackSizes(int feedbackSize, bool discoverableInSetter)
         {
             using (Aes aes = AesFactory.Create())
@@ -139,6 +139,7 @@ public static void InvalidCFBFeedbackSizes(int feedbackSize, bool discoverableIn
         [Theory]
         [InlineData(8)]
         [InlineData(128)]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void ValidCFBFeedbackSizes(int feedbackSize)
         {
             // Windows 7 only supports CFB8.
@@ -302,25 +303,28 @@ public static void CreateTransformExceptions()
                 Assert.Throws<CryptographicException>(() => aes.CreateDecryptor(key, null));
             }
 
-            using (Aes aes = AesFactory.Create())
+            if (PlatformDetection.IsNotBrowser)
             {
-                aes.Mode = CipherMode.ECB;
+                using (Aes aes = AesFactory.Create())
+                {
+                    aes.Mode = CipherMode.ECB;
 
-                Assert.Throws<ArgumentNullException>(() => aes.CreateEncryptor(null, iv));
-                Assert.Throws<ArgumentNullException>(() => aes.CreateEncryptor(null, null));
+                    Assert.Throws<ArgumentNullException>(() => aes.CreateEncryptor(null, iv));
+                    Assert.Throws<ArgumentNullException>(() => aes.CreateEncryptor(null, null));
 
-                Assert.Throws<ArgumentNullException>(() => aes.CreateDecryptor(null, iv));
-                Assert.Throws<ArgumentNullException>(() => aes.CreateDecryptor(null, null));
+                    Assert.Throws<ArgumentNullException>(() => aes.CreateDecryptor(null, iv));
+                    Assert.Throws<ArgumentNullException>(() => aes.CreateDecryptor(null, null));
 
-                // ECB will accept an IV (but ignore it), and doesn't require it.
-                using (ICryptoTransform didNotThrow = aes.CreateEncryptor(key, null))
-                {
-                    Assert.NotNull(didNotThrow);
-                }
+                    // ECB will accept an IV (but ignore it), and doesn't require it.
+                    using (ICryptoTransform didNotThrow = aes.CreateEncryptor(key, null))
+                    {
+                        Assert.NotNull(didNotThrow);
+                    }
 
-                using (ICryptoTransform didNotThrow = aes.CreateDecryptor(key, null))
-                {
-                    Assert.NotNull(didNotThrow);
+                    using (ICryptoTransform didNotThrow = aes.CreateDecryptor(key, null))
+                    {
+                        Assert.NotNull(didNotThrow);
+                    }
                 }
             }
         }
@@ -382,6 +386,7 @@ public static void ValidateOffsetAndCount()
         }
 
         [Fact]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void Cfb8ModeCanDepadCfb128Padding()
         {
             using (Aes aes = AesFactory.Create())

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesCipherTests.cs

@@ -12,7 +12,6 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests
 {
     using Aes = System.Security.Cryptography.Aes;
 
-    [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
     public static class AesCornerTests
     {
         [Fact]

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesContractTests.cs

@@ -7,7 +7,6 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests
 {
     using Aes = System.Security.Cryptography.Aes;
 
-    [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
     public class AesModeTests
     {
         [Fact]
@@ -17,24 +16,28 @@ public static void SupportsCBC()
         }
 
         [Fact]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.ECB is not supported on Browser")]
         public static void SupportsECB()
         {
             SupportsMode(CipherMode.ECB);
         }
 
         [Fact]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void SupportsCFB8()
         {
             SupportsMode(CipherMode.CFB, feedbackSize: 8);
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindows7))]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void SupportsCFB128()
         {
             SupportsMode(CipherMode.CFB, feedbackSize: 128);
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows7))]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public static void Windows7DoesNotSupportCFB128()
         {
             DoesNotSupportMode(CipherMode.CFB, feedbackSize: 128);

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesCornerTests.cs

@@ -7,7 +7,6 @@ namespace System.Security.Cryptography.Encryption.Aes.Tests
 {
     using Aes = System.Security.Cryptography.Aes;
 
-    [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
     public static class DecryptorReusability
     {
         // See https://github.com/dotnet/runtime/issues/21354 for details

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesModeTests.cs

@@ -410,6 +410,7 @@ public void DerivedTypesDefineTest()
         }
 
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindows7))]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public void DecryptOneShot_Cfb8_ToleratesExtraPadding()
         {
             using (SymmetricAlgorithm alg = CreateAlgorithm())
@@ -469,6 +470,7 @@ public void DecryptOneShot_Cbc_InvalidPadding_DoesNotContainPlaintext(PaddingMod
         [InlineData(PaddingMode.PKCS7, 2048)]
         [InlineData(PaddingMode.ANSIX923, 2048)]
         [InlineData(PaddingMode.ISO10126, 2048)]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.ECB is not supported on Browser")]
         public void DecryptOneShot_Ecb_InvalidPadding_DoesNotContainPlaintext(PaddingMode paddingMode, int ciphertextSize)
         {
             using (SymmetricAlgorithm alg = CreateAlgorithm())
@@ -495,6 +497,7 @@ public void DecryptOneShot_Ecb_InvalidPadding_DoesNotContainPlaintext(PaddingMod
         [InlineData(PaddingMode.PKCS7, 2048)]
         [InlineData(PaddingMode.ANSIX923, 2048)]
         [InlineData(PaddingMode.ISO10126, 2048)]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public void DecryptOneShot_Cfb_InvalidPadding_DoesNotContainPlaintext(PaddingMode paddingMode, int ciphertextSize)
         {
             using (SymmetricAlgorithm alg = CreateAlgorithm())
@@ -547,6 +550,7 @@ public void DecryptOneShot_Cbc_TooShortDoesNotContainPlaintext(PaddingMode paddi
         [InlineData(PaddingMode.PKCS7)]
         [InlineData(PaddingMode.ANSIX923)]
         [InlineData(PaddingMode.ISO10126)]
+        [SkipOnPlatform(TestPlatforms.Browser, "CipherMode.CFB is not supported on Browser")]
         public void DecryptOneShot_Cfb8_TooShortDoesNotContainPlaintext(PaddingMode paddingMode)
         {
             using (SymmetricAlgorithm alg = CreateAlgorithm())

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/DecryptorReusability.cs

@@ -47,7 +47,6 @@ namespace System.Security.Cryptography
     public abstract partial class Aes : System.Security.Cryptography.SymmetricAlgorithm
     {
         protected Aes() { }
-        [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
         public static new System.Security.Cryptography.Aes Create() { throw null; }
         [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The default algorithm implementations might be removed, use strong type references like 'RSA.Create()' instead.")]
         public static new System.Security.Cryptography.Aes? Create(string algorithmName) { throw null; }
@@ -98,7 +97,6 @@ public override void GenerateKey() { }
     [System.ObsoleteAttribute("Derived cryptographic types are obsolete. Use the Create method on the base type instead.", DiagnosticId="SYSLIB0021", UrlFormat="https://aka.ms/dotnet-warnings/{0}")]
     public sealed partial class AesCryptoServiceProvider : System.Security.Cryptography.Aes
     {
-        [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
         public AesCryptoServiceProvider() { }
         public override int BlockSize { get { throw null; } set { } }
         public override int FeedbackSize { get { throw null; } set { } }
@@ -135,7 +133,6 @@ public void Encrypt(byte[] nonce, byte[] plaintext, byte[] ciphertext, byte[] ta
     }
     [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
     [System.ObsoleteAttribute("Derived cryptographic types are obsolete. Use the Create method on the base type instead.", DiagnosticId="SYSLIB0021", UrlFormat="https://aka.ms/dotnet-warnings/{0}")]
-    [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
     public sealed partial class AesManaged : System.Security.Cryptography.Aes
     {
         public AesManaged() { }
@@ -1747,14 +1744,12 @@ public override void Reset() { }
     public abstract partial class Rijndael : System.Security.Cryptography.SymmetricAlgorithm
     {
         protected Rijndael() { }
-        [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
         public static new System.Security.Cryptography.Rijndael Create() { throw null; }
         [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The default algorithm implementations might be removed, use strong type references like 'RSA.Create()' instead.")]
         public static new System.Security.Cryptography.Rijndael? Create(string algName) { throw null; }
     }
     [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
     [System.ObsoleteAttribute("The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.", DiagnosticId="SYSLIB0022", UrlFormat="https://aka.ms/dotnet-warnings/{0}")]
-    [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
     public sealed partial class RijndaelManaged : System.Security.Cryptography.Rijndael
     {
         public RijndaelManaged() { }

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/Symmetric/SymmetricOneShotBase.cs

@@ -753,4 +753,7 @@
   <data name="Unknown_Error" xml:space="preserve">
     <value>Unknown error.</value>
   </data>
+  <data name="PlatformNotSupported_CipherModeBrowser" xml:space="preserve">
+    <value>Only CipherMode.CBC is supported on this platform.</value>
+  </data>
 </root>

src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs

@@ -547,7 +547,8 @@
              Link="Common\Interop\Browser\System.Security.Cryptography.Native.Browser\Interop.Sign.cs" /> 
     <Compile Include="System\Security\Cryptography\AesCcm.NotSupported.cs" />
     <Compile Include="System\Security\Cryptography\AesGcm.NotSupported.cs" />
-    <Compile Include="System\Security\Cryptography\AesImplementation.NotSupported.cs" />
+    <Compile Include="System\Security\Cryptography\AesImplementation.Browser.cs" />
+    <Compile Include="System\Security\Cryptography\AesManagedTransform.Browser.cs" />
     <Compile Include="System\Security\Cryptography\AsnFormatter.Managed.cs" />
     <Compile Include="System\Security\Cryptography\CapiHelper.Browser.cs" />
     <Compile Include="System\Security\Cryptography\ChaCha20Poly1305.NotSupported.cs" />