Fix invalid user info processing (#91106)

* fix(#88265): Fix invalid user info processing.

* fix(#88265): Fix failed test.

* feature(#88265): Adding additional test case.

* fix(#88265): Fix invalid code style.

---------

Co-authored-by: Maksim Golev <mgolev@htc-cs.ru>

Author: Maximys

src/libraries/System.Private.Uri/src/System/UriExt.cs

@@ -866,6 +866,11 @@ public bool IsBaseOf(Uri uri)
 
         internal bool IsBaseOfHelper(Uri uriLink)
         {
+            const UriComponents ComponentsToCompare =
+                UriComponents.AbsoluteUri
+                & ~UriComponents.Fragment
+                & ~UriComponents.UserInfo;
+
             if (!IsAbsoluteUri || UserDrivenParsing)
                 return false;
 
@@ -892,8 +897,8 @@ internal bool IsBaseOfHelper(Uri uriLink)
                 return false;
 
             // Canonicalize and test for substring match up to the last path slash
-            string self = GetParts(UriComponents.AbsoluteUri & ~UriComponents.Fragment, UriFormat.SafeUnescaped);
-            string other = uriLink.GetParts(UriComponents.AbsoluteUri & ~UriComponents.Fragment, UriFormat.SafeUnescaped);
+            string self = GetParts(ComponentsToCompare, UriFormat.SafeUnescaped);
+            string other = uriLink.GetParts(ComponentsToCompare, UriFormat.SafeUnescaped);
 
             unsafe
             {

src/libraries/System.Private.Uri/tests/FunctionalTests/UriParserTest.cs

@@ -272,10 +272,9 @@ public static void IsBaseOf()
             Assert.False(parser.IsBaseOf(u, http), "http-4a");
             Assert.True(parser.IsBaseOf(http, u), "http-4b");
 
-            // docs says the UserInfo isn't evaluated, but...
             u = new Uri("http://username:password@www.mono-project.com/Main_Page");
-            Assert.False(parser.IsBaseOf(u, http), "http-5a");
-            Assert.False(parser.IsBaseOf(http, u), "http-5b");
+            Assert.True(parser.IsBaseOf(u, http), "http-5a");
+            Assert.True(parser.IsBaseOf(http, u), "http-5b");
 
             // scheme case sensitive ? no
             u = new Uri("HTTP://www.mono-project.com/Main_Page");

src/libraries/System.Runtime/tests/System/Uri.MethodsTests.cs

@@ -196,6 +196,11 @@ public static IEnumerable<object[]> IsBaseOfTestData()
             yield return new object[] { new Uri("file://C:/path/path/file"), new Uri("file://D:/path/path/path"), false };
             yield return new object[] { new Uri("file://C:/path/path/file"), new Uri("http://host/path/path/file"), false };
             yield return new object[] { new Uri("file://C:/path/path/file"), new Uri("path/path/file", UriKind.Relative), true };
+
+            yield return new object[] { new Uri("https://user@domain.com"), new Uri("https://domain.com"), true };
+            yield return new object[] { new Uri("https://user@domain.com"), new Uri("http://domain.com"), false };
+            yield return new object[] { new Uri("https://user1@domain.com"), new Uri("https://user2@domain.com"), true };
+            yield return new object[] { new Uri("https://domain.com"), new Uri("https://user@domain.com"), true };
         }
 
         [Theory]