Comment cleanup

Author: kg

src/coreclr/gcinfo/arraylist.cpp

@@ -1,7 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-// FIXME: We have to put this up here because of some sort of interaction between precompiled headers
+// Interpreter-FIXME: We have to put this up here because of some sort of interaction between precompiled headers
 //  and an indirect dependency on safemath.h before the #include "safemath.h" further down - that one isn't including it
 #undef _ASSERTE_SAFEMATH
 #define _ASSERTE_SAFEMATH(expr) GCINFO_ASSERT(expr)

src/coreclr/gcinfo/gcinfoencoder.cpp

@@ -845,7 +845,7 @@ struct CompareLifetimeTransitionsBySlot
         UINT32 firstOffset  = first.CodeOffset;
         UINT32 secondOffset = second.CodeOffset;
 
-        // FIXME: GcInfoEncoding::
+        // Interpreter-FIXME: GcInfoEncoding::
         // GCINFO_ASSERT(GetNormCodeOffsetChunk(firstOffset) == GetNormCodeOffsetChunk(secondOffset));
 
         // Sort them by slot
@@ -2551,7 +2551,7 @@ void BitStreamWriter::CopyTo( BYTE* buffer )
 
 inline void BitStreamWriter::AllocMemoryBlock()
 {
-    // FIXME: Causes linker error in interpreter because IS_ALIGNED calls _ASSERTE
+    // Interpreter-FIXME: Causes linker error in interpreter because IS_ALIGNED calls _ASSERTE
     // GCINFO_ASSERT( IS_ALIGNED( m_MemoryBlockSize, sizeof( size_t ) ) );
     MemoryBlock* pMemBlock = m_MemoryBlocks.AppendNew(m_pAllocator, m_MemoryBlockSize);
 

src/coreclr/inc/gcinfotypes.h

@@ -975,20 +975,20 @@ struct InterpreterGcInfoEncoding {
     static const uint32_t NUM_NORM_CODE_OFFSETS_PER_CHUNK = (64);
 
     static const uint32_t NUM_NORM_CODE_OFFSETS_PER_CHUNK_LOG2 = (6);
-    // FIXME: Interpreter has fixed-size stack slots so we could normalize them based on that.
+    // Interpreter-FIXME: Interpreter has fixed-size stack slots so we could normalize them based on that.
     static inline constexpr int32_t NORMALIZE_STACK_SLOT (int32_t x) { return (x); }
     static inline constexpr int32_t DENORMALIZE_STACK_SLOT (int32_t x) { return (x); }
-    // FIXME: Interpreter has fixed-size opcodes so code length is a multiple of that.
+    // Interpreter-FIXME: Interpreter has fixed-size opcodes so code length is a multiple of that.
     static inline constexpr uint32_t NORMALIZE_CODE_LENGTH (uint32_t x) { return (x); }
     static inline constexpr uint32_t DENORMALIZE_CODE_LENGTH (uint32_t x) { return (x); }
 
     static inline constexpr uint32_t NORMALIZE_STACK_BASE_REGISTER (uint32_t x) { return (x); }
     static inline constexpr uint32_t DENORMALIZE_STACK_BASE_REGISTER (uint32_t x) { return (x); }
-    // FIXME: Interpreter has fixed-size stack slots so we could normalize them based on that.
+    // Interpreter-FIXME: Interpreter has fixed-size stack slots so we could normalize them based on that.
     static inline constexpr uint32_t NORMALIZE_SIZE_OF_STACK_AREA (uint32_t x) { return (x); }
     static inline constexpr uint32_t DENORMALIZE_SIZE_OF_STACK_AREA (uint32_t x) { return (x); }
     static const bool CODE_OFFSETS_NEED_NORMALIZATION = false;
-    // FIXME: Interpreter has fixed-size opcodes so code length is a multiple of that.
+    // Interpreter-FIXME: Interpreter has fixed-size opcodes so code length is a multiple of that.
     static inline constexpr uint32_t NORMALIZE_CODE_OFFSET (uint32_t x) { return (x); }
     static inline constexpr uint32_t DENORMALIZE_CODE_OFFSET (uint32_t x) { return (x); }
 
@@ -1000,7 +1000,7 @@ struct InterpreterGcInfoEncoding {
     static const int STACK_BASE_REGISTER_ENCBASE = 3;
     static const int SIZE_OF_STACK_AREA_ENCBASE = 3;
     static const int SIZE_OF_EDIT_AND_CONTINUE_PRESERVED_AREA_ENCBASE = 4;
-    // FIXME: This constant is only used on certain architectures.
+    // Interpreter-FIXME: This constant is only used on certain architectures.
     static const int SIZE_OF_EDIT_AND_CONTINUE_FIXED_STACK_FRAME_ENCBASE = 4;
     static const int REVERSE_PINVOKE_FRAME_ENCBASE = 6;
     static const int NUM_REGISTERS_ENCBASE = 2;

src/coreclr/interpreter/compiler.cpp

@@ -70,12 +70,12 @@ class InterpIAllocator : public IAllocator
     // Frees the block of memory pointed to by p.
     virtual void Free(void* p) override
     {
-        // FIXME: m_pCompiler->FreeMethodData
+        // Interpreter-FIXME: m_pCompiler->FreeMethodData
         free(p);
     }
 };
 
-// FIXME Use specific allocators for their intended purpose
+// Interpreter-FIXME Use specific allocators for their intended purpose
 // Allocator for data that is kept alive throughout application execution,
 // being freed only if the associated method gets freed.
 void* InterpCompiler::AllocMethodData(size_t numBytes)
@@ -744,7 +744,7 @@ void InterpCompiler::BuildGCInfo(InterpMethod *pInterpMethod)
     // let's save the values anyway for debugging purposes
     gcInfoEncoder->Emit();
 
-    // FIXME: Why doesn't the JIT code do this? Is it because the placement new it uses automatically frees them
+    // Interpreter-FIXME: Why doesn't the JIT code do this? Is it because the placement new it uses automatically frees them
     //  at the end of JIT compilation?
     delete gcInfoEncoder;
     delete pAllocator;

src/coreclr/vm/interpexec.cpp

@@ -755,8 +755,8 @@ void InterpExecMethod(InterpreterFrame *pInterpreterFrame, InterpMethodContextFr
                 break;
             }
             case INTOP_COLLECT: {
-                // HACK: blocking gc of all generations
-                // FIXME: currently hangs and stack walk does not ever reach the interpreter code manager
+                // HACK: blocking gc of all generations to enable early stackwalk testing
+                // Interpreter-TODO: Remove this
                 InterpreterExitFrame exitFrame(pFrame);
                 {
                     GCX_COOP();