Disable matching constants for vectors that needs upper half to be save/restore (#74110)

kunalspathak · web-flow · commit 64d27bb1bd85 · 2022-08-18T15:30:42.000-07:00
* Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)" This reverts commit 24f5de4. * Revert "Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)"" This reverts commit 984120f. * Add partial save check * Use the correct register type
diff --git a/src/coreclr/jit/lsra.cpp b/src/coreclr/jit/lsra.cpp
@@ -2721,7 +2721,11 @@ bool LinearScan::isMatchingConstant(RegRecord* physRegRecord, RefPosition* refPo
 
         case GT_CNS_VEC:
         {
-            return GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());
+            return
+#if FEATURE_PARTIAL_SIMD_CALLEE_SAVE
+                !Compiler::varTypeNeedsPartialCalleeSave(physRegRecord->assignedInterval->registerType) &&
+#endif
+                GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());
         }
 
         default:

Original file line number	Diff line number	Diff line change
`@@ -2721,7 +2721,11 @@ bool LinearScan::isMatchingConstant(RegRecord* physRegRecord, RefPosition* refPo`
`2721`	`2721`
`2722`	`2722`	`case GT_CNS_VEC:`
`2723`	`2723`	`{`
`2724`		`- return GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());`
	`2724`	`+ return`
	`2725`	`+#if FEATURE_PARTIAL_SIMD_CALLEE_SAVE`
	`2726`	`+ !Compiler::varTypeNeedsPartialCalleeSave(physRegRecord->assignedInterval->registerType) &&`
	`2727`	`+#endif`
	`2728`	`+ GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());`
`2725`	`2729`	`}`
`2726`	`2730`
`2727`	`2731`	`default:`