Do not clone empty arrays in CloneByteArray

vcsjones · web-flow · commit 63a375e04a81 · 2023-10-09T15:59:28.000-04:00
diff --git a/src/libraries/Common/src/System/Security/Cryptography/Helpers.cs b/src/libraries/Common/src/System/Security/Cryptography/Helpers.cs
@@ -45,12 +45,12 @@ internal static partial class Helpers
         [return: NotNullIfNotNull(nameof(src))]
         public static byte[]? CloneByteArray(this byte[]? src)
         {
-            if (src == null)
+            return src switch
             {
-                return null;
-            }
-
-            return (byte[])(src.Clone());
+                null => null,
+                { Length: 0 } => src,
+                _ => (byte[])src.Clone(),
+            };
         }
 
         internal static bool TryCopyToDestination(this ReadOnlySpan<byte> source, Span<byte> destination, out int bytesWritten)

Original file line number	Diff line number	Diff line change
`@@ -45,12 +45,12 @@ internal static partial class Helpers`
`45`	`45`	`[return: NotNullIfNotNull(nameof(src))]`
`46`	`46`	`public static byte[]? CloneByteArray(this byte[]? src)`
`47`	`47`	`{`
`48`		`- if (src == null)`
	`48`	`+ return src switch`
`49`	`49`	`{`
`50`		`- return null;`
`51`		`- }`
`52`		`-`
`53`		`- return (byte[])(src.Clone());`
	`50`	`+ null => null,`
	`51`	`+ { Length: 0 } => src,`
	`52`	`+ _ => (byte[])src.Clone(),`
	`53`	`+ };`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`internal static bool TryCopyToDestination(this ReadOnlySpan<byte> source, Span<byte> destination, out int bytesWritten)`