Enable CA1419 (SafeHandle public parameterless ctor) (#55460)

Author: stephentoub

eng/CodeAnalysis.ruleset

@@ -68,6 +68,7 @@
     <Rule Id="CA1416" Action="Warning" />       <!-- Validate platform compatibility -->
     <Rule Id="CA1417" Action="Warning" />       <!-- Do not use 'OutAttribute' on string parameters for P/Invokes -->
     <Rule Id="CA1418" Action="Warning" />       <!-- Use valid platform string -->
+    <Rule Id="CA1419" Action="Warning" />       <!-- Provide a public parameterless constructor for concrete types derived from 'System.Runtime.InteropServices.SafeHandle' -->
     <Rule Id="CA1501" Action="None" />          <!-- Avoid excessive inheritance -->
     <Rule Id="CA1502" Action="None" />          <!-- Avoid excessive complexity -->
     <Rule Id="CA1505" Action="None" />          <!-- Avoid unmaintainable code -->

src/libraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.Keychain.macOS.cs

@@ -401,7 +401,7 @@ internal sealed class SafeTemporaryKeychainHandle : SafeKeychainHandle
         private static readonly Dictionary<IntPtr, SafeTemporaryKeychainHandle> s_lookup =
             new Dictionary<IntPtr, SafeTemporaryKeychainHandle>();
 
-        internal SafeTemporaryKeychainHandle()
+        public SafeTemporaryKeychainHandle()
         {
         }
 

src/libraries/Common/src/Interop/Windows/HttpApi/Interop.HttpApi.cs

@@ -508,7 +508,7 @@ internal sealed class SafeLocalFreeChannelBinding : ChannelBinding
         {
             private int _size;
 
-            private SafeLocalFreeChannelBinding() { }
+            public SafeLocalFreeChannelBinding() { }
 
             public override int Size
             {

src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs

@@ -128,7 +128,7 @@ public static int SetContextAttributes(
 
     internal sealed class SafeFreeContextBuffer_SECURITY : SafeFreeContextBuffer
     {
-        internal SafeFreeContextBuffer_SECURITY() : base() { }
+        public SafeFreeContextBuffer_SECURITY() : base() { }
 
         protected override bool ReleaseHandle()
         {

src/libraries/Common/src/Microsoft/Win32/SafeHandles/Asn1SafeHandles.Unix.cs

@@ -68,15 +68,15 @@ public override bool IsInvalid
 
     internal sealed class SafeSharedAsn1IntegerHandle : SafeInteriorHandle
     {
-        private SafeSharedAsn1IntegerHandle() :
+        public SafeSharedAsn1IntegerHandle() :
             base(IntPtr.Zero, ownsHandle: true)
         {
         }
     }
 
     internal sealed class SafeSharedAsn1OctetStringHandle : SafeInteriorHandle
     {
-        private SafeSharedAsn1OctetStringHandle() :
+        public SafeSharedAsn1OctetStringHandle() :
             base(IntPtr.Zero, ownsHandle: true)
         {
         }

src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs

@@ -18,7 +18,8 @@ public override bool IsInvalid
         }
 
         protected override bool ReleaseHandle() => throw new PlatformNotSupportedException();
-        private SafeGssNameHandle()
+
+        public SafeGssNameHandle()
             : base(IntPtr.Zero, true)
         {
         }
@@ -27,7 +28,7 @@ private SafeGssNameHandle()
     [UnsupportedOSPlatform("tvos")]
     internal sealed class SafeGssCredHandle : SafeHandle
     {
-        private SafeGssCredHandle()
+        public SafeGssCredHandle()
             : base(IntPtr.Zero, true)
         {
         }
@@ -43,7 +44,7 @@ public override bool IsInvalid
     [UnsupportedOSPlatform("tvos")]
     internal sealed class SafeGssContextHandle : SafeHandle
     {
-        private SafeGssContextHandle()
+        public SafeGssContextHandle()
             : base(IntPtr.Zero, true)
         {
         }

src/libraries/Common/src/Microsoft/Win32/SafeHandles/SafeUnicodeStringHandle.cs

@@ -4,6 +4,8 @@
 using System;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace Microsoft.Win32.SafeHandles
 {
     /// <summary>

src/libraries/Common/src/System/Net/Security/SecurityContextTokenHandle.cs

@@ -16,7 +16,7 @@ internal sealed class SecurityContextTokenHandle : CriticalHandleZeroOrMinusOneI
 #endif
         private int _disposed;
 
-        private SecurityContextTokenHandle() : base()
+        public SecurityContextTokenHandle() : base()
         {
         }
 

src/libraries/Common/src/System/Net/Security/Unix/SafeDeleteNegoContext.cs

@@ -7,6 +7,8 @@
 using System.Text;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeDeleteNegoContext : SafeDeleteContext

src/libraries/Common/src/System/Net/Security/Unix/SafeDeleteSslContext.cs

@@ -11,6 +11,8 @@
 using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeDeleteSslContext : SafeDeleteContext

src/libraries/Common/src/System/Net/Security/Unix/SafeFreeCertContext.cs

@@ -8,6 +8,8 @@
 using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
 #if DEBUG

src/libraries/Common/src/System/Net/Security/Unix/SafeFreeNegoCredentials.cs

@@ -7,6 +7,8 @@
 using System.Text;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeFreeNegoCredentials : SafeFreeCredentials

src/libraries/Common/src/System/Net/Security/Unix/SafeFreeSslCredentials.cs

@@ -10,6 +10,8 @@
 using System.Security.Cryptography;
 using System.Security.Cryptography.X509Certificates;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeFreeSslCredentials : SafeFreeCredentials

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionHandle.cs

@@ -6,6 +6,8 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.ConstrainedExecution;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.Odbc
 {
     internal sealed class OdbcConnectionHandle : OdbcHandle

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcHandle.cs

@@ -7,6 +7,8 @@
 using System.Runtime.InteropServices;
 using System.Text;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.Odbc
 {
     internal abstract class OdbcHandle : SafeHandle

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcStatementHandle.cs

@@ -4,6 +4,8 @@
 using System.Data.Common;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.Odbc
 {
     internal readonly struct SQLLEN

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcUtils.cs

@@ -6,6 +6,8 @@
 using System.Runtime.InteropServices;
 using System.Text;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.Odbc
 {
     internal sealed class CNativeBuffer : System.Data.ProviderBase.DbBuffer

src/libraries/System.Data.OleDb/src/OleDbTransaction.cs

@@ -7,6 +7,8 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     public sealed class OleDbTransaction : DbTransaction

src/libraries/System.Data.OleDb/src/OleDbWrapper.cs

@@ -7,6 +7,8 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     // SafeHandle wrapper around 'DataLinks' object which pools the native OLE DB providers.
@@ -92,7 +94,7 @@ internal sealed class DataSourceWrapper : WrappedIUnknown
         // we expect to store IDBInitialize instance pointer in base.handle
 
         // construct a DataSourceWrapper and used as a ref parameter to GetDataSource
-        internal DataSourceWrapper() : base()
+        public DataSourceWrapper() : base()
         {
         }
 
@@ -229,7 +231,7 @@ internal sealed class SessionWrapper : WrappedIUnknown
         // since we maintain an AddRef on IDBCreateCommand it is safe to use the delegate without rechecking its function pointer
         private UnsafeNativeMethods.IDBCreateCommandCreateCommand? DangerousIDBCreateCommandCreateCommand;
 
-        internal SessionWrapper() : base()
+        public SessionWrapper() : base()
         {
         }
 

src/libraries/System.Data.OleDb/src/PropertyIDSet.cs

@@ -5,6 +5,8 @@
 using System.Data.ProviderBase;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     internal sealed class PropertyIDSet : DbBuffer

src/libraries/System.Data.OleDb/src/PropertyInfoSet.cs

@@ -7,6 +7,8 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     internal sealed class OleDbPropertyInfo

src/libraries/System.Data.OleDb/src/RowBinding.cs

@@ -6,6 +6,8 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     internal sealed class RowBinding : System.Data.ProviderBase.DbBuffer

src/libraries/System.Data.OleDb/src/SafeHandles.cs

@@ -9,6 +9,8 @@
 using System.Runtime.Versioning;
 using static System.Data.Common.UnsafeNativeMethods;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Data.OleDb
 {
     internal sealed class DualCoTaskMem : SafeHandle

src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPool.cs

@@ -233,7 +233,7 @@ private sealed class PoolWaitHandles : DbBuffer
 
             private readonly int _releaseFlags;
 
-            internal PoolWaitHandles() : base(3 * IntPtr.Size)
+            public PoolWaitHandles() : base(3 * IntPtr.Size)
             {
                 bool mustRelease1 = false, mustRelease2 = false, mustRelease3 = false;
 

src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthZSet.cs

@@ -566,8 +566,9 @@ public override void Dispose()
         //
         private sealed class SafeMemoryPtr : SafeHandle
         {
-            private SafeMemoryPtr() : base(IntPtr.Zero, true)
-            { }
+            public SafeMemoryPtr() : base(IntPtr.Zero, true)
+            {
+            }
 
             internal SafeMemoryPtr(IntPtr handle) : base(IntPtr.Zero, true)
             {

src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/Interop/SafeHandles.cs

@@ -4,6 +4,8 @@
 using System.Runtime.InteropServices;
 using Microsoft.Win32.SafeHandles;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.DirectoryServices.Protocols
 {
     internal sealed class HGlobalMemHandle : SafeHandleZeroOrMinusOneIsInvalid

src/libraries/System.Drawing.Common/src/System/Drawing/Drawing2D/SafeCustomLineCapHandle.cs

@@ -11,6 +11,10 @@ namespace System.Drawing.Drawing2D
 {
     internal sealed class SafeCustomLineCapHandle : SafeHandle
     {
+        public SafeCustomLineCapHandle() : base(IntPtr.Zero, true)
+        {
+        }
+
         // Create a SafeHandle, informing the base class
         // that this SafeHandle instance "owns" the handle,
         // and therefore SafeHandle should call

src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpChannelBinding.cs

@@ -5,9 +5,10 @@
 using System.Runtime.InteropServices;
 using System.Security.Authentication.ExtendedProtection;
 using System.Text;
-
 using SafeWinHttpHandle = Interop.WinHttp.SafeWinHttpHandle;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Http
 {
     internal sealed class WinHttpChannelBinding : ChannelBinding

src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpServerSessionHandle.cs

@@ -4,6 +4,8 @@
 using Microsoft.Win32.SafeHandles;
 using System.Threading;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net
 {
     //

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/MsQuicApi.cs

@@ -16,11 +16,11 @@ internal unsafe sealed class MsQuicApi
         // This is workaround for a bug in ILTrimmer.
         // Without these DynamicDependency attributes, .ctor() will be removed from the safe handles.
         // Remove once fixed: https://github.com/mono/linker/issues/1660
-        [DynamicDependency(DynamicallyAccessedMemberTypes.NonPublicConstructors, typeof(SafeMsQuicRegistrationHandle))]
-        [DynamicDependency(DynamicallyAccessedMemberTypes.NonPublicConstructors, typeof(SafeMsQuicConfigurationHandle))]
-        [DynamicDependency(DynamicallyAccessedMemberTypes.NonPublicConstructors, typeof(SafeMsQuicListenerHandle))]
-        [DynamicDependency(DynamicallyAccessedMemberTypes.NonPublicConstructors, typeof(SafeMsQuicConnectionHandle))]
-        [DynamicDependency(DynamicallyAccessedMemberTypes.NonPublicConstructors, typeof(SafeMsQuicStreamHandle))]
+        [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(SafeMsQuicRegistrationHandle))]
+        [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(SafeMsQuicConfigurationHandle))]
+        [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(SafeMsQuicListenerHandle))]
+        [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(SafeMsQuicConnectionHandle))]
+        [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(SafeMsQuicStreamHandle))]
         private MsQuicApi(NativeApi* vtable)
         {
             uint status;

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicConfigurationHandle.cs

@@ -21,7 +21,7 @@ internal sealed class SafeMsQuicConfigurationHandle : SafeHandle
 
         public override bool IsInvalid => handle == IntPtr.Zero;
 
-        private SafeMsQuicConfigurationHandle()
+        public SafeMsQuicConfigurationHandle()
             : base(IntPtr.Zero, ownsHandle: true)
         { }
 

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicConnectionHandle.cs

@@ -9,7 +9,7 @@ internal sealed class SafeMsQuicConnectionHandle : SafeHandle
     {
         public override bool IsInvalid => handle == IntPtr.Zero;
 
-        private SafeMsQuicConnectionHandle()
+        public SafeMsQuicConnectionHandle()
             : base(IntPtr.Zero, ownsHandle: true)
         { }
 

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicListenerHandle.cs

@@ -9,7 +9,7 @@ internal sealed class SafeMsQuicListenerHandle : SafeHandle
     {
         public override bool IsInvalid => handle == IntPtr.Zero;
 
-        private SafeMsQuicListenerHandle()
+        public SafeMsQuicListenerHandle()
             : base(IntPtr.Zero, ownsHandle: true)
         { }
 

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicRegistrationHandle.cs

@@ -9,7 +9,7 @@ internal sealed class SafeMsQuicRegistrationHandle : SafeHandle
     {
         public override bool IsInvalid => handle == IntPtr.Zero;
 
-        private SafeMsQuicRegistrationHandle()
+        public SafeMsQuicRegistrationHandle()
             : base(IntPtr.Zero, ownsHandle: true)
         { }
 

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/SafeMsQuicStreamHandle.cs

@@ -9,7 +9,7 @@ internal sealed class SafeMsQuicStreamHandle : SafeHandle
     {
         public override bool IsInvalid => handle == IntPtr.Zero;
 
-        private SafeMsQuicStreamHandle()
+        public SafeMsQuicStreamHandle()
             : base(IntPtr.Zero, ownsHandle: true)
         { }
 

src/libraries/System.Net.Security/src/System/Net/Security/Pal.Android/SafeDeleteSslContext.cs

@@ -13,6 +13,8 @@
 using PAL_KeyAlgorithm = Interop.AndroidCrypto.PAL_KeyAlgorithm;
 using PAL_SSLStreamStatus = Interop.AndroidCrypto.PAL_SSLStreamStatus;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net
 {
     internal sealed class SafeDeleteSslContext : SafeDeleteContext

src/libraries/System.Net.Security/src/System/Net/Security/Pal.Managed/SafeChannelBindingHandle.cs

@@ -6,6 +6,8 @@
 using System.Security.Authentication.ExtendedProtection;
 using System.Text;
 
+#pragma warning disable CA1419 // TODO https://github.com/dotnet/roslyn-analyzers/issues/5232: not intended for use with P/Invoke
+
 namespace System.Net.Security
 {
     internal sealed class SafeChannelBindingHandle : ChannelBinding