Address review feedback: Update function signatures to use byte* and fix unsafe context issues

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Author: Copilot

src/libraries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Err.cs

@@ -35,7 +35,7 @@ private static unsafe string ErrErrorStringN(ulong error)
             fixed (byte* buf = &buffer[0])
             {
                 ErrErrorStringN(error, buf, buffer.Length);
-                return Utf8StringMarshaller.ConvertToManaged((byte*)buf)!;
+                return Utf8StringMarshaller.ConvertToManaged(buf)!;
             }
         }
 

src/libraries/Common/src/Interop/FreeBSD/Interop.Process.cs

@@ -118,7 +118,7 @@ public static unsafe ProcessInfo GetProcessInfoById(int pid)
                 // Get the process information for the specified pid
                 info = new ProcessInfo();
 
-                info.ProcessName = Utf8StringMarshaller.ConvertToManaged((byte*)kinfo->ki_comm)!;
+                info.ProcessName = Utf8StringMarshaller.ConvertToManaged(kinfo->ki_comm)!;
                 info.BasePriority = kinfo->ki_nice;
                 info.VirtualBytes = (long)kinfo->ki_size;
                 info.WorkingSet = kinfo->ki_rssize;

src/libraries/Common/src/Interop/OSX/Interop.CoreFoundation.CFString.cs

@@ -17,7 +17,7 @@ internal static partial class CoreFoundation
         /// If it has the wrong encoding, or if the interior pointer isn't being shared for some reason, returns NULL
         /// </summary>
         [LibraryImport(Libraries.CoreFoundationLibrary)]
-        private static partial IntPtr CFStringGetCStringPtr(
+        private static unsafe partial byte* CFStringGetCStringPtr(
             SafeCFStringHandle cfString,
             CFStringBuiltInEncodings encoding);
 
@@ -37,13 +37,13 @@ internal static string CFStringToString(SafeCFStringHandle cfString)
             // If the string is already stored internally as UTF-8 we can (usually)
             // get the raw pointer to the data blob, then we can Marshal in the string
             // via pointer semantics, avoiding a copy.
-            IntPtr interiorPointer = CFStringGetCStringPtr(
+            byte* interiorPointer = CFStringGetCStringPtr(
                 cfString,
                 CFStringBuiltInEncodings.kCFStringEncodingUTF8);
 
-            if (interiorPointer != IntPtr.Zero)
+            if (interiorPointer != null)
             {
-                return Utf8StringMarshaller.ConvertToManaged((byte*)interiorPointer)!;
+                return Utf8StringMarshaller.ConvertToManaged(interiorPointer)!;
             }
 
             SafeCFDataHandle cfData = CFStringCreateExternalRepresentation(

src/libraries/Common/src/Interop/OSX/Interop.NetworkFramework.cs

@@ -67,15 +67,15 @@ internal struct NetworkFrameworkError
         {
             public int ErrorCode;
             public int ErrorDomain;
-            public IntPtr ErrorMessage; // C string of NULL
+            public byte* ErrorMessage; // C string of NULL
         }
 
         internal static Exception CreateExceptionForNetworkFrameworkError(in NetworkFrameworkError error)
         {
             string? message = null;
             NetworkFrameworkErrorDomain domain = (NetworkFrameworkErrorDomain)error.ErrorDomain;
 
-            if (error.ErrorMessage != IntPtr.Zero)
+            if (error.ErrorMessage != null)
             {
                 message = Utf8StringMarshaller.ConvertToManaged(error.ErrorMessage);
             }

src/libraries/Common/src/Interop/Unix/System.Native/Interop.MountPoints.FormatInfo.cs

@@ -60,7 +60,7 @@ internal static unsafe Error GetFileSystemTypeNameForMountPoint(string name, out
             int result = GetFileSystemTypeNameForMountPoint(name, formatBuffer, MountPointFormatBufferSizeInBytes, &formatType);
             if (result == 0)
             {
-                format = formatType == -1 ? Utf8StringMarshaller.ConvertToManaged((byte*)formatBuffer)!
+                format = formatType == -1 ? Utf8StringMarshaller.ConvertToManaged(formatBuffer)!
                                           : (Enum.GetName(typeof(UnixFileSystemTypes), formatType) ?? "");
                 return Error.SUCCESS;
             }

src/libraries/Common/src/Interop/Unix/System.Native/Interop.MountPoints.cs

@@ -28,7 +28,7 @@ private static unsafe void AddMountPoint(void* context, byte* name)
             AllMountPointsContext* callbackContext = (AllMountPointsContext*)context;
             try
             {
-                callbackContext->_results.Add(Utf8StringMarshaller.ConvertToManaged((byte*)name)!);
+                callbackContext->_results.Add(Utf8StringMarshaller.ConvertToManaged(name)!);
             }
             catch (Exception e)
             {

src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssApiException.cs

@@ -86,7 +86,7 @@ private static string GetGssApiDisplayStatus(Status majorStatus, Status minorSta
                     Interop.NetSecurityNative.Status displayCallStatus = isMinor ?
                         DisplayMinorStatus(out minStat, status, ref displayBuffer) :
                         DisplayMajorStatus(out minStat, status, ref displayBuffer);
-                    return (Status.GSS_S_COMPLETE != displayCallStatus) ? null : Utf8StringMarshaller.ConvertToManaged((byte*)displayBuffer._data);
+                    return (Status.GSS_S_COMPLETE != displayCallStatus) ? null : Utf8StringMarshaller.ConvertToManaged(displayBuffer._data);
                 }
                 finally
                 {

src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

@@ -14,14 +14,14 @@ internal static partial class NetSecurityNative
         internal struct GssBuffer : IDisposable
         {
             internal ulong _length;
-            internal IntPtr _data;
+            internal byte* _data;
 
             internal int Copy(byte[] destination, int offset)
             {
                 Debug.Assert(destination != null, "target destination cannot be null");
                 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, $"invalid offset {offset}");
 
-                if (_data == IntPtr.Zero || _length == 0)
+                if (_data == null || _length == 0)
                 {
                     return 0;
                 }
@@ -40,7 +40,7 @@ internal int Copy(byte[] destination, int offset)
 
             internal byte[] ToByteArray()
             {
-                if (_data == IntPtr.Zero || _length == 0)
+                if (_data == null || _length == 0)
                 {
                     return Array.Empty<byte>();
                 }
@@ -51,16 +51,16 @@ internal byte[] ToByteArray()
                 return destination;
             }
 
-            internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
-                new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
+            internal unsafe ReadOnlySpan<byte> Span => (_data != null && _length != 0) ?
+                new ReadOnlySpan<byte>(_data, checked((int)_length)) :
                 default;
 
             public void Dispose()
             {
-                if (_data != IntPtr.Zero)
+                if (_data != null)
                 {
                     Interop.NetSecurityNative.ReleaseGssBuffer(_data, _length);
-                    _data = IntPtr.Zero;
+                    _data = null;
                 }
 
                 _length = 0;

src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.NetSecurityNative.cs

@@ -12,8 +12,8 @@ internal static partial class Interop
     internal static partial class NetSecurityNative
     {
         [LibraryImport(Interop.Libraries.NetSecurityNative, EntryPoint = "NetSecurityNative_ReleaseGssBuffer")]
-        internal static partial void ReleaseGssBuffer(
-            IntPtr bufferPtr,
+        internal static unsafe partial void ReleaseGssBuffer(
+            byte* bufferPtr,
             ulong length);
 
         [LibraryImport(Interop.Libraries.NetSecurityNative, EntryPoint = "NetSecurityNative_DisplayMinorStatus")]

src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.ASN1.cs

@@ -68,7 +68,7 @@ internal static unsafe string GetOidValue(IntPtr asn1ObjectPtr)
 
             if (bytesNeeded < StackCapacity)
             {
-                return Utf8StringMarshaller.ConvertToManaged(bufStack, bytesNeeded);
+                return Marshal.PtrToStringUTF8((IntPtr)bufStack, bytesNeeded);
             }
 
             // bytesNeeded does not count the \0 which will be written on the end (based on OpenSSL 1.0.1f),
@@ -94,7 +94,7 @@ internal static unsafe string GetOidValue(IntPtr asn1ObjectPtr)
                     throw new CryptographicException();
                 }
 
-                return Utf8StringMarshaller.ConvertToManaged(buf, bytesNeeded);
+                return Marshal.PtrToStringUTF8((IntPtr)buf, bytesNeeded);
             }
         }
     }