Simplify KeyAnalyzer (#88709)

IDisposable · web-flow · commit 56552c228836 · 2023-07-17T11:14:13.000-04:00
The assignment `bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;` can just be `bool canSwitchIgnoreCaseToCaseSensitive = true;` since we're just tested that value a couple lines up
diff --git a/src/libraries/System.Collections.Immutable/src/System/Collections/Frozen/String/KeyAnalyzer.cs b/src/libraries/System.Collections.Immutable/src/System/Collections/Frozen/String/KeyAnalyzer.cs
@@ -124,7 +124,7 @@ private static AnalysisResults CreateAnalysisResults(
                 // actually perform the comparison as case-sensitive even if case-insensitive
                 // was requested, as there's nothing that would compare equally to the substring
                 // other than the substring itself.
-                bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;
+                bool canSwitchIgnoreCaseToCaseSensitive = true;
 
                 foreach (string s in uniqueStrings)
                 {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ private static AnalysisResults CreateAnalysisResults(`
`124`	`124`	`// actually perform the comparison as case-sensitive even if case-insensitive`
`125`	`125`	`// was requested, as there's nothing that would compare equally to the substring`
`126`	`126`	`// other than the substring itself.`
`127`		`- bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;`
	`127`	`+ bool canSwitchIgnoreCaseToCaseSensitive = true;`
`128`	`128`
`129`	`129`	`foreach (string s in uniqueStrings)`
`130`	`130`	`{`