Skip to content

Commit 50e52e4

Browse files
Disable EventSource manifest gen tests on stress runs. (#96816)
1 parent 31fa079 commit 50e52e4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public partial class TestsManifestGeneration
3030

3131
/// ETW only works with elevated process
3232
[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
33-
[ActiveIssue("https://github.com/dotnet/runtime/issues/48798")]
33+
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
3434
public void Test_EventSource_EtwManifestGeneration()
3535
{
3636
RemoteInvokeOptions options = new RemoteInvokeOptions { TimeOut = 300_000 /* ms */ };
@@ -77,7 +77,7 @@ public void Test_EventSource_EtwManifestGeneration()
7777
}
7878

7979
[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
80-
[ActiveIssue("https://github.com/dotnet/runtime/issues/48798")]
80+
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
8181
public void Test_EventSource_EtwManifestGenerationRollover()
8282
{
8383
RemoteExecutor.Invoke(() =>

src/tests/Interop/Directory.Build.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<Target Name="CopyInteropNativeRuntimeDependencies"
1212
BeforeTargets="CopyAllNativeProjectReferenceBinaries"
1313
Condition="'$(TargetsWindows)' == 'true' And ('$(Configuration)' == 'Debug' Or '$(Configuration)' == 'Checked') And '$(CopyDebugCRTDllsToOutputDirectory)' == 'true'" >
14-
<Warning Message="Building C++/CLI tests requires a Visual Studio Dev Command Prompt" Condition="'$(VCToolsRedistDir)' == '' or '$(ExtensionSdkDir)' == ''" />
14+
<Warning Text="Building C++/CLI tests requires a Visual Studio Dev Command Prompt" Condition="'$(VCToolsRedistDir)' == '' or '$(ExtensionSdkDir)' == ''" />
1515
<!-- Required debug vcruntime and UCRT dlls -->
1616
<ItemGroup Condition="'$(VCToolsRedistDir)' != '' and '$(ExtensionSdkDir)' != ''">
1717
<InteropNativeRuntimeDependencies Include="$(VCToolsRedistDir)onecore/debug_nonredist/$(TargetArchitecture)/Microsoft.VC*.DebugCRT/vcruntime*d.dll" />

0 commit comments

Comments
 (0)