Reduce unsafe code usage in HttpHeaders (#122132)

GrabYourPitchforks · web-flow · commit 4d1048d0c3c0 · 2025-12-03T10:31:25.000Z
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs
@@ -1521,9 +1521,8 @@ private ref object GetValueRefOrNullRef(HeaderDescriptor key)
                 _count++;
                 entries = new HeaderEntry[InitialCapacity];
                 _headerStore = entries;
-                ref HeaderEntry firstEntry = ref MemoryMarshal.GetArrayDataReference(entries);
-                firstEntry.Key = key;
-                return ref firstEntry.Value!;
+                entries[0].Key = key;
+                return ref entries[0].Value!;
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -1521,9 +1521,8 @@ private ref object GetValueRefOrNullRef(HeaderDescriptor key)`
`1521`	`1521`	`_count++;`
`1522`	`1522`	`entries = new HeaderEntry[InitialCapacity];`
`1523`	`1523`	`_headerStore = entries;`
`1524`		`- ref HeaderEntry firstEntry = ref MemoryMarshal.GetArrayDataReference(entries);`
`1525`		`- firstEntry.Key = key;`
`1526`		`- return ref firstEntry.Value!;`
	`1524`	`+ entries[0].Key = key;`
	`1525`	`+ return ref entries[0].Value!;`
`1527`	`1526`	`}`
`1528`	`1527`	`else`
`1529`	`1528`	`{`