Fix issue when logging stack overflow in WinForm apps. (#114432)

* Fix issue when logging stack overflow in WinForm apps.

WinForm apps doesn't have a console and apparently, Windows implementation
of fileno doesn't have same behaviour as POSIX implementation where a
return of -1 means error. On Windows, fileno will return
-2 when there is no console attached to the app. This bypass the check
in write_file that should have return 0, instead it will call_write that
will return an error that was not fully accounted for leading to a
infinite loop.

Fix makes sure Windows implementation sees -1 and -2 as invalid file
descriptors. Fix also account for errors returned by _write breaking
out of the loop.

Fixes #114412.

* According to POSIX and Win32 documentation of fileno/_fileno there
is no real error return, so as long as it gets called with a valid
stream, it should return something that write/_write should handle
and since we handle error returns from calls to write/_write, in
minipal_log_write it might be better to let underlying API's
decode the meaning of file descriptors returned by fileno/_fileno.

minipal_log_write will only pass stdout/stderr to fileno/_fileno
and they should always be valid file streams, even if there is no
console attached. On a Windows app running without console, it will
return back a file descriptor of -2 in that case that _write will
see as a unavailable console and return -1 that minipal_log_write
will handle.

Author: lateralusX

src/native/minipal/log.c

@@ -3,6 +3,7 @@
 
 #include "minipalconfig.h"
 #include "log.h"
+#include <stddef.h>
 #include <string.h>
 #include <limits.h>
 #include <assert.h>
@@ -220,6 +221,9 @@ void minipal_log_flush_all(void)
 #ifdef HOST_WINDOWS
 #include <Windows.h>
 #include <io.h>
+
+typedef ptrdiff_t ssize_t;
+
 static int sync_file(minipal_log_flags flags)
 {
     switch(flags)
@@ -239,9 +243,16 @@ static int sync_file(minipal_log_flags flags)
 
     return 0;
 }
+
+static ssize_t write_file(int fd, const char* msg, size_t bytes_to_write)
+{
+    assert(bytes_to_write < INT_MAX);
+    return _write(fd, msg, (unsigned int)bytes_to_write);
+}
+
 #define fileno _fileno
-#define write _write
-#elif defined(__APPLE__)
+#else
+#if defined(__APPLE__)
 #include <fcntl.h>
 #include <unistd.h>
 static int sync_file(minipal_log_flags flags)
@@ -269,16 +280,13 @@ static int sync_file(minipal_log_flags flags)
 }
 #endif
 
-static int write_file(int fd, const char* msg, size_t bytes_to_write)
+static ssize_t write_file(int fd, const char* msg, size_t bytes_to_write)
 {
-    if (fd == -1)
-        return 0;
-
-    assert(msg != NULL && msg[0] != '\0');
-    assert(bytes_to_write < INT_MAX);
-
-    return write(fd, msg, (int)bytes_to_write);
+    ssize_t ret = 0;
+    while ((ret = write(fd, msg, bytes_to_write)) < 0 && errno == EINTR);
+    return ret;
 }
+#endif
 
 int minipal_log_write(minipal_log_flags flags, const char* msg)
 {
@@ -290,12 +298,12 @@ int minipal_log_write(minipal_log_flags flags, const char* msg)
     int fd = fileno(get_std_file(flags));
     while (bytes_to_write > 0)
     {
-        size_t chunk_to_write = bytes_to_write < MINIPAL_LOG_MAX_PAYLOAD ? bytes_to_write : MINIPAL_LOG_MAX_PAYLOAD;
-        size_t chunk_written = write_file(fd, msg, chunk_to_write);
-
-        if (chunk_written == 0)
+        ssize_t chunk_written = write_file(fd, msg, bytes_to_write < MINIPAL_LOG_MAX_PAYLOAD ? bytes_to_write : MINIPAL_LOG_MAX_PAYLOAD);
+        if (chunk_written <= 0)
             break;
 
+        assert ((size_t)chunk_written <= bytes_to_write);
+
         msg = msg + chunk_written;
         bytes_to_write -= chunk_written;
         bytes_written += chunk_written;