Skip to content

Commit 421922d

Browse files
committed
Attempt to fix Win7 x86 crash
And a bit of cleanup
1 parent 2cd44c2 commit 421922d

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

src/coreclr/vm/excep.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6563,7 +6563,6 @@ void HandleManagedFaultNew(EXCEPTION_RECORD* pExceptionRecord, CONTEXT* pContext
65636563
#if defined(FEATURE_EH_FUNCLETS)
65646564
*frame->GetGSCookiePtr() = GetProcessGSCookie();
65656565
#endif // FEATURE_EH_FUNCLETS
6566-
//pContext->ContextFlags |= CONTEXT_EXCEPTION_ACTIVE;
65676566
frame->InitAndLink(pContext);
65686567

65696568
Thread *pThread = GetThread();
@@ -7447,7 +7446,9 @@ LONG WINAPI CLRVectoredExceptionHandlerShim(PEXCEPTION_POINTERS pExceptionInfo)
74477446
return EXCEPTION_CONTINUE_SEARCH;
74487447
}
74497448

7449+
#ifdef FEATURE_EH_FUNCLETS
74507450
pExceptionInfo->ContextRecord->ContextFlags |= CONTEXT_EXCEPTION_ACTIVE;
7451+
#endif // FEATURE_EH_FUNCLETS
74517452

74527453
// WARNING
74537454
//

src/coreclr/vm/stackwalk.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,12 +1407,6 @@ BOOL StackFrameIterator::ResetRegDisp(PREGDISPLAY pRegDisp,
14071407
}
14081408

14091409
m_crawl.pFrame->UpdateRegDisplay(m_crawl.pRD, m_flags & UNWIND_FLOATS);
1410-
// #ifdef FEATURE_EH_FUNCLETS
1411-
// if ((m_crawl.pRD->pCurrentContext->ContextFlags & CONTEXT_EXCEPTION_ACTIVE) == 0)
1412-
// {
1413-
// m_crawl.hasFaulted = false;
1414-
// }
1415-
// #endif // FEATURE_EH_FUNCLETS
14161410
_ASSERTE(curPc == GetControlPC(m_crawl.pRD));
14171411
}
14181412

@@ -2733,12 +2727,6 @@ StackWalkAction StackFrameIterator::NextRaw(void)
27332727
if (m_crawl.isFrameless)
27342728
{
27352729
m_crawl.pFrame->UpdateRegDisplay(m_crawl.pRD, m_flags & UNWIND_FLOATS);
2736-
// #ifdef FEATURE_EH_FUNCLETS
2737-
// if ((m_crawl.pRD->pCurrentContext->ContextFlags & CONTEXT_EXCEPTION_ACTIVE) == 0)
2738-
// {
2739-
// m_crawl.hasFaulted = false;
2740-
// }
2741-
// #endif // FEATURE_EH_FUNCLETS
27422730

27432731
#if defined(RECORD_RESUMABLE_FRAME_SP)
27442732
CONSISTENCY_CHECK(NULL == m_pvResumableFrameTargetSP);

0 commit comments

Comments
 (0)