Avoid referencing types of JsonIgnore'd properties.

Author: eiriktsarpalis

src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs

@@ -612,7 +612,17 @@ private void GeneratePropMetadataInitFunc(SourceWriter writer, string propInitMe
                     PropertyGenerationSpec property = properties[i];
                     string propertyName = property.NameSpecifiedInSourceCode;
                     string declaringTypeFQN = property.DeclaringType.FullyQualifiedName;
-                    string propertyTypeFQN = property.PropertyType.FullyQualifiedName;
+
+                    // If the property is ignored and its type is not used anywhere else in the type graph,
+                    // emit a JsonPropertyInfo of type 'object' to avoid unnecessarily referencing the type.
+                    // STJ requires that all ignored properties be included so that it can perform
+                    // necessary run-time validations using configuration not known at compile time
+                    // such as the property naming policy and case sensitivity.
+                    bool isIgnoredPropertyOfUnusedType =
+                        property.DefaultIgnoreCondition is JsonIgnoreCondition.Always &&
+                        !_typeIndex.ContainsKey(property.PropertyType);
+
+                    string propertyTypeFQN = isIgnoredPropertyOfUnusedType ? "object" : property.PropertyType.FullyQualifiedName;
 
                     string getterValue = property switch
                     {
@@ -653,9 +663,12 @@ private void GeneratePropMetadataInitFunc(SourceWriter writer, string propInitMe
                             : $"({JsonConverterTypeRef}<{propertyTypeFQN}>){ExpandConverterMethodName}(typeof({propertyTypeFQN}), new {converterFQN}(), {OptionsLocalVariableName})";
                     }
 
-                    string attributeProviderFactoryExpr = property.IsProperty
-                        ? $"typeof({property.DeclaringType.FullyQualifiedName}).GetProperty({FormatStringLiteral(property.MemberName)}, {InstanceMemberBindingFlagsVariableName}, null, typeof({property.PropertyType.FullyQualifiedName}), {EmptyTypeArray}, null)"
-                        : $"typeof({property.DeclaringType.FullyQualifiedName}).GetField({FormatStringLiteral(property.MemberName)}, {InstanceMemberBindingFlagsVariableName})";
+                    string attributeProviderFactoryExpr = property switch
+                    {
+                        _ when isIgnoredPropertyOfUnusedType => "null",
+                        { IsProperty: true } => $"typeof({property.DeclaringType.FullyQualifiedName}).GetProperty({FormatStringLiteral(property.MemberName)}, {InstanceMemberBindingFlagsVariableName}, null, typeof({propertyTypeFQN}), {EmptyTypeArray}, null)",
+                        _ => $"typeof({property.DeclaringType.FullyQualifiedName}).GetField({FormatStringLiteral(property.MemberName)}, {InstanceMemberBindingFlagsVariableName})",
+                    };
 
                     writer.WriteLine($$"""
                         var {{InfoVarName}}{{i}} = new {{JsonPropertyInfoValuesTypeRef}}<{{propertyTypeFQN}}>

src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs

@@ -14,6 +14,7 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.Text;
 using Xunit;
+using Xunit.Abstractions;
 
 namespace System.Text.Json.SourceGeneration.UnitTests
 {
@@ -133,7 +134,10 @@ public static CSharpGeneratorDriver CreateJsonSourceGeneratorDriver(Compilation
 #endif
         }
 
-        public static JsonSourceGeneratorResult RunJsonSourceGenerator(Compilation compilation, bool disableDiagnosticValidation = false)
+        public static JsonSourceGeneratorResult RunJsonSourceGenerator(
+            Compilation compilation,
+            bool disableDiagnosticValidation = false,
+            ITestOutputHelper? logger = null)
         {
             var generatedSpecs = ImmutableArray<ContextGenerationSpec>.Empty;
             var generator = new JsonSourceGenerator
@@ -144,6 +148,19 @@ public static JsonSourceGeneratorResult RunJsonSourceGenerator(Compilation compi
             CSharpGeneratorDriver driver = CreateJsonSourceGeneratorDriver(compilation, generator);
             driver.RunGeneratorsAndUpdateCompilation(compilation, out Compilation outCompilation, out ImmutableArray<Diagnostic> diagnostics);
 
+            if (logger is not null)
+            {
+                foreach (Diagnostic diagnostic in outCompilation.GetDiagnostics().Concat(diagnostics))
+                {
+                    logger.WriteLine(diagnostic.ToString());
+                }
+
+                foreach (var tree in outCompilation.SyntaxTrees)
+                {
+                    LogGeneratedCode(tree, logger);
+                }
+            }
+
             if (!disableDiagnosticValidation)
             {
                 outCompilation.GetDiagnostics().AssertMaxSeverity(DiagnosticSeverity.Info);
@@ -831,6 +848,59 @@ internal static void AssertMaxSeverity(this IEnumerable<Diagnostic> diagnostics,
         {
             Assert.DoesNotContain(diagnostics, diagnostic => diagnostic.Severity > maxSeverity);
         }
+
+        private static void LogGeneratedCode(SyntaxTree tree, ITestOutputHelper logger)
+        {
+            logger.WriteLine(FileSeparator);
+            logger.WriteLine($"{tree.FilePath} content:");
+            logger.WriteLine(FileSeparator);
+            using NumberedSourceFileWriter lineWriter = new(logger);
+            tree.GetRoot().WriteTo(lineWriter);
+            lineWriter.WriteLine(string.Empty);
+        }
+
+        private static readonly string FileSeparator = new string('=', 140);
+
+        private sealed class NumberedSourceFileWriter : TextWriter
+        {
+            private readonly ITestOutputHelper _logger;
+            private readonly StringBuilder _lineBuilder = new StringBuilder();
+            private int _lineNumber;
+
+            internal NumberedSourceFileWriter(ITestOutputHelper logger)
+            {
+                _logger = logger;
+            }
+
+            public override Encoding Encoding => Encoding.Unicode;
+
+            public override void WriteLine(string? value)
+            {
+                _logger.WriteLine($"{++_lineNumber,6}: {_lineBuilder}{value}");
+                _lineBuilder.Clear();
+            }
+
+            public override void Write(string? value)
+            {
+                if (value is null)
+                {
+                    return;
+                }
+
+                if (value.EndsWith("\r\n", StringComparison.Ordinal))
+                {
+                    WriteLine(value.Substring(0, value.Length - 2));
+                }
+                else if (value.EndsWith("\n", StringComparison.Ordinal))
+                {
+                    WriteLine(value.Substring(0, value.Length - 1));
+                }
+                else
+                {
+                    _lineBuilder.Append(value);
+                }
+            }
+        }
     }
 
     public record struct DiagnosticData(