Skip to content

Commit 3de068c

Browse files
jkotasjkotas
authored
Disable tests failing on NAOT (#102065)
1 parent 3ffa05f commit 3de068c

File tree

7 files changed

+23
-16
lines changed

7 files changed

+23
-16
lines changed

‎src/tests/JIT/Methodical/doublearray/dblarray1.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public static void Run(Action f)
9494
[Fact]
9595
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
9696
[OuterLoop]
97+
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
9798
public static int TestEntryPoint()
9899
{
99100
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)

‎src/tests/JIT/Methodical/doublearray/dblarray2.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,7 @@ public static void Run(Action f)
283283
[Fact]
284284
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
285285
[SkipOnMono("Needs triage")]
286+
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
286287
public static int TestEntryPoint()
287288
{
288289
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)

‎src/tests/JIT/Methodical/doublearray/dblarray3.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ public static void Run(Action f)
144144
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
145145
[SkipOnMono("Needs triage")]
146146
[OuterLoop]
147+
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
147148
public static int TestEntryPoint()
148149
{
149150
Console.WriteLine(RuntimeInformation.ProcessArchitecture);

‎src/tests/JIT/Methodical/doublearray/dblarray4.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ public class DblArray4
2222
[Fact]
2323
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
2424
[OuterLoop]
25+
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
2526
public static int TestEntryPoint()
2627
{
2728
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)

‎src/tests/JIT/Methodical/refany/array2.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ private static void TestRef(TypedReference _ref)
2525

2626
[Fact]
2727
[OuterLoop]
28-
[ActiveIssue("https://github.com/dotnet/runtimelab/issues/155", typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArrayNotSupported))]
2928
public static int TestEntryPoint()
3029
{
3130
ulong[,] aul2 = new ulong[,] { { 1, 2, 3 }, { 4, 5, 6 } };

‎src/tests/JIT/Methodical/refany/array2.il

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111
.publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A )
1212
.ver 4:0:0:0
1313
}
14+
.assembly extern System.Runtime { .publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A ) }
1415
.assembly ASSEMBLY_NAME
1516
{
1617
}
1718
.assembly extern xunit.core {}
19+
.assembly extern Microsoft.DotNet.XUnitExtensions { .publickeytoken = (31 BF 38 56 AD 36 4E 35 ) }
20+
.assembly extern TestLibrary {}
1821
// MVID: {1781A471-82F3-4159-8D0F-B3B5A9FF1BB6}
1922
.namespace JitTest_array2_refany_il
2023
{
@@ -125,6 +128,22 @@
125128
.custom instance void [xunit.core]Xunit.FactAttribute::.ctor() = (
126129
01 00 00 00
127130
)
131+
// [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155", typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArrayNotSupported))]
132+
.custom instance void [Microsoft.DotNet.XUnitExtensions]Xunit.ActiveIssueAttribute::.ctor(string,
133+
class [System.Runtime]System.Type,
134+
string[]) = ( 01 00 2F 68 74 74 70 73 3A 2F 2F 67 69 74 68 75
135+
62 2E 63 6F 6D 2F 64 6F 74 6E 65 74 2F 72 75 6E
136+
74 69 6D 65 6C 61 62 2F 69 73 73 75 65 73 2F 31
137+
35 35 61 54 65 73 74 4C 69 62 72 61 72 79 2E 50
138+
6C 61 74 66 6F 72 6D 44 65 74 65 63 74 69 6F 6E
139+
2C 20 54 65 73 74 4C 69 62 72 61 72 79 2C 20 56
140+
65 72 73 69 6F 6E 3D 30 2E 30 2E 30 2E 30 2C 20
141+
43 75 6C 74 75 72 65 3D 6E 65 75 74 72 61 6C 2C
142+
20 50 75 62 6C 69 63 4B 65 79 54 6F 6B 65 6E 3D
143+
6E 75 6C 6C 01 00 00 00 24 49 73 4E 6F 6E 5A 65
144+
72 6F 4C 6F 77 65 72 42 6F 75 6E 64 41 72 72 61
145+
79 4E 6F 74 53 75 70 70 6F 72 74 65 64 00 00 )
146+
128147
.entrypoint
129148
// Code size 150 (0x96)
130149
.maxstack 4

‎src/tests/issues.targets

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,21 +1152,6 @@
11521152

11531153
<!-- NativeAOT x86 specific -->
11541154
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TestBuildMode)' == 'nativeaot' and '$(RuntimeFlavor)' == 'coreclr' and '$(TargetArchitecture)' == 'x86'">
1155-
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_d/**">
1156-
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
1157-
</ExcludeList>
1158-
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_do/**">
1159-
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
1160-
</ExcludeList>
1161-
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_r/**">
1162-
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
1163-
</ExcludeList>
1164-
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_ro/**">
1165-
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
1166-
</ExcludeList>
1167-
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray3_cs_do/**">
1168-
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
1169-
</ExcludeList>
11701155
<ExcludeList Include="$(XunitTestBinBase)/JIT/opt/perf/doublealign/Arrays/**">
11711156
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
11721157
</ExcludeList>

0 commit comments

Comments
 (0)