Skip to content

Commit 323bdf3

Browse files
authored
[7.0] Fix intellisense xml file selection from 'net' or 'dotnet-plat-ext' (#82554)
* Remove 'net' leaf folder from XmlDocFileRoot. * Ensure files from both 'net' and 'dotnet-plat-ext' are included in artifacts/bin/docs copy. * Find the right intellisense xml file from the internal nupkg in either the 'net' or the 'dotnet-plat-ext' folder when packaging. --------- Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
1 parent 0e0edcd commit 323bdf3

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
<IbcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'ibc'))</IbcOptimizationDataDir>
9292
<MibcOptimizationDataDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'mibc'))</MibcOptimizationDataDir>
9393
<XmlDocDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'docs'))</XmlDocDir>
94-
<XmlDocFileRoot>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.private.intellisense', '$(MicrosoftPrivateIntellisenseVersion)', 'IntellisenseFiles', 'net'))</XmlDocFileRoot>
94+
<XmlDocFileRoot>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.private.intellisense', '$(MicrosoftPrivateIntellisenseVersion)', 'IntellisenseFiles'))</XmlDocFileRoot>
9595
<DocsDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'docs'))</DocsDir>
9696
<ManPagesDir>$([MSBuild]::NormalizeDirectory('$(DocsDir)', 'manpages'))</ManPagesDir>
9797

eng/packaging.targets

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@
2424
'$(BuildAllConfigurations)' == 'true' and
2525
'$(DotNetBuildFromSource)' == 'true'">true</GeneratePackageOnBuild>
2626
<!-- Search for the documentation file in the intellisense package and otherwise pick up the generated one. -->
27-
<LibIntellisenseDocumentationFilePath>$(XmlDocFileRoot)1033\$(AssemblyName).xml</LibIntellisenseDocumentationFilePath>
27+
<IntellisenseNetFile>$([MSBuild]::NormalizePath('$(XmlDocFileRoot)', 'net', '1033', '$(AssemblyName).xml'))</IntellisenseNetFile>
28+
<LibIntellisenseDocumentationFilePath Condition="Exists(IntellisenseNetFile)">$(IntellisenseNetFile)</LibIntellisenseDocumentationFilePath>
29+
<IntellisenseDotNetPlatExtFile Condition="'$(LibIntellisenseDocumentationFilePath)' == ''">$([MSBuild]::NormalizePath('$(XmlDocFileRoot)', 'dotnet-plat-ext', '1033', '$(AssemblyName).xml'))</IntellisenseDotNetPlatExtFile>
30+
<LibIntellisenseDocumentationFilePath Condition="'$(LibIntellisenseDocumentationFilePath)' == '' and Exists($(IntellisenseDotNetPlatExtFile))">$(IntellisenseDotNetPlatExtFile)</LibIntellisenseDocumentationFilePath>
2831
<UseIntellisenseDocumentationFile Condition="'$(UseIntellisenseDocumentationFile)' == '' and Exists('$(LibIntellisenseDocumentationFilePath)')">true</UseIntellisenseDocumentationFile>
2932
</PropertyGroup>
3033

eng/restore/docs.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
AfterTargets="Restore">
1010

1111
<ItemGroup>
12-
<DocFile Include="$(XmlDocFileRoot)**\*.xml"/>
12+
<DocFile Include="$(XmlDocFileRoot)\net\**\*.xml;$(XmlDocFileRoot)\dotnet-plat-ext\**\*.xml"/>
1313
<DocFile>
1414
<!-- trim off slash since it differs by platform and we need to do a string compare -->
1515
<LCID>$([System.String]::new('%(RecursiveDir)').TrimEnd('\/'))</LCID>
@@ -35,7 +35,7 @@
3535
</ItemGroup>
3636

3737
<Error Condition="'%(DocFile.Culture)' == 'unknown'" Text="Unknown language folder '%(LCID)' for doc files '@(DocFile)'" />
38-
38+
3939
<Copy SourceFiles="@(DocFile)"
4040
DestinationFiles="$(XmlDocDir)\%(SubFolder)%(FileName)%(Extension)"
4141
SkipUnchangedFiles="true"

0 commit comments

Comments
 (0)