Avoid running GetDisplayNameTests in parallel (dotnet/linker#2701)

tlakollo · web-flow · commit 301d7bfac6e8 · 2022-03-21T16:54:54.000-07:00
There seems to be a race condition on Cecil while trying to get GenericParameters, if a multithreaded test asks simultaneously about GenericParameters on the same type Cecil answers could vary creating test failures. Fixes dotnet/linker#2693 Commit migrated from dotnet/linker@5d8277a
diff --git a/src/tools/illink/test/Mono.Linker.Tests/Tests/GetDisplayNameTests.cs b/src/tools/illink/test/Mono.Linker.Tests/Tests/GetDisplayNameTests.cs
@@ -8,6 +8,7 @@
 
 namespace Mono.Linker.Tests
 {
+	[NonParallelizable]
 	[TestFixture]
 	public class GetDisplayNameTests
 	{
@@ -231,4 +232,4 @@ public static void Method ()
 		{
 		}
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`
`9`	`9`	`namespace Mono.Linker.Tests`
`10`	`10`	`{`
	`11`	`+ [NonParallelizable]`
`11`	`12`	`[TestFixture]`
`12`	`13`	`public class GetDisplayNameTests`
`13`	`14`	`{`
`@@ -231,4 +232,4 @@ public static void Method ()`
`231`	`232`	`{`
`232`	`233`	`}`
`233`	`234`	`}`
`234`		`-}`
	`235`	`+}`