fix logic in type logging

davmason · davmason · commit 1db4526d37ee · 2020-07-07T13:41:37.000-07:00
diff --git a/src/coreclr/src/vm/eventtrace.cpp b/src/coreclr/src/vm/eventtrace.cpp
@@ -3560,7 +3560,7 @@ BOOL ETW::TypeSystemLog::AddTypeToGlobalCacheIfNotExists(TypeHandle th, BOOL * p
     {
         CrstHolder _crst(GetHashCrst());
         // Like above, check if the type has been added from a different thread since we last looked it up.
-        if (pLoggedTypesFromModule->loggedTypesFromModuleHash.Lookup(th).th.IsNull())
+        if (!pLoggedTypesFromModule->loggedTypesFromModuleHash.Lookup(th).th.IsNull())
         {
             *pfCreatedNew = FALSE;
             return fSucceeded;

Original file line number	Diff line number	Diff line change
`@@ -3560,7 +3560,7 @@ BOOL ETW::TypeSystemLog::AddTypeToGlobalCacheIfNotExists(TypeHandle th, BOOL * p`
`3560`	`3560`	`{`
`3561`	`3561`	`CrstHolder _crst(GetHashCrst());`
`3562`	`3562`	`// Like above, check if the type has been added from a different thread since we last looked it up.`
`3563`		`- if (pLoggedTypesFromModule->loggedTypesFromModuleHash.Lookup(th).th.IsNull())`
	`3563`	`+ if (!pLoggedTypesFromModule->loggedTypesFromModuleHash.Lookup(th).th.IsNull())`
`3564`	`3564`	`{`
`3565`	`3565`	`*pfCreatedNew = FALSE;`
`3566`	`3566`	`return fSucceeded;`